Commit 950cdd9b authored by Wez Furlong's avatar Wez Furlong Committed by Facebook GitHub Bot

getdeps: windows: avoid expanding drive letter substitutions

Summary:
We use drive letter substitutions to workaround Windows
filename length limitations.  On my personal Windows system running
python 3.8.2 realpath inside an ssh session manages to resolve to
the full filename which causes the boost build to fail.

Avoid that!

Reviewed By: chadaustin

Differential Revision: D21507851

fbshipit-source-id: 1220c1c85d2124ddc51f42cefff2ce00e10c55c9
parent 5b7309d5
......@@ -412,7 +412,10 @@ def setup_build_options(args, host_type=None):
# Make sure we normalize the scratch path. This path is used as part of the hash
# computation for detecting if projects have been updated, so we need to always
# use the exact same string to refer to a given directory.
scratch_dir = os.path.realpath(scratch_dir)
# But! realpath in some combinations of Windows/Python3 versions can expand the
# drive substitutions on Windows, so avoid that!
if not is_windows():
scratch_dir = os.path.realpath(scratch_dir)
host_type = _check_host_type(args, host_type)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment