Skip to content

F
folly
Commit 99994d0a authored by Andrii Grynenko's avatar Andrii Grynenko Committed by Facebook Github Bot
Browse files
Options

Increase fiber stack size if UBSAN is enabled 

Summary: UBSAN instrumentation results in more stack being used. Applying the same logic we already have for ASAN there.

Reviewed By: igorsugak

Differential Revision: D4287455

fbshipit-source-id: 1a224cb5a3654c23b15fa298bf80476234a1418c
parent bc779ac3
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
folly/fibers/FiberManagerInternal-inl.h
View file @ 99994d0a
...@@ -37,8 +37,8 @@ namespace fibers { ...@@ -37,8 +37,8 @@ namespace fibers {
namespace { namespace {
inline FiberManager::Options preprocessOptions(FiberManager::Options opts) { inline FiberManager::Options preprocessOptions(FiberManager::Options opts) {
#ifdef FOLLY_SANITIZE_ADDRESS #if defined(FOLLY_SANITIZE_ADDRESS) || defined(UNDEFINED_SANITIZER)
/* ASAN needs a lot of extra stack space. /* ASAN/UBSAN needs a lot of extra stack space.
16x is a conservative estimate, 8x also worked with tests 16x is a conservative estimate, 8x also worked with tests
where it mattered. Note that overallocating here does not necessarily where it mattered. Note that overallocating here does not necessarily
increase RSS, since unused memory is pretty much free. */ increase RSS, since unused memory is pretty much free. */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment