Include the correct headers in various tests

Summary: There are two types of includes this adds. The first are standard library headers that weer previously included by transitive dependencies, but aren't included under MSVC, so need to be explicitly included. The second type is a couple of portability headers.

Reviewed By: yfeldblum

Differential Revision: D3513196

fbshipit-source-id: 4f2ac1207aee887ba41c19f5490003e5fe4088f4

folly/experimental/TestUtil.cpp

@@ -18,7 +18,6 @@
 
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
 
 #include <boost/regex.hpp>
 #include <folly/Conv.h>
@@ -28,6 +27,7 @@
 #include <folly/Memory.h>
 #include <folly/String.h>
 #include <folly/portability/Environment.h>
+#include <folly/portability/Fcntl.h>
 #include <folly/portability/Unistd.h>
 
 namespace folly {

folly/experimental/test/TestUtilTest.cpp

@@ -23,10 +23,12 @@
 #include <system_error>
 
 #include <boost/algorithm/string.hpp>
-#include <folly/Memory.h>
 #include <glog/logging.h>
 #include <gtest/gtest.h>
 
+#include <folly/Memory.h>
+#include <folly/portability/Environment.h>
+
 using namespace folly;
 using namespace folly::test;
 

folly/futures/test/CollectTest.cpp

@@ -16,6 +16,8 @@
 
 #include <gtest/gtest.h>
 
+#include <numeric>
+
 #include <boost/thread/barrier.hpp>
 
 #include <folly/futures/Future.h>

folly/io/async/test/SocketPair.cpp

@@ -19,10 +19,10 @@
 #include <folly/io/async/test/SocketPair.h>
 
 #include <folly/Conv.h>
+#include <folly/portability/Fcntl.h>
 #include <folly/portability/Sockets.h>
 #include <folly/portability/Unistd.h>
 
-#include <fcntl.h>
 #include <errno.h>
 #include <sys/types.h>
 #include <stdexcept>

folly/io/async/test/TimeUtil.h

@@ -18,6 +18,8 @@
 #include <chrono>
 #include <iostream>
 
+#include <folly/portability/SysTypes.h>
+
 namespace folly {
 
 class TimePoint {

folly/test/AtomicLinkedListTest.cpp

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+#include <algorithm>
 #include <thread>
 
 #include <gtest/gtest.h>

folly/test/FutexTest.cpp

@@ -24,7 +24,8 @@
 
 #include <glog/logging.h>
 #include <gtest/gtest.h>
-#include <time.h>
+
+#include <folly/portability/Time.h>
 
 using namespace folly::detail;
 using namespace folly::test;

folly/test/MemoryIdlerTest.cpp

@@ -17,6 +17,7 @@
 #include <folly/detail/MemoryIdler.h>
 
 #include <folly/Baton.h>
+#include <folly/portability/Windows.h>
 
 #include <memory>
 #include <thread>

folly/test/SmallLocksTest.cpp

@@ -25,13 +25,13 @@
 #include <string>
 #include <vector>
 #include <pthread.h>
-#include <unistd.h>
 
 #include <thread>
 
 #include <gtest/gtest.h>
 
 #include <folly/portability/Asm.h>
+#include <folly/portability/Unistd.h>
 
 using folly::MSLGuard;
 using folly::MicroLock;

folly/test/ThreadLocalBenchmark.cpp

@@ -16,9 +16,7 @@
 
 #include <folly/ThreadLocal.h>
 
-#include <dlfcn.h>
 #include <sys/types.h>
-#include <sys/wait.h>
 
 #include <array>
 #include <atomic>

folly/test/TimeseriesHistogramTest.cpp

@@ -17,6 +17,8 @@
 #include <folly/stats/TimeseriesHistogram.h>
 #include <folly/stats/TimeseriesHistogram-defs.h>
 
+#include <random>
+
 #include <gtest/gtest.h>
 
 using namespace std;

folly/test/TimeseriesTest.cpp

@@ -19,6 +19,8 @@
 #include <folly/stats/MultiLevelTimeSeries.h>
 #include <folly/stats/MultiLevelTimeSeries-defs.h>
 
+#include <array>
+
 #include <glog/logging.h>
 #include <gtest/gtest.h>