Commit a79183e4 authored by Joe Loser's avatar Joe Loser Committed by Facebook Github Bot

Cut disabling uninitialized warnings in folly/experimental/Bits.h (#1033)

Summary:
- `folly/experimental/Bits.h` has a section where we disable two
  uninitialized-flavors of warnings that were needed for GCC 4.8
- Since we do not support GCC 4.8 anymore and GCC 5.1 does not have
  issues with this, do not disable the warnings anymore.
Pull Request resolved: https://github.com/facebook/folly/pull/1033

Reviewed By: Orvid

Differential Revision: D14223285

Pulled By: yfeldblum

fbshipit-source-id: 0088341b13e26dff2dc90a768319cccc45e942da
parent c971b9f7
...@@ -210,12 +210,6 @@ struct Bits { ...@@ -210,12 +210,6 @@ struct Bits {
} }
}; };
// gcc 4.8 needs more -Wmaybe-uninitialized tickling, as it propagates the
// taint upstream from loadRMW
FOLLY_PUSH_WARNING
FOLLY_GNU_DISABLE_WARNING("-Wuninitialized")
FOLLY_GCC_DISABLE_WARNING("-Wmaybe-uninitialized")
template <class T, class Traits> template <class T, class Traits>
inline void Bits<T, Traits>::set(T* p, size_t bit) { inline void Bits<T, Traits>::set(T* p, size_t bit) {
T& block = p[blockIndex(bit)]; T& block = p[blockIndex(bit)];
...@@ -274,8 +268,6 @@ inline void Bits<T, Traits>::innerSet( ...@@ -274,8 +268,6 @@ inline void Bits<T, Traits>::innerSet(
Traits::store(*p, v); Traits::store(*p, v);
} }
FOLLY_POP_WARNING
template <class T, class Traits> template <class T, class Traits>
inline bool Bits<T, Traits>::test(const T* p, size_t bit) { inline bool Bits<T, Traits>::test(const T* p, size_t bit) {
return Traits::load(p[blockIndex(bit)]) & (one << bitOffset(bit)); return Traits::load(p[blockIndex(bit)]) & (one << bitOffset(bit));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment