Commit a8d1fd8e authored by Wez Furlong's avatar Wez Furlong Committed by Facebook Github Bot

getdeps: ensure that INST/lib/*.dll are found in PATH on windows

Summary:
We were troubleshooting an issue with the eden tests on windows
where the boost dlls where not being found during gtest discovery.

When we compute the environment, we were only including INST/bin in the
PATH on windows.  On Windows, the dlls are searched for in the PATH, and
since boost installs those into its `lib` dir we were missing those.

This diff causes `lib` dirs to get added to PATH on windows in the same
manner that we would add them to `LD_LIBRARY_PATH` on linux.

Reviewed By: pkaush

Differential Revision: D17694542

fbshipit-source-id: 143a907e6d30d8c12360caa43c8d9c26ff8c88c6
parent 93c3a4e2
...@@ -186,6 +186,8 @@ class BuildOptions(object): ...@@ -186,6 +186,8 @@ class BuildOptions(object):
lib_path = "DYLD_LIBRARY_PATH" lib_path = "DYLD_LIBRARY_PATH"
elif self.is_linux(): elif self.is_linux():
lib_path = "LD_LIBRARY_PATH" lib_path = "LD_LIBRARY_PATH"
elif self.is_windows():
lib_path = "PATH"
else: else:
lib_path = None lib_path = None
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment