Commit adbc74b7 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Disable a range test under MSVC

Summary: Because, as the comment says, MSVC fails miserably at this, producing errors at compile time.

Reviewed By: yfeldblum

Differential Revision: D4207544

fbshipit-source-id: d9a11b72877d22d3d3fe2e2c862d99601ab21431
parent ff77522a
......@@ -1114,8 +1114,15 @@ TEST(RangeFunc, ConstexprStdArray) {
static constexpr const std::array<int, 4> numArray = {{3, 17, 1, 9}};
constexpr const auto numArrayRange = range(numArray);
EXPECT_EQ(17, numArrayRange[1]);
// MSVC 2017 RC and earlier have an issue that causes the beginning and
// end of numArrayRange to point to different copies of numArray, causing
// this attempt to calculate the size to error at compile time because
// they don't point to parts of the same array :(
// https://developercommunity.visualstudio.com/content/problem/3216/
#if !defined(_MSC_VER) || _MSC_VER > 191024629
constexpr const auto numArrayRangeSize = numArrayRange.size();
EXPECT_EQ(4, numArrayRangeSize);
#endif
}
TEST(RangeFunc, ConstexprStdArrayZero) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment