Skip to content

F
folly
Commit b0ab09d8 authored by Adam Simpkins's avatar Adam Simpkins Committed by Facebook Github Bot
Browse files
Options

demangle: remove an old TODO comment 

Summary:
Both the autoconf and cmake build scripts check for
`cplus_demangle_v3_callback()` and define
`FOLLY_HAVE_CPLUS_DEMANGLE_V3_CALLBACK` appropriately.

Reviewed By: meyering

Differential Revision: D6745365

fbshipit-source-id: 3020593c60a21568781b835490b8d64913366cb9
parent a578696f
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 2 deletions
folly/Demangle.cpp
View file @ b0ab09d8
...@@ -27,8 +27,6 @@ ...@@ -27,8 +27,6 @@
// From libiberty // From libiberty
// //
// TODO(tudorb): Detect this with autoconf for the open-source version.
//
// __attribute__((__weak__)) doesn't work, because cplus_demangle_v3_callback // __attribute__((__weak__)) doesn't work, because cplus_demangle_v3_callback
// is exported by an object file in libiberty.a, and the ELF spec says // is exported by an object file in libiberty.a, and the ELF spec says
// "The link editor does not extract archive members to resolve undefined weak // "The link editor does not extract archive members to resolve undefined weak
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment