folly: remove unused includes

Summary:
Found with our include analysis tool.

I had to tweak `portability/Environment.h` to avoid a false positive breaking win32.

Reviewed By: yfeldblum, Orvid

Differential Revision: D4452463

fbshipit-source-id: e2e862e204892037ddde8815218e4deab1bfbb06

folly/experimental/io/HugePageUtil.cpp

@@ -17,11 +17,9 @@
 #include <iostream>
 #include <stdexcept>
 
-#include <folly/File.h>
 #include <folly/Format.h>
 #include <folly/MemoryMapping.h>
 #include <folly/Range.h>
-#include <folly/ScopeGuard.h>
 #include <folly/experimental/io/HugePages.h>
 #include <folly/portability/GFlags.h>
 

folly/experimental/io/HugePages.cpp

@@ -27,15 +27,11 @@
 #include <stdexcept>
 #include <system_error>
 
-#include <boost/noncopyable.hpp>
 #include <boost/regex.hpp>
 
-#include <glog/logging.h>
-
 #include <folly/Conv.h>
 #include <folly/Format.h>
 #include <folly/Range.h>
-#include <folly/ScopeGuard.h>
 #include <folly/String.h>
 
 #include <folly/gen/Base.h>

folly/experimental/symbolizer/SignalHandler.cpp

@@ -32,8 +32,6 @@
 #include <glog/logging.h>
 
 #include <folly/Conv.h>
-#include <folly/FileUtil.h>
-#include <folly/Portability.h>
 #include <folly/ScopeGuard.h>
 #include <folly/experimental/symbolizer/ElfCache.h>
 #include <folly/experimental/symbolizer/Symbolizer.h>

folly/experimental/test/LockFreeRingBufferTest.cpp

@@ -17,7 +17,6 @@
 #include <iostream>
 #include <thread>
 
-#include <folly/detail/Futex.h>
 #include <folly/experimental/LockFreeRingBuffer.h>
 #include <folly/test/DeterministicSchedule.h>
 #include <folly/portability/GTest.h>

folly/experimental/test/TestUtilTest.cpp

@@ -16,8 +16,6 @@
 
 #include <folly/experimental/TestUtil.h>
 
-#include <sys/types.h>
-
 #include <system_error>
 
 #include <boost/algorithm/string.hpp>

folly/futures/test/TimesTest.cpp

@@ -18,8 +18,6 @@
 #include <mutex>
 #include <queue>
 
-#include <glog/logging.h>
-
 #include <folly/futures/Future.h>
 #include <folly/futures/Promise.h>
 #include <folly/portability/GTest.h>

folly/futures/test/WhenTest.cpp

@@ -17,10 +17,7 @@
 #include <memory>
 #include <mutex>
 
-#include <glog/logging.h>
-
 #include <folly/futures/Future.h>
-#include <folly/futures/Promise.h>
 #include <folly/portability/GTest.h>
 
 using namespace folly;

folly/futures/test/WhileDoTest.cpp

@@ -18,8 +18,6 @@
 #include <mutex>
 #include <queue>
 
-#include <glog/logging.h>
-
 #include <folly/futures/Future.h>
 #include <folly/futures/Promise.h>
 #include <folly/portability/GTest.h>

folly/gen/test/CombineTest.cpp

@@ -19,7 +19,6 @@
 
 #include <folly/Range.h>
 #include <folly/FBVector.h>
-#include <folly/experimental/TestUtil.h>
 #include <folly/gen/Base.h>
 #include <folly/gen/Combine.h>
 #include <folly/portability/GTest.h>

folly/gen/test/StringTest.cpp

@@ -14,8 +14,6 @@
  * limitations under the License.
  */
 
-#include <glog/logging.h>
-
 #include <iosfwd>
 #include <map>
 #include <vector>

folly/io/ShutdownSocketSet.cpp

@@ -22,7 +22,6 @@
 #include <glog/logging.h>
 
 #include <folly/FileUtil.h>
-#include <folly/Malloc.h>
 #include <folly/portability/Sockets.h>
 
 namespace folly {

folly/io/async/ScopedEventBaseThread.cpp

@@ -19,7 +19,6 @@
 #include <thread>
 
 #include <folly/Function.h>
-#include <folly/Memory.h>
 #include <folly/io/async/EventBaseManager.h>
 
 using namespace std;

folly/io/async/test/AsyncSSLSocketWriteTest.cpp

@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-#include <folly/Foreach.h>
 #include <folly/io/Cursor.h>
 #include <folly/io/async/AsyncSSLSocket.h>
 #include <folly/io/async/AsyncSocket.h>

folly/json.cpp

@@ -24,7 +24,6 @@
 #include <boost/algorithm/string.hpp>
 
 #include <folly/Conv.h>
-#include <folly/Portability.h>
 #include <folly/Range.h>
 #include <folly/String.h>
 #include <folly/Unicode.h>

folly/portability/Environment.h

@@ -21,8 +21,7 @@
 extern "C" {
 #ifndef _WIN32
 extern char** environ;
-#else
+#endif
 int setenv(const char* name, const char* value, int overwrite);
 int unsetenv(const char* name);
-#endif
 }

folly/test/AtomicHashMapTest.cpp

@@ -21,7 +21,6 @@
 #include <atomic>
 #include <memory>
 
-#include <folly/Assume.h>
 #include <folly/Benchmark.h>
 #include <folly/Conv.h>
 #include <folly/portability/GTest.h>

folly/test/ExceptionTest.cpp

@@ -22,8 +22,6 @@
 #include <cstdio>
 #include <memory>
 
-#include <glog/logging.h>
-
 namespace folly { namespace test {
 
 #define EXPECT_SYSTEM_ERROR(statement, err, msg) \

folly/test/FBStringBenchmark.cpp

@@ -24,7 +24,6 @@
 #include <fstream>
 #include <sstream>
 
-#include <boost/algorithm/string.hpp>
 #include <boost/random.hpp>
 
 #include <folly/Benchmark.h>

folly/test/RandomBenchmark.cpp

@@ -18,7 +18,6 @@
 
 #include <folly/Benchmark.h>
 #include <folly/Foreach.h>
-#include <folly/Range.h>
 
 #include <glog/logging.h>
 

folly/test/SharedMutexTest.cpp

@@ -26,7 +26,6 @@
 #include <folly/Benchmark.h>
 #include <folly/MPMCQueue.h>
 #include <folly/RWSpinLock.h>
-#include <folly/Random.h>
 #include <folly/portability/GFlags.h>
 #include <folly/portability/GTest.h>
 #include <folly/test/DeterministicSchedule.h>

folly/test/ThreadCachedArenaTest.cpp

@@ -29,7 +29,6 @@
 
 #include <folly/Range.h>
 #include <folly/Benchmark.h>
-#include <folly/Portability.h>
 #include <folly/portability/GTest.h>
 
 using namespace folly;