remove the namespace dependency of BENCHMARK_COUNTERS

Summary: BENCHMARK_COUNTERS tests need to set `using folly::UserCounters` or `using namespace folly`. Add absolute namespace path in the macro to get rid of this requirement. Reviewed By: Orvid Differential Revision: D18271700 fbshipit-source-id: 084041142b7c245e3c861943570416ac89ea6c34

remove the namespace dependency of BENCHMARK_COUNTERS
Summary: BENCHMARK_COUNTERS tests need to set `using folly::UserCounters` or `using namespace folly`. Add absolute namespace path in the macro to get rid of this requirement. Reviewed By: Orvid Differential Revision: D18271700 fbshipit-source-id: 084041142b7c245e3c861943570416ac89ea6c34
b35bea8f · Bo Dong · Facebook Github Bot · 05490a16 · b35bea8f
Commit b35bea8f authored Nov 04, 2019 by Bo Dong Committed by Facebook Github Bot Nov 04, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

folly/Benchmark.h folly/Benchmark.h +5 -4

No files found.
--- a/folly/Benchmark.h
+++ b/folly/Benchmark.h
@@ -387,19 +387,20 @@ void printResultComparison(
 #define BENCHMARK_IMPL_COUNTERS(                                               \
    funName, stringName, counters, rv, paramType, paramName)                   \
-  static void funName(UserCounters& FOLLY_PP_DETAIL_APPEND_VA_ARG(paramType)); \
+  static void funName(                                                         \
+      ::folly::UserCounters& FOLLY_PP_DETAIL_APPEND_VA_ARG(paramType));        \
  FOLLY_MAYBE_UNUSED static bool FB_ANONYMOUS_VARIABLE(follyBenchmarkUnused) = \
      (::folly::addBenchmark(                                                  \
           __FILE__,                                                           \
           stringName,                                                         \
-           [](UserCounters& counters FOLLY_PP_DETAIL_APPEND_VA_ARG(            \
+           [](::folly::UserCounters& counters FOLLY_PP_DETAIL_APPEND_VA_ARG(   \
               paramType paramName)) -> unsigned {                             \
             funName(counters FOLLY_PP_DETAIL_APPEND_VA_ARG(paramName));       \
             return rv;                                                        \
           }),                                                                 \
       true);                                                                  \
-  static void funName(UserCounters& counters FOLLY_PP_DETAIL_APPEND_VA_ARG(    \
+  static void funName(::folly::UserCounters& counters                          \
-      paramType paramName))
+                          FOLLY_PP_DETAIL_APPEND_VA_ARG(paramType paramName))
 /**
 * Introduces a benchmark function with support for returning the actual