Commit b9d8fba1 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot 8

Use asm_volatile_memory() for portable memory barriors in LifoSemTests

Summary: The portability headers exist for a reason, so use them.

Reviewed By: yfeldblum

Differential Revision: D3507031

fbshipit-source-id: f88c8ed37e648d38231c1d923c1d69d551beabff
parent 309ac912
......@@ -23,6 +23,7 @@
#include <folly/Benchmark.h>
#include <folly/Random.h>
#include <folly/portability/Asm.h>
#include <folly/portability/GFlags.h>
#include <folly/test/DeterministicSchedule.h>
......@@ -319,7 +320,7 @@ BENCHMARK(single_thread_lifo_post, iters) {
LifoSem sem;
for (size_t n = 0; n < iters; ++n) {
sem.post();
asm volatile ("":::"memory");
asm_volatile_memory();
}
}
......@@ -327,7 +328,7 @@ BENCHMARK(single_thread_lifo_wait, iters) {
LifoSem sem(iters);
for (size_t n = 0; n < iters; ++n) {
sem.wait();
asm volatile ("":::"memory");
asm_volatile_memory();
}
}
......@@ -335,9 +336,9 @@ BENCHMARK(single_thread_lifo_postwait, iters) {
LifoSem sem;
for (size_t n = 0; n < iters; ++n) {
sem.post();
asm volatile ("":::"memory");
asm_volatile_memory();
sem.wait();
asm volatile ("":::"memory");
asm_volatile_memory();
}
}
......@@ -345,7 +346,7 @@ BENCHMARK(single_thread_lifo_trywait, iters) {
LifoSem sem;
for (size_t n = 0; n < iters; ++n) {
EXPECT_FALSE(sem.tryWait());
asm volatile ("":::"memory");
asm_volatile_memory();
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment