Commit be0254f3 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Don't rely on implicit lookup of member names in dependent base classes

Summary:
The standard says this shouldn't be done, but GCC, Clang, and MSVC all do, at least, MSVC does if you don't pass the `/permissive-` switch to disable this non-compliant lookup.
This just qualifies it with `this->` which solves the problem.

MSVC plans to eventually (some time after the 2017 release) enable `/permissive-` by default, so let's start compiling with it now.

Reviewed By: yfeldblum

Differential Revision: D4200725

fbshipit-source-id: 8545c6bcda9ba6006733c15f668805cb1260517a
parent 1f5e574d
......@@ -302,7 +302,7 @@ FutexResult Futex<DeterministicAtomic>::futexWaitImpl(
<< ", .., " << std::hex << waitMask
<< ") beginning..");
futexLock.lock();
if (data == expected) {
if (this->data == expected) {
auto& queue = futexQueues[this];
queue.emplace_back(waitMask, &awoken);
auto ours = queue.end();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment