Disable a few tests on Windows

Summary: Because.

Reviewed By: yfeldblum

Differential Revision: D9568442

fbshipit-source-id: 0a1ecf1904499afa9069d345d70279a527e31b1a

CMake/FollyFunctions.cmake

@@ -212,6 +212,8 @@ function(folly_define_tests)
                 set(test_${cur_test}_tag "HANGING")
               elseif ("x${ARGV${currentArg}}" STREQUAL "xSLOW")
                 set(test_${cur_test}_tag "SLOW")
+              elseif ("x${ARGV${currentArg}}" STREQUAL "xWINDOWS_DISABLED")
+                set(test_${cur_test}_tag "WINDOWS_DISABLED")
               else()
                 message(FATAL_ERROR "Unknown test tag '${ARGV${currentArg}}'!")
               endif()
@@ -251,7 +253,8 @@ function(folly_define_tests)
     if ("x${test_${cur_test}_tag}" STREQUAL "xNONE" OR
         ("x${test_${cur_test}_tag}" STREQUAL "xBROKEN" AND BUILD_BROKEN_TESTS) OR
         ("x${test_${cur_test}_tag}" STREQUAL "xSLOW" AND BUILD_SLOW_TESTS) OR
-        ("x${test_${cur_test}_tag}" STREQUAL "xHANGING" AND BUILD_HANGING_TESTS)
+        ("x${test_${cur_test}_tag}" STREQUAL "xHANGING" AND BUILD_HANGING_TESTS) OR
+        ("x${test_${cur_test}_tag}" STREQUAL "xWINDOWS_DISABLED" AND NOT WIN32)
     )
       set(cur_test_name ${test_${cur_test}_name})
       set(cur_dir_name ${directory_${test_${cur_test}_directory}_name})

CMakeLists.txt

@@ -410,7 +410,8 @@ if (BUILD_TESTS)
 
   folly_define_tests(
     DIRECTORY chrono/test/
-      TEST chrono_conv_test SOURCES ConvTest.cpp
+      TEST chrono_conv_test WINDOWS_DISABLED
+        SOURCES ConvTest.cpp
 
     DIRECTORY compression/test/
       TEST compression_test SLOW SOURCES CompressionTest.cpp
@@ -426,7 +427,8 @@ if (BUILD_TESTS)
       TEST f14_fwd_test SOURCES F14FwdTest.cpp
       TEST f14_map_test SOURCES F14MapTest.cpp
       TEST f14_set_test SOURCES F14SetTest.cpp
-      TEST foreach_test SOURCES ForeachTest.cpp
+      TEST foreach_test WINDOWS_DISABLED
+        SOURCES ForeachTest.cpp
       TEST merge_test SOURCES MergeTest.cpp
       TEST sparse_byte_set_test SOURCES SparseByteSetTest.cpp
 
@@ -435,7 +437,8 @@ if (BUILD_TESTS)
       TEST cache_locality_test SOURCES CacheLocalityTest.cpp
       TEST core_cached_shared_ptr_test SOURCES CoreCachedSharedPtrTest.cpp
       TEST concurrent_hash_map_test SOURCES ConcurrentHashMapTest.cpp
-      TEST dynamic_bounded_queue_test SOURCES DynamicBoundedQueueTest.cpp
+      TEST dynamic_bounded_queue_test WINDOWS_DISABLED
+        SOURCES DynamicBoundedQueueTest.cpp
       TEST unbounded_queue_test SOURCES UnboundedQueueTest.cpp
 
     DIRECTORY executors/test/
@@ -445,7 +448,8 @@ if (BUILD_TESTS)
       TEST fiber_io_executor_test SOURCES FiberIOExecutorTest.cpp
       TEST global_executor_test SOURCES GlobalExecutorTest.cpp
       TEST serial_executor_test SOURCES SerialExecutorTest.cpp
-      TEST thread_pool_executor_test SOURCES ThreadPoolExecutorTest.cpp
+      TEST thread_pool_executor_test WINDOWS_DISABLED
+        SOURCES ThreadPoolExecutorTest.cpp
       TEST threaded_executor_test SOURCES ThreadedExecutorTest.cpp
       TEST timed_drivable_executor_test SOURCES TimedDrivableExecutorTest.cpp
 
@@ -509,7 +513,8 @@ if (BUILD_TESTS)
       TEST fibers_test SOURCES FibersTest.cpp
 
     DIRECTORY functional/test/
-      TEST apply_tuple_test SOURCES ApplyTupleTest.cpp
+      TEST apply_tuple_test WINDOWS_DISABLED
+        SOURCES ApplyTupleTest.cpp
       TEST partial_test SOURCES PartialTest.cpp
 
     DIRECTORY futures/test/
@@ -521,8 +526,8 @@ if (BUILD_TESTS)
       TEST ensure_test SOURCES EnsureTest.cpp
       TEST filter_test SOURCES FilterTest.cpp
       TEST future_splitter_test SOURCES FutureSplitterTest.cpp
-      # MSVC SFINAE bug
-      #TEST future_test SOURCES FutureTest.cpp
+      TEST future_test WINDOWS_DISABLED
+        SOURCES FutureTest.cpp
       TEST header_compile_test SOURCES HeaderCompileTest.cpp
       TEST interrupt_test SOURCES InterruptTest.cpp
       TEST map_test SOURCES MapTest.cpp
@@ -530,8 +535,7 @@ if (BUILD_TESTS)
       TEST poll_test SOURCES PollTest.cpp
       TEST promise_test SOURCES PromiseTest.cpp
       TEST reduce_test SOURCES ReduceTest.cpp
-      # MSVC SFINAE bug
-      #TEST retrying_test SOURCES RetryingTest.cpp
+      TEST retrying_test SOURCES RetryingTest.cpp
       TEST self_destruct_test SOURCES SelfDestructTest.cpp
       TEST shared_promise_test SOURCES SharedPromiseTest.cpp
       TEST test_executor_test SOURCES TestExecutorTest.cpp
@@ -549,7 +553,8 @@ if (BUILD_TESTS)
       TEST when_test SOURCES WhenTest.cpp
       TEST while_do_test SOURCES WhileDoTest.cpp
       TEST will_equal_test SOURCES WillEqualTest.cpp
-      TEST window_test SOURCES WindowTest.cpp
+      TEST window_test WINDOWS_DISABLED
+        SOURCES WindowTest.cpp
 
     DIRECTORY gen/test/
       # MSVC bug can't resolve initializer_list constructor properly
@@ -560,7 +565,8 @@ if (BUILD_TESTS)
 
     DIRECTORY hash/test/
       TEST checksum_test SOURCES ChecksumTest.cpp
-      TEST hash_test SOURCES HashTest.cpp
+      TEST hash_test WINDOWS_DISABLED
+        SOURCES HashTest.cpp
       TEST spooky_hash_v1_test SOURCES SpookyHashV1Test.cpp
       TEST spooky_hash_v2_test SOURCES SpookyHashV2Test.cpp
 
@@ -625,7 +631,8 @@ if (BUILD_TESTS)
 
     DIRECTORY memory/test/
       TEST arena_test SOURCES ArenaTest.cpp
-      TEST thread_cached_arena_test SOURCES ThreadCachedArenaTest.cpp
+      TEST thread_cached_arena_test WINDOWS_DISABLED
+        SOURCES ThreadCachedArenaTest.cpp
       TEST mallctl_helper_test SOURCES MallctlHelperTest.cpp
 
     DIRECTORY portability/test/
@@ -691,10 +698,12 @@ if (BUILD_TESTS)
       TEST expected_test SOURCES ExpectedTest.cpp
       TEST fbvector_test SOURCES FBVectorTest.cpp
       TEST file_test SOURCES FileTest.cpp
+      # Open-source linux build can't handle running this.
       #TEST file_lock_test SOURCES FileLockTest.cpp
       TEST file_util_test HANGING
         SOURCES FileUtilTest.cpp
-      # TEST fingerprint_test SOURCES FingerprintTest.cpp
+      # Linux is apparently unhappy about this.. Should probably figure out why.
+      #TEST fingerprint_test SOURCES FingerprintTest.cpp
       TEST format_other_test SOURCES FormatOtherTest.cpp
       TEST format_test SOURCES FormatTest.cpp
       TEST function_test BROKEN
@@ -723,7 +732,8 @@ if (BUILD_TESTS)
       TEST map_util_test SOURCES MapUtilTest.cpp
       TEST memcpy_test SOURCES MemcpyTest.cpp
       TEST memory_idler_test SOURCES MemoryIdlerTest.cpp
-      TEST memory_test SOURCES MemoryTest.cpp
+      TEST memory_test WINDOWS_DISABLED
+        SOURCES MemoryTest.cpp
       TEST move_wrapper_test SOURCES MoveWrapperTest.cpp
       TEST mpmc_pipeline_test SOURCES MPMCPipelineTest.cpp
       TEST mpmc_queue_test SLOW
@@ -750,10 +760,12 @@ if (BUILD_TESTS)
       #TEST singleton_test SOURCES SingletonTest.cpp
       TEST singleton_test_global SOURCES SingletonTestGlobal.cpp
       TEST singleton_thread_local_test SOURCES SingletonThreadLocalTest.cpp
-      TEST small_vector_test SOURCES small_vector_test.cpp
+      TEST small_vector_test WINDOWS_DISABLED
+        SOURCES small_vector_test.cpp
       TEST sorted_vector_types_test SOURCES sorted_vector_test.cpp
       TEST string_test SOURCES StringTest.cpp
-      TEST synchronized_test SOURCES SynchronizedTest.cpp
+      TEST synchronized_test WINDOWS_DISABLED
+        SOURCES SynchronizedTest.cpp
       TEST thread_cached_int_test SOURCES ThreadCachedIntTest.cpp
       TEST thread_local_test SOURCES ThreadLocalTest.cpp
       TEST timeout_queue_test SOURCES TimeoutQueueTest.cpp