Commit c5269bb3 authored by Taylor Hopper's avatar Taylor Hopper Committed by Facebook Github Bot

Add default constructor to RecordIOReader::Iterator

Summary: For this iterator to satisfy the `input_or_output_iterator` concept in range-v3, it must also satisfy the `semiregular` concept, which requires a default constructor.

Reviewed By: yfeldblum

Differential Revision: D18689298

fbshipit-source-id: a38cde0041ceba1aac79128d428df05ee0f00ab4
parent 19eadc88
...@@ -31,6 +31,9 @@ class RecordIOReader::Iterator : public detail::IteratorFacade< ...@@ -31,6 +31,9 @@ class RecordIOReader::Iterator : public detail::IteratorFacade<
IteratorFacade<Iterator, value_type, std::forward_iterator_tag>; IteratorFacade<Iterator, value_type, std::forward_iterator_tag>;
friend class RecordIOReader; friend class RecordIOReader;
public:
Iterator() = default;
private: private:
Iterator(ByteRange range, uint32_t fileId, off_t pos); Iterator(ByteRange range, uint32_t fileId, off_t pos);
...@@ -49,7 +52,7 @@ class RecordIOReader::Iterator : public detail::IteratorFacade< ...@@ -49,7 +52,7 @@ class RecordIOReader::Iterator : public detail::IteratorFacade<
void advanceToValid(); void advanceToValid();
ByteRange range_; ByteRange range_;
uint32_t fileId_; uint32_t fileId_ = 0;
// stored as a pair so we can return by reference in dereference() // stored as a pair so we can return by reference in dereference()
std::pair<ByteRange, off_t> recordAndPos_; std::pair<ByteRange, off_t> recordAndPos_;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment