Commit c55a29b4 authored by Nicholas Ormrod's avatar Nicholas Ormrod Committed by Pavlo Kushnir

Comparing the same tokens

Summary:
Avoid comparing-the-same-tokens error by parenthesizing one
side.

This diff only touches folly tests

Test Plan: run unit tests

Reviewed By: robbert@fb.com

Subscribers: sdwilsh, njormrod, folly-diffs@

FB internal diff: D1650386

Tasks: 5486739

Signature: t1:1650386:1414713837:cbb578d23f759aa049f4246113d9da6d40504da4
parent 9e2f2ec8
......@@ -149,7 +149,7 @@ void testCmp(const char* str1, const char* str2) {
EXPECT_TRUE(m2 > m1);
EXPECT_TRUE(m2 >= m1);
EXPECT_TRUE(m1 != m2);
EXPECT_TRUE(m1 == m1);
EXPECT_TRUE(m1 == (m1));
EXPECT_FALSE(m1 == m2);
// Also test the copy constructor and assignment operator
......
......@@ -282,16 +282,16 @@ TEST(Optional, Comparisons) {
Optional<int> o1(1);
Optional<int> o2(2);
EXPECT_TRUE(o_ <= o_);
EXPECT_TRUE(o_ == o_);
EXPECT_TRUE(o_ >= o_);
EXPECT_TRUE(o_ <= (o_));
EXPECT_TRUE(o_ == (o_));
EXPECT_TRUE(o_ >= (o_));
EXPECT_TRUE(o1 < o2);
EXPECT_TRUE(o1 <= o2);
EXPECT_TRUE(o1 <= o1);
EXPECT_TRUE(o1 == o1);
EXPECT_TRUE(o1 <= (o1));
EXPECT_TRUE(o1 == (o1));
EXPECT_TRUE(o1 != o2);
EXPECT_TRUE(o1 >= o1);
EXPECT_TRUE(o1 >= (o1));
EXPECT_TRUE(o2 >= o1);
EXPECT_TRUE(o2 > o1);
......@@ -299,7 +299,7 @@ TEST(Optional, Comparisons) {
EXPECT_FALSE(o2 <= o1);
EXPECT_FALSE(o2 <= o1);
EXPECT_FALSE(o2 == o1);
EXPECT_FALSE(o1 != o1);
EXPECT_FALSE(o1 != (o1));
EXPECT_FALSE(o1 >= o2);
EXPECT_FALSE(o1 >= o2);
EXPECT_FALSE(o1 > o2);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment