Commit caed689d authored by Adam Simpkins's avatar Adam Simpkins Committed by Facebook Github Bot

cmake: mark the async_test as BROKEN for now

Summary:
Disable running the async_test in open source builds.  A few of the tests
functions in this binary are flaky.

Additionally, this test consistently hangs in Travis CI builds.  It hangs in
`AsyncSocketTest.ServerAcceptOptions`; I suspect it never sees the socket
accept event and therefore never breaks out of the loop.  I suspect that even
if we fixed this test other subsequent tests would also hang.  We should
ideally update all of the tests to always have their own internal event base
loop timeout rather than potentially looping forever, so it could at least run
other test functions after a hang like this.

Reviewed By: yfeldblum

Differential Revision: D6874011

fbshipit-source-id: 46c07a1cf3216eda1900e214447e6e49b6c8e489
parent 2cd9535c
......@@ -527,7 +527,11 @@ if (BUILD_TESTS)
SOURCES ShutdownSocketSetTest.cpp
DIRECTORY io/async/test/
TEST async_test
# A number of tests in the async_test binary are unfortunately flaky.
# When run under Travis CI a number of the tests also hang (it looks
# like they do not get expected socket accept events, causing them
# to never break out of their event loops).
TEST async_test BROKEN
CONTENT_DIR certs/
HEADERS
AsyncSocketTest.h
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment