folly/AtomicHashArray: use an unsigned type for each of two counters
Summary: * folly/AtomicHashArray.h (numEntries_, numPendingEntries_): Use an unsigned type for each of these. They count things, can never go below 0, and are compared to unsigned values. Otherwise, gcc-4.9 would emit this: folly/AtomicHashArray-inl.h:153:38: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Test Plan: Run this and note there are fewer errors than before: fbconfig --platform-all=gcc-4.9-glibc-2.20 -r folly && fbmake dbgo Reviewed By: philipp@fb.com Subscribers: trunkagent, folly-diffs@ FB internal diff: D1770695 Tasks: 5941250 Signature: t1:1770695:1420683354:bfa4775bc2f8aab74e34772308a5c8b1779243b8
Showing
Please register or sign in to comment