Move retrying parameter to match old behaviour

Summary: The old behaviour passed an r-value after incrementing. Some use cases take an r-value and hence depend on that behaviour. This change makes that consistent.

Reviewed By: yfeldblum

Differential Revision: D24634859

fbshipit-source-id: 872197a11197a5e60f32492f1670dd94cf78c8b8

folly/futures/Retrying.h

@@ -150,7 +150,7 @@ retrying(size_t k, Policy&& p, FF&& ff) {
           return p(kk, std::move(e)).via(ka);
         };
         auto futureFF = [ff = static_cast<FF&&>(ff), ka = std::move(ka)](
-                            size_t v) { return ff(v).via(ka); };
+                            size_t v) { return ff(std::move(v)).via(ka); };
         return retrying(k, std::move(futureP), std::move(futureFF));
       });
   return sf;