Commit e41df7e9 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Don't use folly::shellify in StaticTracepointTest

Summary: It's deprecated, so use the non-deprecated form instead.

Reviewed By: yfeldblum

Differential Revision: D5179133

fbshipit-source-id: 91440bc3768ee68d2aada2299fbfbcdd852f946c
parent bbc51806
...@@ -26,7 +26,6 @@ ...@@ -26,7 +26,6 @@
#include <folly/Conv.h> #include <folly/Conv.h>
#include <folly/Format.h> #include <folly/Format.h>
#include <folly/Random.h> #include <folly/Random.h>
#include <folly/Shell.h>
#include <folly/String.h> #include <folly/String.h>
#include <folly/Subprocess.h> #include <folly/Subprocess.h>
#include <folly/portability/GTest.h> #include <folly/portability/GTest.h>
...@@ -92,14 +91,14 @@ static std::string getExe() { ...@@ -92,14 +91,14 @@ static std::string getExe() {
} }
static std::string getNoteRawContent(const std::string& fileName) { static std::string getNoteRawContent(const std::string& fileName) {
auto args = folly::shellify( auto subProc = folly::Subprocess(
"objdump --{} --{}={} {}", std::vector<std::string>{
"full-content", "objdump",
"section", "--full-content",
".note." + kUSDTSubsectionName, "--section=.note." + kUSDTSubsectionName,
fileName); fileName,
auto subProc = },
folly::Subprocess(args, folly::Subprocess::Options().pipeStdout()); folly::Subprocess::Options().pipeStdout().usePath());
auto output = subProc.communicate(); auto output = subProc.communicate();
auto retCode = subProc.wait(); auto retCode = subProc.wait();
CHECK(retCode.exited()); CHECK(retCode.exited());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment