Commit e653781c authored by Robin Cheng's avatar Robin Cheng Committed by Facebook GitHub Bot

Suppress another TSAN false positive due to openssl not compiled with TSAN instrumentation.

Summary: Similar to D23139413, this is another place where openssl causes TSAN issues widely in fbcode.

Reviewed By: yfeldblum

Differential Revision: D23698225

fbshipit-source-id: e883784500392c2d5be757c37cceb8bf8cc8b2aa
parent 1d2bff8d
...@@ -1302,7 +1302,13 @@ void AsyncSSLSocket::handleConnect() noexcept { ...@@ -1302,7 +1302,13 @@ void AsyncSSLSocket::handleConnect() noexcept {
assert(ssl_); assert(ssl_);
auto originalState = state_; auto originalState = state_;
int ret = SSL_connect(ssl_.get()); int ret;
{
// If openssl is not built with TSAN then we can get a TSAN false positive
// when calling SSL_connect from multiple threads.
folly::annotate_ignore_thread_sanitizer_guard g(__FILE__, __LINE__);
ret = SSL_connect(ssl_.get());
}
if (ret <= 0) { if (ret <= 0) {
int sslError; int sslError;
unsigned long errError; unsigned long errError;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment