folly/test/json_test: fix heap-buffer-overflow in Json.PrintTo test
Summary:Json.PrintTo test if failing with heap-buffer-overflow asan abort. The problem here comes up when values of `std::string` and `std::ostrstring::str()` are compared. `std::ostrstring::str()` returns *non null* terminated array of `char`s. When compared with `std::string` a read from memory after the end that array is made. Fixing the test by replacing `std::ostrstream` with `std::ostringstream`, that does append `\0`. Reviewed By: yfeldblum Differential Revision: D2934352 fb-gh-sync-id: c6a5d765c9951716b8a14715702cf3d940c6d723 shipit-source-id: c6a5d765c9951716b8a14715702cf3d940c6d723
Showing
Please register or sign in to comment