Fix gmock handling in rsocket opensource build

Summary:
Simply linking `GMOCK_LIBS` into a binary was not telling CMake that the binary depends on `gmock` being built. So, let's add that dependency explicitly.

This wasn't breaking in production because we typically build with `-j 4`, and `gmock` was getting built before the first dependent binary would attempt to link.

Also, since `rsocket` bundles its own `gmock`, it is just a waste of time to compile a system-level gmock. It's not a real dependency.

NB: The change in `fbcode_builder.py` is needed because now that `rsocket` no longer depends on anything on Github, driver programs that were unconditionally setting `projects_dir` started to fail to build `rsocket`.

Reviewed By: simpkins

Differential Revision: D16461572

fbshipit-source-id: 1e95654e96256e7ed37d42e702b5433bf2fe5328

build/fbcode_builder/fbcode_builder.py

@@ -87,6 +87,10 @@ class FBCodeBuilder(object):
         # This raises upon detecting options that are specified but unused,
         # because otherwise it is very easy to make a typo in option names.
         self.options_used = set()
+        # Mark 'projects_dir' used even if the build installs no github
+        # projects.  This is needed because driver programs like
+        # `shell_builder.py` unconditionally set this for all builds.
+        self._github_dir = self.option('projects_dir')
         self._github_hashes = dict(_read_project_github_hashes())
 
     def __repr__(self):
@@ -277,11 +281,9 @@ class FBCodeBuilder(object):
             self.run(ShellQuoted('git checkout {hash}').format(hash=git_hash)),
         ] if git_hash else []
 
-        base_dir = self.option('projects_dir')
-
         local_repo_dir = self.option('{0}:local_repo_dir'.format(project), '')
         return self.step('Check out {0}, workdir {1}'.format(project, path), [
-            self.workdir(base_dir),
+            self.workdir(self._github_dir),
             self.run(
                 ShellQuoted('git clone {opts} https://github.com/{p}').format(
                     p=project,
@@ -289,7 +291,9 @@ class FBCodeBuilder(object):
             ) if not local_repo_dir else self.copy_local_repo(
                 local_repo_dir, os.path.basename(project)
             ),
-            self.workdir(path_join(base_dir, os.path.basename(project), path)),
+            self.workdir(
+                path_join(self._github_dir, os.path.basename(project), path),
+            ),
         ] + maybe_change_branch)
 
     def fb_github_project_workdir(self, project_and_path, github_org='facebook'):

build/fbcode_builder/specs/rsocket.py

@@ -11,7 +11,7 @@ import specs.folly as folly
 
 def fbcode_builder_spec(builder):
     return {
-        'depends_on': [folly, gmock],
+        'depends_on': [folly],
         'steps': [
             builder.fb_github_cmake_install(
                 'rsocket-cpp/rsocket',