Add missing switch case

Summary: Add missing switch case

Reviewed By: yfeldblum

Differential Revision: D17945170

fbshipit-source-id: 8128c40e1c86b2a5ff8d1bad3c0e9fe197adc174

folly/Benchmark.cpp

@@ -335,6 +335,7 @@ class BenchmarkResultsPrinter {
                   int(name.length()),
                   metricReadable(ptr->value, 2).c_str());
               break;
+            case UserMetric::Type::CUSTOM:
             default:
               printf("  %-*d", int(name.length()), ptr->value);
           }

folly/Conv.h

@@ -775,6 +775,7 @@ toAppend(
     case DoubleToStringConverter::FIXED:
       conv.ToFixed(value, int(numDigits), &builder);
       break;
+    case DoubleToStringConverter::PRECISION:
     default:
       assert(mode == DoubleToStringConverter::PRECISION);
       conv.ToPrecision(value, int(numDigits), &builder);

folly/Expected.h

@@ -213,6 +213,7 @@ struct ExpectedStorage {
       case Which::eError:
         this->assignError(static_cast<Other&&>(that).error());
         break;
+      case Which::eEmpty:
       default:
         this->clear();
         break;
@@ -407,6 +408,7 @@ struct ExpectedStorage<Value, Error, StorageType::eUnion>
       case Which::eError:
         this->error().~Error();
         break;
+      case Which::eEmpty:
       default:
         break;
     }
@@ -457,6 +459,7 @@ struct ExpectedStorage<Value, Error, StorageType::eUnion>
       case Which::eError:
         this->assignError(static_cast<Other&&>(that).error());
         break;
+      case Which::eEmpty:
       default:
         this->clear();
         break;
@@ -508,6 +511,7 @@ struct ExpectedStorage<Value, Error, StorageType::ePODStruct> {
       case Which::eError:
         this->assignError(static_cast<Other&&>(that).error());
         break;
+      case Which::eEmpty:
       default:
         this->clear();
         break;

folly/FBString.h

@@ -476,6 +476,7 @@ class fbstring_core {
           return ml_.size_;
         }
         break;
+      case Category::isMedium:
       default:
         break;
     }

folly/Format-inl.h

@@ -339,6 +339,7 @@ void formatString(StringPiece val, FormatArg& arg, FormatCallback& cb) {
       case FormatArg::Align::PAD_AFTER_SIGN:
         pad(padChars);
         break;
+      case FormatArg::Align::INVALID:
       default:
         abort();
         break;
@@ -463,6 +464,9 @@ class FormatValue<
           case FormatArg::Sign::SPACE_OR_MINUS:
             sign = ' ';
             break;
+          case FormatArg::Sign::DEFAULT:
+          case FormatArg::Sign::MINUS:
+          case FormatArg::Sign::INVALID:
           default:
             sign = '\0';
             break;

folly/Format.cpp

@@ -134,6 +134,9 @@ void FormatValue<double>::formatHelper(
     case FormatArg::Sign::SPACE_OR_MINUS:
       plusSign = ' ';
       break;
+    case FormatArg::Sign::DEFAULT:
+    case FormatArg::Sign::MINUS:
+    case FormatArg::Sign::INVALID:
     default:
       plusSign = '\0';
       break;

folly/IPAddress.cpp

@@ -121,6 +121,8 @@ CIDRNetwork IPAddress::createNetwork(
           vec.size() == 2 ? vec.at(1) : to<string>(cidr),
           subnet.bitCount()));
     }
+    case CIDRNetworkError::INVALID_DEFAULT_CIDR:
+    case CIDRNetworkError::INVALID_IP_SLASH_CIDR:
     default:
       // unreachable
       break;

folly/Try-inl.h

@@ -168,6 +168,7 @@ void Try<T>::throwIfFailed() const {
       return;
     case Contains::EXCEPTION:
       e_.throw_exception();
+    case Contains::NOTHING:
     default:
       throw_exception<UsingUninitializedTry>();
   }

folly/compression/Compression.cpp

@@ -1323,6 +1323,15 @@ static lzma_ret lzmaThrowOnError(lzma_ret const rc) {
     case LZMA_STREAM_END:
     case LZMA_BUF_ERROR: // not fatal: returned if no progress was made twice
       return rc;
+    case LZMA_NO_CHECK:
+    case LZMA_UNSUPPORTED_CHECK:
+    case LZMA_GET_CHECK:
+    case LZMA_MEM_ERROR:
+    case LZMA_MEMLIMIT_ERROR:
+    case LZMA_FORMAT_ERROR:
+    case LZMA_OPTIONS_ERROR:
+    case LZMA_DATA_ERROR:
+    case LZMA_PROG_ERROR:
     default:
       throw std::runtime_error(
           to<std::string>("LZMA2StreamCodec: error: ", rc));

folly/dynamic-inl.h

@@ -1032,6 +1032,9 @@ T dynamic::asImpl() const {
       return to<T>(*get_nothrow<bool>());
     case STRING:
       return to<T>(*get_nothrow<std::string>());
+    case NULLT:
+    case ARRAY:
+    case OBJECT:
     default:
       throw_exception<TypeError>("int/double/bool/string", type());
   }

folly/dynamic.cpp

@@ -462,6 +462,7 @@ const dynamic* dynamic::get_ptr(json_pointer const& jsonPtr) const& {
       throw_exception<TypeError>("object/array", objType);
     case err_code::json_pointer_out_of_bounds:
       return nullptr;
+    case err_code::other:
     default:
       return nullptr;
   }

folly/experimental/bser/Load.cpp

@@ -46,6 +46,15 @@ static int64_t decodeInt(Cursor& curs) {
       return curs.read<int32_t>();
     case BserType::Int64:
       return curs.read<int64_t>();
+    case BserType::Array:
+    case BserType::Object:
+    case BserType::String:
+    case BserType::Real:
+    case BserType::True:
+    case BserType::False:
+    case BserType::Null:
+    case BserType::Template:
+    case BserType::Skip:
     default:
       throwDecodeError(
           curs, "invalid integer encoding detected (", (int8_t)enc, ")");
@@ -192,6 +201,15 @@ static size_t decodeHeader(Cursor& curs) {
     case BserType::Int64:
       int_size = 8;
       break;
+    case BserType::Array:
+    case BserType::Object:
+    case BserType::String:
+    case BserType::Real:
+    case BserType::True:
+    case BserType::False:
+    case BserType::Null:
+    case BserType::Template:
+    case BserType::Skip:
     default:
       int_size = 0;
   }

folly/futures/detail/Core.h

@@ -650,7 +650,10 @@ class Core final {
       case State::OnlyCallbackAllowInline:
         proxyCallback(state);
         break;
-
+      case State::OnlyResult:
+      case State::Proxy:
+      case State::Done:
+      case State::Empty:
       default:
         terminate_with<std::logic_error>("setCallback unexpected state");
     }
@@ -705,7 +708,10 @@ class Core final {
         state_.store(State::Done, std::memory_order_relaxed);
         doCallback(std::move(completingKA), state);
         return;
-
+      case State::OnlyResult:
+      case State::Proxy:
+      case State::Done:
+      case State::Empty:
       default:
         terminate_with<std::logic_error>("setResult unexpected state");
     }
@@ -846,6 +852,9 @@ class Core final {
       case State::Empty:
         break;
 
+      case State::Start:
+      case State::OnlyCallback:
+      case State::OnlyCallbackAllowInline:
       default:
         terminate_with<std::logic_error>("~Core unexpected state");
     }

folly/io/async/SSLContext.cpp

@@ -53,6 +53,7 @@ SSLContext::SSLContext(SSLVersion version) {
       opt = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_TLSv1 |
           SSL_OP_NO_TLSv1_1;
       break;
+    case SSLv2:
     default:
       // do nothing
       break;
@@ -185,7 +186,7 @@ int SSLContext::getVerificationMode(
     case SSLVerifyPeerEnum::NO_VERIFY:
       mode = SSL_VERIFY_NONE;
       break;
-
+    case SSLVerifyPeerEnum::USE_CTX:
     default:
       break;
   }

folly/io/async/ssl/SSLErrors.cpp

@@ -94,6 +94,10 @@ AsyncSocketException::AsyncSocketExceptionType exTypefromSSLErr(SSLError err) {
       return AsyncSocketException::END_OF_FILE;
     case SSLError::NETWORK_ERROR:
       return AsyncSocketException::NETWORK_ERROR;
+    case SSLError::CLIENT_RENEGOTIATION:
+    case SSLError::INVALID_RENEGOTIATION:
+    case SSLError::EARLY_WRITE:
+    case SSLError::SSL_ERROR:
     default:
       // everything else is a SSL_ERROR
       return AsyncSocketException::SSL_ERROR;

folly/json_patch.cpp

@@ -221,6 +221,12 @@ do_add(
         ptr.error().context->push_back(value);
         break;
       }
+      case res_err_code::other:
+      case res_err_code::index_out_of_bounds:
+      case res_err_code::index_not_numeric:
+      case res_err_code::index_has_leading_zero:
+      case res_err_code::element_not_object_or_array:
+      case res_err_code::json_pointer_out_of_bounds:
       default:
         return folly::makeUnexpected(app_err_code::other);
     }

folly/synchronization/detail/AtomicUtils.h

@@ -28,6 +28,10 @@ inline std::memory_order default_failure_memory_order(
       return std::memory_order_acquire;
     case std::memory_order_release:
       return std::memory_order_relaxed;
+    case std::memory_order_relaxed:
+    case std::memory_order_consume:
+    case std::memory_order_acquire:
+    case std::memory_order_seq_cst:
     default:
       return successMode;
   }

folly/test/IPAddressTest.cpp

@@ -877,6 +877,7 @@ TEST(IPAddress, V6Types) {
         return "teredo";
       case IPAddressV6::Type::T6TO4:
         return "6to4";
+      case IPAddressV6::Type::NORMAL:
       default:
         return "default";
     }

folly/test/JsonTestUtil.cpp

@@ -90,6 +90,10 @@ bool compareDynamicWithNestedJson(
         }
       }
       return false;
+    case dynamic::Type::NULLT:
+    case dynamic::Type::BOOL:
+    case dynamic::Type::DOUBLE:
+    case dynamic::Type::INT64:
     default:
       return false;
   }