Commit ff607e1b authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Remove the relative comparison operators on LogLevel

Summary: MSVC, GCC, and Clang define the relative comparison operators by default on `enum class` values, however under MSVC defining them explicitly causes the compiler to fail to resolve which operator to use, so just remove them entirely, as they aren't needed.

Reviewed By: simpkins

Differential Revision: D5259835

fbshipit-source-id: 1b91db5de0fc47320daabfdd7132ae910887ff0f
parent ab9a4d71
...@@ -98,22 +98,6 @@ inline LogLevel& operator-=(LogLevel& level, uint32_t value) { ...@@ -98,22 +98,6 @@ inline LogLevel& operator-=(LogLevel& level, uint32_t value) {
return level; return level;
} }
/*
* Comparisons between LogLevel values
*/
inline bool operator<=(LogLevel a, LogLevel b) {
return static_cast<uint32_t>(a) <= static_cast<uint32_t>(b);
}
inline bool operator<(LogLevel a, LogLevel b) {
return static_cast<uint32_t>(a) < static_cast<uint32_t>(b);
}
inline bool operator>=(LogLevel a, LogLevel b) {
return static_cast<uint32_t>(a) >= static_cast<uint32_t>(b);
}
inline bool operator>(LogLevel a, LogLevel b) {
return static_cast<uint32_t>(a) > static_cast<uint32_t>(b);
}
/** /**
* Construct a LogLevel from a string name. * Construct a LogLevel from a string name.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment