1. 28 Jan, 2016 4 commits
    • Igor Sugak's avatar
      folly/test/FBVectorTestBenchmarks.cpp.h: remove unused argument · 08391a01
      Igor Sugak authored
      Summary: Remove unused argument `iters`.
      
      Reviewed By: meyering
      
      Differential Revision: D2872551
      
      fb-gh-sync-id: 0989e5b256d4d80dd3ad02401e3fc65d0f749ba6
      08391a01
    • Francis Ma's avatar
      Fix FOLLY_TLS under macosx and clang · eeb13d00
      Francis Ma authored
      Summary: Only include guard iphone simulator and iphone devices for folly_tls
      
      Reviewed By: ldemailly
      
      Differential Revision: D2872383
      
      fb-gh-sync-id: 00fb8c1ee03a97037e92d20aeda75f2435d71f5a
      eeb13d00
    • Igor Sugak's avatar
      folly: use -Wheader-hygiene with clang · 53edc275
      Igor Sugak authored
      Summary: `-Wheader-hygiene` warns on using namespace directive in global context in header.  Fix all of the violations.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2867655
      
      fb-gh-sync-id: 46840f8ece99e7af262058e631635d870bd51149
      53edc275
    • Andrii Grynenko's avatar
      Fix EventBase destruction race in FiberManagerMap · 1ac421a5
      Andrii Grynenko authored
      Summary:
      Previously we could be reading from thread-local FiberManagerMap while it was modified.
      This is now fixed by keeping a per-thread list of EventBases which need to be removed from local maps. On the fast-path no action is taken, since list will be empty.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2853921
      
      fb-gh-sync-id: f05e1924dd2b97bfb359537de1909bbe193e0cb9
      1ac421a5
  2. 27 Jan, 2016 6 commits
    • Francis Ma's avatar
      Make folly::detail::CacheLocality portable on apple · dbf7c3d2
      Francis Ma authored
      Summary:
      This is one of the series steps to port folly::future on ios. Apple doesn't support __thread. Adding a HashingThreadId as a fallback
      on apple.
      
      Reviewed By: nbronson
      
      Differential Revision: D2832068
      
      fb-gh-sync-id: c3389245f3c0bbd36de6260680f7ac6110b3206c
      dbf7c3d2
    • Lucian Grijincu's avatar
      folly: ubsan: reduce vector size to avoid UBSAN timeout · 94174b55
      Lucian Grijincu authored
      Summary:
      Based on diff where this was introduced in {D360195} it seems like
      
      ```
        // This value should we multiple of word size.
        static size_t const kHeapifyCapacitySize = sizeof(
          typename std::aligned_storage<
            sizeof(InternalSizeType),
            alignof(value_type)
          >::type);
        // Threshold to control capacity heapifying.
        static size_t const kHeapifyCapacityThreshold =
          100 * kHeapifyCapacitySize;
      ```
      
      So anything above 100*sizeof(SizeType) should do.
      
      Reviewed By: philippv
      
      Differential Revision: D2871422
      
      fb-gh-sync-id: a69e47286c53887ac05e89dab565b9d609e183a0
      94174b55
    • Orvid King's avatar
      Implement a generalized mechanism for pushing/popping warnings · bd8108c1
      Orvid King authored
      Summary: Folly synchronized requires disabling the shadow warning in a macro, but that doesn't work under MSVC, so abstract a mechansim out that allows them to be handled gracefully.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2870357
      
      Pulled By: Orvid
      
      fb-gh-sync-id: a4b0e425736ddd5293f020b360244554571d397f
      bd8108c1
    • Maxim Georgiev's avatar
      Add mechanizm for caching local and peer addresses in AsyncSSLSocket. · 23e1c2d3
      Maxim Georgiev authored
      Summary: This change adds a flag to AsyncSSLSocket which forces the socket to cache local and remote addresses right after TCP connection is established. Cached address values will be available after the connection is closed. Caching addresses can be halpful in SSL handshake failure investigations.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2863274
      
      fb-gh-sync-id: d7b415292988c2fb187a80422e8ccbf8ba8ab0e3
      23e1c2d3
    • Giuseppe Ottaviano's avatar
      Fix typo in comment · 13f7a671
      Giuseppe Ottaviano authored
      Reviewed By: yfeldblum
      
      Differential Revision: D2869494
      
      fb-gh-sync-id: 889957a92dd7f59c4b9564d1946e9f4058293839
      13f7a671
    • Yedidya Feldblum's avatar
      Extract endianness checks into Portability.h · ddce9087
      Yedidya Feldblum authored
      Summary: [Folly] Extract endianness checks into Portability.h.
      
      Reviewed By: fugalh
      
      Differential Revision: D2857924
      
      fb-gh-sync-id: 23ecd2a3cad661024acb62769cd85df394786c59
      ddce9087
  3. 26 Jan, 2016 2 commits
    • Christopher Dykes's avatar
      Use FOLLY_DEPRECATED rather than directly using GCC specific attributes. · 68a47850
      Christopher Dykes authored
      Summary: Without this MSVC can't compile.
      
      Reviewed By: lbrandy
      
      Differential Revision: D2856598
      
      fb-gh-sync-id: 0e146afe844b0ce5d3782528ed9c3de53f7c8b05
      68a47850
    • Arjen Roodselaar's avatar
      Debian DEBs build script · 25e4743f
      Arjen Roodselaar authored
      Summary:
      This scripts uses fpm to build a somewhat reproducible set of debs which can be deployed to Ubuntu 14.04 hosts. The main library package carries the Folly major version number, allowing multiple versions to be installed alongside. The -dev deb is simply called libfolly-dev and will be upgraded as Folly moves forward. In accordance to the Debian packaging policies the shared libraries have their (debug) symbols stripped and saved to external symbol files, contained in the -dev deb.
      
      sgolemon, yfeldblum you guys are my best guess to review this. Feel free to suggest additional folks if needed.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2806082
      
      fb-gh-sync-id: 42605acccdec781f7a6b59a925121e6ed7c7cdf5
      25e4743f
  4. 25 Jan, 2016 2 commits
    • Christopher Dykes's avatar
      Initialize LifoSem's padding to allow for its constexpr constructor. · ef0c9e47
      Christopher Dykes authored
      Summary: MSVC correctly gives an error about the constexpr constructor not initializing all members.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2856806
      
      fb-gh-sync-id: cef97639906dd3c39e3d3dc2ba939021e15edcb9
      ef0c9e47
    • Michael Bejda's avatar
      Thread-safe RequestContext putIfAbsent operation · 1721cad0
      Michael Bejda authored
      Summary:
      Adds a thread-safe putIfAbsent operation to the RequestContext. The current setContextData() is not sufficent to do it safely.
      Just like setContextData, this method is unfair, as a high volume of reads will block the spinlock.
      
      Reviewed By: fugalh
      
      Differential Revision: D2850752
      
      fb-gh-sync-id: 2ff22ea9e9bd8f27f6ae7a57214a6dbc4fdcd4c5
      1721cad0
  5. 22 Jan, 2016 1 commit
    • David Callahan's avatar
      avoid aggressive optimization · 1723592c
      David Callahan authored
      Summary: GCC will now dead-code eliminate the folly-based version of this test without a mechanisms to force the result to be live.
      
      Reviewed By: ttsugriy
      
      Differential Revision: D2854633
      
      fb-gh-sync-id: 0e3841ed22c040fda7653bcfb5a3f19ca3d1f835
      1723592c
  6. 21 Jan, 2016 4 commits
    • Tom Jackson's avatar
      Add PrintTo for dynamic · e202187f
      Tom Jackson authored
      Summary: Making `EXPECT_EQ(dyn1, dyn2)` easier to debug
      
      Reviewed By: luciang, ot, yfeldblum
      
      Differential Revision: D2848318
      
      fb-gh-sync-id: 0c7cdd292665a493f2b792798df4e6966c1f28db
      e202187f
    • Kyle Nekritz's avatar
      Add getPeerCert() to AsyncTransport. · 31260110
      Kyle Nekritz authored
      Reviewed By: elindsey
      
      Differential Revision: D2850760
      
      fb-gh-sync-id: 60dbc3117e658d2fd083a87884892924bf313019
      31260110
    • Kyle Nekritz's avatar
      Adding OpenSSLPtrTypes.h. · 85e8a2d4
      Kyle Nekritz authored
      Summary:
      So that these deleter and unique_ptr types don't have to be redeclared every single place they are used.
      To be expanded on.
      
      Reviewed By: mzlee
      
      Differential Revision: D2850376
      
      fb-gh-sync-id: e7f8bba320163b8b12a93b5cf3cd9a5921d38edc
      85e8a2d4
    • Dmitry Pleshkov's avatar
      Haswell-specific implementation of Select64 routine. · b2818624
      Dmitry Pleshkov authored
      Summary: k-th bit selection could be efficiently implemented via new BMI2 instruction set.
      
      Reviewed By: ot, philippv
      
      Differential Revision: D2843311
      
      fb-gh-sync-id: 4c0cf52176a03422aef276ce5f677080f67f5fdf
      b2818624
  7. 20 Jan, 2016 2 commits
    • Michael Lee's avatar
      Move StringTest benchmarks into StringBenchmark.cpp · f00612cf
      Michael Lee authored
      Summary: StringTest.cpp is a mix of benchmarks and normal unittests. Fixing this.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2840804
      
      fb-gh-sync-id: d3efc357f5f09385e9f69b70e38b64d59045ff0d
      f00612cf
    • Michael Lee's avatar
      Remove unecessary main functions. · edc4bd3f
      Michael Lee authored
      Summary: Starting with this, but I will keep digging through these. The tests will be compiled into one combined test with a single main.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2841391
      
      fb-gh-sync-id: 78fd153e282f1ca2dbe7ada942dc04fc8ba5d42d
      edc4bd3f
  8. 19 Jan, 2016 1 commit
    • Alan Frindell's avatar
      Add Range::erase · 14564041
      Alan Frindell authored
      Summary: Needed to use StringPiece with boost::algorithm::trim()
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2833657
      
      fb-gh-sync-id: 3430b1a2540279b2f69f04c871df3bca748f2cb1
      14564041
  9. 15 Jan, 2016 3 commits
    • Alexey Spiridonov's avatar
      Print null correctly · c1ab48e4
      Alexey Spiridonov authored
      Summary: Null by itself was printing as 0, now it prints as null, which is consistent with the 'pseudo json' output.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2789284
      
      fb-gh-sync-id: f318b8d0f8349f4b36f868c419842fb50bee9517
      c1ab48e4
    • Aaron Balsara's avatar
      Fix buck build for SSLContext · b015c8c3
      Aaron Balsara authored
      Summary: D2800746 broke buck with an unsigned/signed compare
      
      Reviewed By: dkgi
      
      Differential Revision: D2835102
      
      fb-gh-sync-id: a0b8311b38a199e089d3ed5a69b12f8f8abe38b1
      b015c8c3
    • Aaron Balsara's avatar
      Allow SSLContext to read certificates and keys from memory · d65b7736
      Aaron Balsara authored
      Summary: Added the ability for SSLContext to load X509 Certificates and private keys from memory
      
      Reviewed By: yfeldblum
      
      Differential Revision: D2800746
      
      fb-gh-sync-id: 14cad74f8d761b9b0f07e2827b155cec9ba27f50
      d65b7736
  10. 14 Jan, 2016 2 commits
    • Francis Ma's avatar
      Decouple future and fiber for mobile · 138b7236
      Francis Ma authored
      Summary:
      folly::fibers have a bunch of dependencies that are shaky on mobiles.
      Decoupling it by using folly::Baton instead of folly::fibers::Baton. Should have
      zero effect on fbcode cases.
      
      Reviewed By: djwatson, yfeldblum
      
      Differential Revision: D2821603
      
      fb-gh-sync-id: 0ce3472c9eedf97224e8584d25e04515396cd18e
      138b7236
    • Rachel Kroll's avatar
      match new signal text from prior diff; squash colors (!) · 76dabfa2
      Rachel Kroll authored
      Reviewed By: yfeldblum
      
      Differential Revision: D2828789
      
      fb-gh-sync-id: 71e45ffe31061220e06d7e7762058f8a1501b5cc
      76dabfa2
  11. 13 Jan, 2016 2 commits
  12. 12 Jan, 2016 1 commit
  13. 11 Jan, 2016 1 commit
  14. 09 Jan, 2016 2 commits
    • Yedidya Feldblum's avatar
      SingeltonVault::ScopedExpunger - RAII class to clear singletons · 10627e03
      Yedidya Feldblum authored
      Summary:
      [Folly] `SingeltonVault::ScopedExpunger` - RAII class to clear singletons.
      
      Clears all singletons in the given vault at ctor and dtor times. Useful for unit-tests that need to clear the world.
      
      This need can arise when a unit-test needs to swap out an object used by a singleton for a test-double, but the singleton needing its dependency to be swapped has a type or a tag local to some other translation unit and unavailable in the current translation unit.
      
      Other, better approaches to this need are "plz 2 refactor" ....
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D2802459
      
      fb-gh-sync-id: c24cebd3a464ed5da29ea1d9e7b86c51d61cf631
      10627e03
    • Andrii Grynenko's avatar
      Fix Python FiberTask to properly init/reset Python thread state · b8520e0d
      Andrii Grynenko authored
      Reviewed By: alikhtarov
      
      Differential Revision: D2813735
      
      fb-gh-sync-id: ab3c3e18618ed8bf15f478bcfca008786834e65c
      b8520e0d
  15. 08 Jan, 2016 2 commits
    • Pallab Bhattacharya's avatar
      folly::Symbolizer can be enhanced for dumpStackTrace · 635af78d
      Pallab Bhattacharya authored
      Summary:
      added functionality in Symbolizer.cpp to handle multi-segment binary and to allow symbol lookup via /proc/self/exe when some or whole text is relocated to ANON pages such as during hugification. An example of multi-segment binary : P56071432
      
      cc markw65 - a part of the change include logic pulled from hphp/runtime/base/stack-logger.cpp:symbolize_huge_text so that hugified consumers of dumpStackTrace need not fork off.
      
      Reviewed By: edwardc
      
      Differential Revision: D2802837
      
      fb-gh-sync-id: 577ab1b4ef8f22059894bfdd9c0526a22ee89ca8
      635af78d
    • Giuseppe Ottaviano's avatar
      Fix two fbstring operator+ overloads · 81295897
      Giuseppe Ottaviano authored
      Summary: `insert()` returns `fbstring` in most cases, but `iterator` (that is, `value_type*`) when the first argument is an iterator. Two overloads of `operator+` used `insert` as if it returned `fbstring`, which by chance works anyway unless the resulting string contains a `'\0'` (plus it does an extra string copy). This diff fixes the bug.
      
      Reviewed By: philippv, luciang, Gownta
      
      Differential Revision: D2813713
      
      fb-gh-sync-id: 015188b72813da2dabe23980f50f00832d62aa14
      81295897
  16. 06 Jan, 2016 1 commit
    • David Callahan's avatar
      parse args for -json flag · 5d7bf822
      David Callahan authored
      Reviewed By: yfeldblum
      
      Differential Revision: D2803911
      
      fb-gh-sync-id: 65023cae7fd8e06c30fed100826b4b834ee2e9b1
      5d7bf822
  17. 05 Jan, 2016 4 commits
    • Gustavo Serra Scalet's avatar
      Enable GroupVarint on PPC64 · 061b5de8
      Gustavo Serra Scalet authored
      Summary:
      This PR is necessary for both Folly and HHVM to compile on PPC64 (https://github.com/PPC64/hhvm) and other platforms that are not compatible with SSE instructions.
      
      It also removes GroupVarint32 tables generator dependency on x86 platform.
      Closes https://github.com/facebook/folly/pull/339
      
      Reviewed By: mxw
      
      Differential Revision: D2760156
      
      fb-gh-sync-id: b4e93b54b62d6f68ccf684d34840678f677bf276
      061b5de8
    • David Callahan's avatar
      parse args for -json flag · a0430d4a
      David Callahan authored
      Reviewed By: lbrandy
      
      Differential Revision: D2803778
      
      fb-gh-sync-id: 0cb21413bb1c78d256b4408322f8d585f53cb0ac
      a0430d4a
    • Neel Goyal's avatar
      Add canAdvance to cursor and tests · 1c77ef4f
      Neel Goyal authored
      Summary:
      Determine if the cursor can advance N bytes. This is useful if
      applications want to check before reading so an exception isn't thrown.
      It tries to walk the minimal amount of links needed in the chain.
      
      I had a task that could have used this, though caching totalLength and
      macro magic ended up being the implementation chosen. I think this just
      adds to the cursor API.
      
      Reviewed By: djwatson
      
      Differential Revision: D2728498
      
      fb-gh-sync-id: 8657653b82a48828cccab143653dc169ef715702
      1c77ef4f
    • Michael Lee's avatar
      Switch back to SYS_gettid, and fix · 3f93d783
      Michael Lee authored
      Summary:
      SYS_gettid is different on Linux vs. OSX.  `__NR_gettid` is
      only sometimes present and `SYS_gettid` is only sometimes present, but
      we can pick one name and just follow that one.
      
      Reviewed By: dcolascione
      
      Differential Revision: D2800515
      
      fb-gh-sync-id: 4245de4b9184ac4233ade9da297409c1031869a3
      3f93d783