Skip to content

F
folly
Switch branch/tag
  1. 17 Oct, 2018 25 commits
  3. 16 Oct, 2018 9 commits
    • Yedidya Feldblum's avatar
      Pure C++ for TSAN annotation wrappers · 799a718f
      Yedidya Feldblum authored 
      Summary:
[Folly] Pure C++ for TSAN annotation wrappers, v.s. using the preprocessor.

The implementation uses the preprocessor in order to support platforms without weak symbols, but the interface is now pure C++.

Reviewed By: nbronson

Differential Revision: D10291176

fbshipit-source-id: 3636652793b8d0da59c7c9b1095d4c1b0c506372
      799a718f
    • Adam Simpkins's avatar
      cmake: define FOLLY_USE_LIBSTDCPP in folly-config.h · 07515573
      Adam Simpkins authored 
      Summary:
This setting is already set by FollyConfigChecks.cmake, but was not
actually defined by folly-config.h

This setting is only checked by a few of the concurrency tests.

Reviewed By: igorsugak

Differential Revision: D10405959

fbshipit-source-id: 1602730e6adb7e05a82e65bdc5c367d105f59224
      07515573
    • Adam Simpkins's avatar
      cmake: explicitly link against libatomic when required · 4b0c7ff2
      Adam Simpkins authored 
      Summary:
When using clang with libstdc++ `-latomic` must be explicitly specified
as part of the link command in order to get some of the symbols required
for C++ std::atomic support.

The old autoconf-based build did have this check (added in github commit
60a5636b, D2519083).  However this check was missing from the
CMake-based build.

Reviewed By: igorsugak

Differential Revision: D10405960

fbshipit-source-id: 37291edc5a387e2e966ece79241aa00312194cbd
      4b0c7ff2
    • Dan Melnic's avatar
      Folly zerocopy improvements · 2d6a8fcb
      Dan Melnic authored 
      Summary: Folly zerocopy improvements

Reviewed By: djwatson

Differential Revision: D10324653

fbshipit-source-id: dacb2941e08eaf2e7588c04a01800e297a0643cf
      2d6a8fcb
    • Adam Simpkins's avatar
      support compiling with ASAN for CMake-based builds · a242bf16
      Adam Simpkins authored 
      Summary: Update the CMake files to support compiling with ASAN.

Reviewed By: igorsugak

Differential Revision: D10401270

fbshipit-source-id: 08c7fe3b661c17ba21fd8a8eb3b5cf716ebd3d35
      a242bf16
    • Lee Howes's avatar
      Remaining nullary continuation fixes for folly · 17c593f9
      Lee Howes authored 
      Summary: then to thenValue to remove calls to deprecated functions.

Reviewed By: yfeldblum

Differential Revision: D10366311

fbshipit-source-id: 99c4cd8bcfa2d9db80c2d8eb22300d92609a36fc
      17c593f9
    • Adam Simpkins's avatar
      Add a FOLLY_ASAN_ENABLED macro · af21e4d6
      Adam Simpkins authored 
      Summary:
Add a new macro to track if folly was compiled with ASAN enabled.  This
is in addition to the existing FOLLY_SANITIZE_ADDRESS macro, which
reports if the current .cpp file is being compiled with ASAN enabled.

In particular, these macros differ in open source builds if folly was
compiled without ASAN enabled, but some of its headers are being
included from downstream libraries that are being built with ASAN
enabled.

Previously several headers would define structures differently based on
`FOLLY_SANITIZE_ADDRESS`, which meant that different .cpp files would see
different definitions of these structures.  `FOLLY_ASAN_ENABLED` is generally
the correct macro to use for situations like this.

This diff fixes F14Table.h to use FOLLY_ASAN_ENABLED, but several other
headers probably should also be updated in the future.

I did not change the behavior of FOLLY_SANITIZE_ADDRESS, since it appears to
be used by several projects outside of folly, and they expect it to report if
their code is being compiled with ASAN enabled.

At the moment the open source build does not support compiling with ASAN,
so FOLLY_ASAN_ENABLED is always disabled in open source builds.

Reviewed By: nbronson

Differential Revision: D10401271

fbshipit-source-id: 7e028737b42eecae93f06538dcf76dd64bd32e6a
      af21e4d6
    • Paul Jakma's avatar
      Fix build · a368d112
      Paul Jakma authored 
      Summary: FOLLY_HAVE_LIBJEMALLOC does not get defined, breaking builds in certain configurations (e.g., jemalloc present, Fedora 28 with cmake). FOLLY_USE_JEMALLOC does. Substitute former with latter,

Differential Revision: D10349332

fbshipit-source-id: e30245f8f19c6b2b7861cd88a4e1719a15c10fce
      a368d112
    • Yedidya Feldblum's avatar
      Use explicit memory orders in SerialExecutor · 49f40690
      Yedidya Feldblum authored 
      Summary: [Folly] Use explicit memory orders in `SerialExecutor`.

Reviewed By: andriigrynenko

Differential Revision: D10370862

fbshipit-source-id: 5cc5903d188b131f851a62690cd182de6ba47eb9
      49f40690
  5. 15 Oct, 2018 3 commits
    • Miroslav Crnic's avatar
      Replace queue with UMPSCQueue and decouple queueing from scheduling · db4f831f
      Miroslav Crnic authored 
      Summary:
Reduced contention with removing connection between queue_ and schedule_ access.
Replaced std::queue with unbounded multiple producer single consumer queue.

Reviewed By: yfeldblum

Differential Revision: D10345872

fbshipit-source-id: 3307d908d6e4826eab4d981447c8771021bfe580
      db4f831f
    • Alex Guzman's avatar
      Pend free of SSL in AsyncSSLSocket until async callback completion. · 6687bf85
      Alex Guzman authored 
      Summary: Pends the freeing of the internal SSL until the socket is finally destroyed. This ensures that the async job can write out the result and call the socket's callback. This also always calls restartSSLAccept in order to let it handle errors and cleaning up of async jobs.

Reviewed By: knekritz

Differential Revision: D9599917

fbshipit-source-id: 8c4ce8b762fe59f08c2a40e76a0bebe59cd2929e
      6687bf85
    • Alex Guzman's avatar
      Let AsyncSSLSocket run accept via a runner. · d96d9550
      Alex Guzman authored 
      Summary: Allows for a runner to execute the accept function and return the result via a callback. If no runner is specified, it simply does the accept as usual.

Reviewed By: yfeldblum

Differential Revision: D9849138

fbshipit-source-id: ef43ccc8668bcf1fe7f75b0b6fdcdba7adc891da
      d96d9550
  7. 13 Oct, 2018 2 commits
    • Paul Rosania's avatar
      Detect `std::launder` in libc++ 6 (and Xcode 10) (#948) · fb28875b
      Paul Rosania authored 
      Summary:
Fixes #947.

>libc++ 6+ (and Xcode 10's libc++, which seems to be based on it) adds std::launder, but does not define the __cpp_lib_launder feature-test macro. As a result, folly's lang/Launder.h concludes std::launder is missing and defines its own implementation. Since std::launder does actually exist, ADL causes 'ambiguous call' errors whenever a standard library type like std::pair is laundered within the folly namespace. (This breaks compilation of folly's futures, for example, and I believe it will cause compilation issues anywhere else F14Map is used, since it launders std::pair in its F14Policy.)
Pull Request resolved: https://github.com/facebook/folly/pull/948

Reviewed By: ot

Differential Revision: D10287027

Pulled By: yfeldblum

fbshipit-source-id: be3469fe6855d2af266e1b6a62968770e8cfd76f
      fb28875b
    • Yedidya Feldblum's avatar
      Opportunity to use exchange in ScopeGuardImpl · 0731f1ad
      Yedidya Feldblum authored 
      Summary: [Folly] Opportunity to use `exchange` in `ScopeGuardImpl`.

Reviewed By: Orvid

Differential Revision: D10119838

fbshipit-source-id: 64a00f4f60d913f8af248ebf891f730d2c69fec8
      0731f1ad
  9. 12 Oct, 2018 1 commit
    • Lee Howes's avatar
      Future::then to Future::thenValue · 32b70f14
      Lee Howes authored 
      Summary: then to thenValue to remove calls to deprecated functions.

Reviewed By: Orvid

Differential Revision: D10362133

fbshipit-source-id: e638d24e95c5c6c46d0366eabcd1ff9537421bc6
      32b70f14