- 11 Feb, 2015 6 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Avoid EventBase depending on Baton (mutex/condvar variant). Test Plan: Unit tests: * folly/io/async/test/EventBaseTest.cpp Reviewed By: subodh@fb.com Subscribers: trunkagent, fma, folly-diffs@, yfeldblum, dougw, brettp FB internal diff: D1823407 Signature: t1:1823407:1423088450:71ae1673ed8067103e2aaa1ac9b239eae9ebe9de Blame Revision: D1810764
-
Hans Fugal authored
Summary: It is true. Also, add a useful message about which thread this Future will complete in. Test Plan: it should still compile Reviewed By: davejwatson@fb.com Subscribers: trunkagent, exa, folly-diffs@, jsedgwick, yfeldblum FB internal diff: D1819849 Tasks: 5705286, 6008465 Signature: t1:1819849:1423074012:79bf11c877eb2f061cb5d07f7ab45fa4cc4a894b
-
Hans Fugal authored
Summary: (or func returns Future<T>) Invoke and respond to a timeout with a callback, rather than using `within` and adding `onError` or `then` or something. Test Plan: new tests Reviewed By: davejwatson@fb.com Subscribers: jsedgwick, yfeldblum, trunkagent, fugalh, exa, folly-diffs@ FB internal diff: D1763174 Tasks: 4548494 Signature: t1:1763174:1423074062:05cec1dfb1110b31b599033949ebe0ee70dd0552
-
Hans Fugal authored
Summary: I don't know what this paragraph is even saying. It looks like copypasta Test Plan: still compiles or my uncle is a monkey Reviewed By: davejwatson@fb.com Subscribers: trunkagent, exa, folly-diffs@, jsedgwick, yfeldblum FB internal diff: D1819905 Tasks: 5705286 Signature: t1:1819905:1423074021:a095fe2a17d5698678a527b60c9384625df869fd
-
Tom Jackson authored
Summary: The `memchr()`-based `find_first_of()` behaves extremely badly when it's used in a loop and the input string doesn't contain all the needles. This was discovered when a reasonable line-breaking routine tried to use it to break lines by a mix of '\r' and '\n'. The entire remainder of the file was scanned each time a line was read. Before: ``` CountDelimsBase 1.26s 794.86m CountDelimsNoSSE 100.03% 1.26s 795.12m CountDelimsStd 40501.63% 3.11ms 321.93 CountDelimsMemchr 98.31% 1.28s 781.41m CountDelimsByteSet 23162.41% 5.43ms 184.11 ``` After: ``` CountDelimsBase 3.20ms 312.08 <-- Base impl no longer considers memchr CountDelimsNoSSE 102.37% 3.13ms 319.47 CountDelimsStd 103.19% 3.11ms 322.05 CountDelimsMemchr 0.25% 1.27s 788.39m CountDelimsByteSet 59.68% 5.37ms 186.27 ``` Test Plan: Benchmarks Reviewed By: njormrod@fb.com Subscribers: folly-diffs@, yfeldblum FB internal diff: D1823536 Signature: t1:1823536:1423081687:bb2ec8cdea477ee9b9c8d8ad2bfdecdc52657515
-
Sara Golemon authored
This reverts commit 462e13b1.
-
- 09 Feb, 2015 2 commits
- 04 Feb, 2015 12 commits
-
-
Andrew Cox authored
-
Andrii Grynenko authored
Test Plan: fbmake runtests Reviewed By: chip@fb.com, pavlo@fb.com Subscribers: folly-diffs@, yfeldblum FB internal diff: D1825369 Signature: t1:1825369:1423080185:8507643a3f8860bae6a2240e0ae28fbaf2885b12
-
Dave Watson authored
Summary: As a replacement for makeFuture(). The main advantage is for non-void futures, implicit conversion works pretty well. See unittest for examples Test Plan: fbconfig -r folly/futures; fbmake runtests Reviewed By: hannesr@fb.com Subscribers: yfeldblum, trunkagent, doug, folly-diffs@, jsedgwick FB internal diff: D1806575 Signature: t1:1806575:1422465608:6099f791591b70ce1bcda439b49307b8f3187d89
-
Tom Jackson authored
Summary: Even though the benchmark only keeps the first 10 lines, it gets slower the bigger the "file" is. ``` folly/gen/test/StringBenchmark.cpp relative time/iter iters/s ---------------------------------------------------------------------------- Lines_Gen(1e3) 5.53us 180.94K Lines_Gen(2e3) 66.43% 8.32us 120.21K Lines_Gen(3e3) 48.26% 11.45us 87.33K ``` Test Plan: Benchmarks Reviewed By: lesha@fb.com Subscribers: folly-diffs@, yfeldblum FB internal diff: D1823545 Tasks: 6155600 Signature: t1:1823545:1423023712:86fdb3dadbec44195e4b3596cf793cea80ae3a76
-
Philip Pronin authored
Summary: When closing sockets on retry, we should use `shutdownSocketSet_` if it is set (so socket will properly be removed from the set). Also I changed all `::close()` and `::shutdown()` calls to `*NoInt()` version. Test Plan: fbconfig unicorn/test:basic_compression_test && fbmake opt -j32 while _bin/unicorn/test/test:basic_compression_test; do echo DONE; done Reviewed By: mcduff@fb.com Subscribers: trunkagent, folly-diffs@, yzhan, yfeldblum FB internal diff: D1821104 Tasks: 4752579, 6123510 Signature: t1:1821104:1423001050:5bc09ffdd6666c2884ea82dbd70831a56513cfc9 Blame Revision: D1795120
-
Tianjiao Yin authored
Summary: before: E0203 12:32:34.548096 3354863 [admonitor-local] Singleton.cpp:72] Singleton of type N8facebook12configerator22ConfigeratorStaticDataE has a living reference at destroyInstances time; beware! Raw pointer is 0x7fd6ccc81000. It is very likely that some other singleton is holding a shared_ptr to it. Make dependencies between these singletons are properly defined. after: E0203 13:48:09.013022 3913115 Singleton.cpp:72] Singleton of type facebook::configerator::ConfigeratorStaticData has a living reference at destroyInstances time; beware! Raw pointer is 0x7f6f7dc4c000. It is very likely that some other singleton is holding a shared_ptr to it. Make dependencies between these singletons are properly defined. Test Plan: run it Reviewed By: chip@fb.com Subscribers: folly-diffs@, yfeldblum FB internal diff: D1822466 Signature: t1:1822466:1423000686:345f40fa706701476256a7157468521bc69166a0
-
Dave Watson authored
Summary: This was only used in a unittest, every real use case uses AsyncServerSocket, and decides on its own to do SSL or not. Test Plan: fbconfig -r thrift/lib/cpp/test; fbmake runtests Reviewed By: alandau@fb.com Subscribers: fugalh, trunkagent, doug, alandau, bmatheny, ssl-diffs@, mshneer, jsedgwick, folly-diffs@ FB internal diff: D1806807 Signature: t1:1806807:1422396209:02333c736e1ef10963e3fe0b4ed6ecf6122475bb
-
Dave Watson authored
Summary: Originally meant as a kill switch. It's turned on in everything except adfinder, so we can probably remove this flag after running a couple adfinder canaries I have no idea who should review this in ads team, guessed and added some people Test Plan: https://our.intern.facebook.com/intern/tupperware/canary/view/?experiment_id=32937 Reviewed By: haijunz@fb.com Subscribers: trunkagent, doug, ruibalp, nli, alandau, bmatheny, wormhole-diffs@, mshneer, folly-diffs@ FB internal diff: D1809255 Tasks: 5645329 Signature: t1:1809255:1422490068:5b4551e6c126d86cac8f8e7b06da6474e6b8a25a
-
Andrii Grynenko authored
Summary: This diff introduces 5 seconds wait time to let other threads release Singleton which may be temporarily locked. This helps prevent most of "Singleton object alive after destruction" warnings in cases where weak_ptr API is used correctly. Abusive use of folly::Singletons, where dependencies between singletons are not properly defined will still cause a warning. Test Plan: unit test Reviewed By: chip@fb.com Subscribers: trunkagent, folly-diffs@ FB internal diff: D1808371 Signature: t1:1808371:1422487261:573eb40b6a260e428d96be476659335250c7ea76
-
Haijun Zhu authored
Summary: AsyncSocket sets CLOEXEC if it connects an address, but won't if it uses a connected fd. This sets CLOEXEC for such fd. Test Plan: fbconfig folly/io/async/test && fbmake runtests Reviewed By: davejwatson@fb.com Subscribers: trunkagent, folly-diffs@, zacm FB internal diff: D1809300 Signature: t1:1809300:1422900997:40fcc84506582ac67076fd975a36d094522c35c2
-
Yedidya Feldblum authored
Summary: [Folly] EventBase::runInEventLoopThreadAndWait. Useful for when some code needs to be run in the event loop thread, but another thread needs to trigger the code and then wait for it to be done. Test Plan: Unit tests: * `folly/io/async/test/EventBaseTest.cpp` Reviewed By: davejwatson@fb.com Subscribers: trunkagent, folly-diffs@, brettp, dougw FB internal diff: D1810764 Signature: t1:1810764:1422900654:7ff0aa7feb2792266f620b344cf8a1110a09f7ef
-
Brad Kim authored
-
- 02 Feb, 2015 20 commits
-
-
woo authored
-
Marcin Pawlowski authored
Summary: Fixing following the issues raised by nsuke on github following his diff (https://github.com/facebook/folly/pull/112) Test Plan: visual inspection, tested build on arch linux Reviewed By: davejwatson@fb.com Subscribers: folly-diffs@ FB internal diff: D1807378 Tasks: 5909189 Signature: t1:1807378:1422403093:ca024f396a27ecd9b304c57643f0107764a38ca1
-
Nathan Bronson authored
Summary: fetch_and and fetch_or are actually required in some instances, since the operation they perform isn't reversible. This also adds some other missing functions, ^= and fetch_{add,sub,xor}. Test Plan: use from other code's unit tests Reviewed By: mssarang@fb.com Subscribers: yfeldblum, folly-diffs@ FB internal diff: D1798924 Signature: t1:1798924:1422892374:a9859039075ddcac54f75259b9bc6a29bb963a09 -
Chip Turner authored
Summary: This reverts commit 90da92b05762f8032560d0d6a66237ab2772d7f2. Test Plan: compiles Reviewed By: tjackson@fb.com Subscribers: lins, anca, folly-diffs@, yfeldblum FB internal diff: D1817376 Tasks: 6118752
-
Hans Fugal authored
Summary: There was a race reading `callback_` in `maybeCallback` and setting `callback_` in `setCallback`. This diff reworks the state machine to make this unpossible. To avoid the explosion of states due to the cross-product of has-interrupt-handler/has-been-interrupted/etc. I introduce a separate lock for setting interrupt handler and interruption, since this is primarily orthogonal. Other attributes (active, for example) are still atomic variables, and while somewhat tied into the state machine logically (e.g. transitioning from Armed to Done only happens when active) they are mostly independent, keeping the state machine simple (and probably faster). I think it may even be possible to do some things cheaper. In some states, we may not need to protect the writing of `callback_` and `result_`. But we'd need to enforce some ordering so I'm not going to try to tackle that. But that could be some speedup if we can do it cheaply. Test Plan: Builds and all existing tests pass. Reviewed By: rockyliu4@fb.com Subscribers: yfeldblum, stepan, trunkagent, exa, folly-diffs@, jsedgwick FB internal diff: D1807854 Tasks: 6087856 Signature: t1:1807854:1422656713:25b62706cd7952b2dde06dab08074f8030db456b
-
Nathan Bronson authored
Summary: Add a description of the fault-after-unlock problem that can occur when a synchronization object is used to guard its own destruction. Test Plan: comment change only Reviewed By: alikhtarov@fb.com Subscribers: trunkagent, folly-diffs@ FB internal diff: D1808446 Signature: t1:1808446:1422481173:83c0369e2277cd5b8cf6377fcd92b132019611a7
-
Tom Jackson authored
Summary: That is, for all inputs except r-values. Test Plan: Run tests @override-test-failures Reviewed By: ajaymenon@fb.com Subscribers: trunkagent, folly-diffs@ FB internal diff: D1807789 Signature: t1:1807789:1422410689:442d50ab17f8e3b08e34f33318a4dc7f23b4c6cc
-
Shijin Kong authored
Summary: This speeds up TLS handshake and might be a factor of liger perf regression. The enabling is guarded by an #ifdef. The condition itself is defined in an openssl patch. Test Plan: folly unit tests pass. Tried on devices as well and from tcpdump data was sent before the new ticket was received, essentially speeded up the handshake process. Reviewed By: subodh@fb.com Subscribers: trunkagent, kmdent, seanc, benyluo, ssl-diffs@, ranjeeth, folly-diffs@ FB internal diff: D1806856 Tasks: 5284979 Signature: t1:1806856:1422494521:0a048ea9001da13b5d698b5a764d1e66dcbedc99
-
Tom Jackson authored
Test Plan: Unit tests Reviewed By: ajaymenon@fb.com Subscribers: trunkagent, folly-diffs@ FB internal diff: D1808023 Signature: t1:1808023:1422410709:8db2d73d5b4c0c2eab563643e5fa1557ebfd4730
-
Sean Cannella authored
Summary: Included climits and limits.h due to non-conflicting changes, clean this up. Test Plan: compiled Reviewed By: kelarini@fb.com Subscribers: trunkagent, folly-diffs@ FB internal diff: D1810133 Signature: t1:1810133:1422483209:0826d2198769efed86607de6c5b28ce0bc4ac04b
-
James Sedgwick authored
Summary: should have been using fulfilTry anyways. and fulfilTry needs to take the Try by value so fix that too Test Plan: unit Reviewed By: hans@fb.com Subscribers: fugalh, folly-diffs@, jsedgwick FB internal diff: D1808923 Tasks: 6098987 Signature: t1:1808923:1422478981:d4b9727394339c996ebccb7841b94e0c7b2bffb4
-
Kyle Dent authored
Summary: Now CHAR_BIT will be found Test Plan: ran multifeed and folly Reviewed By: seanc@fb.com Subscribers: seanc, folly-diffs@ FB internal diff: D1810027 Signature: t1:1810027:1422480946:4568c5190e318ff097d33b3d0434593b72f8205e
-
Khalid El-Arini authored
Summary: ^ Test Plan: fbmake Reviewed By: woo@fb.com Subscribers: folly-diffs@ FB internal diff: D1810061 Signature: t1:1810061:1422481560:089c9186834f2bf87ac6d10b71d53784299b7992 Blame Revision: D1806632
-
Viswanath Sivakumar authored
Summary: We do a lot of copying of TransportInfo in proxygen, and in most cases the SSL structs don't change after connection establishment. We could cut down on memory usage by sharing these huge strings. This is especially true with SPDY where all streams belonging to a session could share these fields. Facebook: Test Plan: Unit tests, will canary Reviewed By: afrind@fb.com Subscribers: fugalh, bmatheny, ssl-diffs@, folly-diffs@, jsedgwick, woo FB internal diff: D1807557 Tasks: 5343753 Signature: t1:1807557:1422472932:53038345fca620632097586fb9e410bca8fe748d
-
Kyle Dent authored
Summary: Normally I would use the folly::to<> function, but it would cause a circular dependency, so I just added a static cast Test Plan: Ran on iOS and ran the folly tests Reviewed By: seanc@fb.com Subscribers: lucian, mpawlowski, marcelo, tudorb, aalexandre, seanc, folly-diffs@ FB internal diff: D1806632 Signature: t1:1806632:1422416646:b8104f18f90eb7457f2f358428f2bd800f8f1db5
-
James Sedgwick authored
Summary: as above, there were less of these than I expected, nice Test Plan: unit Reviewed By: hans@fb.com Subscribers: trunkagent, folly-diffs@, jsedgwick FB internal diff: D1789332 Tasks: 5949939 Signature: t1:1789332:1421878033:d7c2979a77b51a5257b8bcd910ad9296ca1aa7e0
-
Sean Cannella authored
Summary: std::to_string doesn't exist on Android so don't use it. Facebook: Did a sync to fbandroid and confirmed liger compiles with this fix. Test Plan: existing tests Reviewed By: ranjeeth@fb.com Subscribers: trunkagent, folly-diffs@, shikong, kmdent, fma, pgriess FB internal diff: D1808037 Signature: t1:1808037:1422410556:d78e0633a1554254b1a1f25bef49a4550a1817c6
-
James Sedgwick authored
Summary: See D1785572. Check out the new Future test and the commented portion of wait(Duration) for the fix The test only fails a few times out of a hundred before the fix, but hasn't failed yet after Test Plan: futures unit, wait for contbuild Reviewed By: hans@fb.com Subscribers: trunkagent, rushix, fbcode-common-diffs@, hero-diffs@, cold-storage-diffs@, adamsyta, zhuohuang, darshan, micha, folly-diffs@, lins, tingy, hannesr, jsedgwick FB internal diff: D1803526 Tasks: 5940008, 6059995 Signature: t1:1803526:1422309486:3613c59a708ecac312d241723828763feb2a57aa
-
Andrei Alexandrescu authored
Summary: Reciprocal of readFile Test Plan: fbmake runtests Reviewed By: tudorb@fb.com Subscribers: trunkagent, net-systems@, folly-diffs@ FB internal diff: D1807551 Signature: t1:1807551:1422410565:f5bda294deb788da9f3881c19bb20cfa1f588c09
-
Marcin Pawlowski authored
Summary: Fixing following the issues raised by nsuke on github following his diff (https://github.com/facebook/folly/pull/112) Test Plan: visual inspection, tested build on arch linux Reviewed By: davejwatson@fb.com Subscribers: folly-diffs@ FB internal diff: D1807378 Tasks: 5909189 Signature: t1:1807378:1422403093:ca024f396a27ecd9b304c57643f0107764a38ca1
-
