- 03 Oct, 2015 3 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Fix Build: `folly/Range.h` for build platforms missing SSE42 headers. We make the assumption that if the compiler defines the appropriate symbols indicating SSE42, that the corresponding intrinsics headers are available. We also remove `Range.cpp` from `Makefile.am`, which we forgot to do in the blamed diff. Reviewed By: @nbronson Differential Revision: D2504934
-
Alexey Spiridonov authored
Summary: I noticed myself trying to fake this kind of callback for a log-based test I was writing. It seems much nicer to add the callback to `CaptureFD` than roll ugly wrappers around it to do the same thing. Reviewed By: @yfeldblum Differential Revision: D2506106
-
Yedidya Feldblum authored
Summary: [Folly] Converge `folly::make_unique` to C++14's `std::make_unique`. The primary use-case of ther deleter variety of `folly::make_unique` is `DelayedDestruction`. Let the classes matching this use-case define their own factories. Reviewed By: @fugalh Differential Revision: D2495718
-
- 02 Oct, 2015 2 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Support SSE-enabled `Range` functions under Clang. Basically, we remove GCC-only -isms. In particular, we use only names from the `<emmintrins.h>` and `<smmintrins.h>` headers, instead of the GCC-specific SSE builtins that the original code uses. But in order to get this to work, we must split out the SSE-enabled functions into their own sources and compile them with the `-msse4.2` flag. There is a way to get around this in GCC by marking individual functions as SEE-enabled, but that technique is not supported in Clang. This is the new `RangeSse42` module. And in order to do that, we must split out the code that is called by both the original `Range` and the new SSE-enabled functions into yet a third module, `RangeCommon`. Ahhhhhh, dependencies. Note that we always compile the SSE-enabled functions, but we only run them on architectures supporting SSE. The original code tests the CPU's capabilities before running any SSE-enabled functions; this change retains that check. Reviewed By: @nbronson Differential Revision: D2428983
-
Nathan Bronson authored
Summary: This diff fixes the compiler warnings emitted by gcc-4.9's stricter -Wsigned-comparison check, as well as those revealed by -Wunused-variable. Reviewed By: @meyering, @yfeldblum Differential Revision: D2494514
-
- 01 Oct, 2015 2 commits
-
-
Alex Landau authored
Summary: Server can find out client's common name through Cpp2ConnContext::getPeerCommonName Reviewed By: @siyengar Differential Revision: D2469588
-
Alecs King authored
Summary: fix typo jenkins and oss build (e.g. travis) failing. Reviewed By: @pavlo-fb Differential Revision: D2499462
-
- 30 Sep, 2015 5 commits
-
-
Mohammad Husain authored
Reviewed By: @afrind Differential Revision: D2466921
-
Steve O'Brien authored
Summary: On a (broken) unit test there is a bad `CHECK` during destruction time. This triggers an ABRT, goes through the signal handler, and in the process ends up doing a use-after-free. Moved some globals inside the functions in which they are used (w/ little duplication, as they are used in one place, mostly). Reviewed By: @luciang, @meyering Differential Revision: D2494046
-
Dave Watson authored
Summary: This diff adds UpdateableSharedPtr and FastUpdateableSharedPtr classes to folly. They are efficiet RCU-style holders for a shared_ptr. See the comment at the top of UpdateableSharedPtr.h for a more detailed description and benchmark results. All the added files are copied from logdevice code with (almost) no changes (`logdevice/common/` on branch `origin/logdevice-latest`). We've been using them in logdevice for a few months. D1821723 introduced it. Reviewed By: @bmaurer Differential Revision: D1919702
-
Yedidya Feldblum authored
Summary: [Folly] Extract `SparseByteSet` into its own module. `SparseByteSet`, formerly `FastByteSet`, is actually a generic, fully standalone class. It does not need to be embedded in `Range.cpp`. Reviewed By: @bmaurer Differential Revision: D2460180
-
Ranjeeth Dasineni authored
Summary: From the client perspective, we set the list in order of preference once and call into openssl to do the selection. This adds a little more flexibility in that client optionally can customize the selection for each negotiation. added tests for the no-op case and the customized case. Feel free to suggest improvements. Reviewed By: @afrind Differential Revision: D2489142
-
- 29 Sep, 2015 3 commits
-
-
Subodh Iyengar authored
Summary: It's pretty common during parsing protocols with cursors that there will be empty iobufs along the way. This changes it so that we prune empty IOBufs in the cloned output before returning it to the user. Reviewed By: @djwatson Differential Revision: D2464488
-
Andre Pinto authored
Summary: AsyncPipeReader and AsyncPipeWriter are classes to asynchronously read and write to pipes. Reviewed By: @djwatson Differential Revision: D2479514
-
Yedidya Feldblum authored
Summary: [Thrift] CodeMod `apache::thrift::async::TEventBase` to `folly::EventBase` (remainder). A few straggler bits left out of D2349828. Reviewed By: @Gownta Differential Revision: D2489063
-
- 28 Sep, 2015 2 commits
-
-
Ben Maurer authored
Summary: sorry Reviewed By: @chiunlin Differential Revision: D2485925
-
Ben Maurer authored
Summary: These classes are likely to be used as static variables and can easily be constructed with constexpr. One that we really ought to fix is SpinLock. Sadly we have a bunch of implementations of it some of which need initialization. Reviewed By: @meyering Differential Revision: D2459355
-
- 25 Sep, 2015 1 commit
-
-
Steve O'Brien authored
Summary: * `registrationComplete` has a slightly different interface (uses enums now) * `void doEagerInit()` method initializes synchronously; `Future<Unit> doEagerInitVia(Executor*)` now available. Reviewed By: @luciang, @meyering Differential Revision: D2463464
-
- 24 Sep, 2015 3 commits
-
-
Justin Gibbs authored
Summary: Allow objects that only support in-place construction (no copy/move constructor) to be stored in AtomicHashMap and AtomicHashArray via the emplace() method. This uses variadic template parameters and perfect forwarding to allow the arguments for any valid constructor for the object to be used during insertion. Reviewed By: @nbronson Differential Revision: D2458152
-
Yedidya Feldblum authored
Summary: [Folly] A `qfind_first_byte_of` using a `bitset` in `folly/Range.cpp`. With additions to the existing benchmark program. Reviewed By: @nbronson Differential Revision: D2465890
-
James Sedgwick authored
Summary: This broke EventBase tests, which I managed not to run because they're marked as extended for some reason :( I don't have time to take another stab at this at the moment so I'm reverting for now Reviewed By: @djwatson Differential Revision: D2467789
-
- 23 Sep, 2015 3 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] `CpuIdTest.cpp` does not need `glog`. Reviewed By: @@philippv Differential Revision: D2470503
-
Yedidya Feldblum authored
Summary: [Folly] Search unpadded strings in `Range` benchmarks. `vstr` has padding to adjust alignment. `vstrp` is a view into `vstr` that skips the padding, so that searches start out unaligned. Before this diff, haystack is 8-byte aligned: `uintptr_t(haystack.begin()) % 8 == 0`. After this diff, it is not. Reviewed By: @@nbronson Differential Revision: D2468934
-
Yedidya Feldblum authored
Summary: [Folly] Use constexpr for folly::dynamic::TypeInfo static fields These things are compile-time values. So yeah. Reviewed By: @@JoelMarcey Differential Revision: D2466270
-
- 22 Sep, 2015 1 commit
-
-
Yedidya Feldblum authored
Summary: [Folly] Fully clean up before each round of benchmarks in `RangeFindBenchmark.cpp`. The `vstr` and `vstrp` globals need to be cleaned up before each round of benchmarks. Reviewed By: @@nbronson Differential Revision: D2467254
-
- 21 Sep, 2015 4 commits
-
-
Chip Turner authored
Summary: Looks like some platforms fail to build (open source, not internal) due to #if conditional. Reviewed By: @ldemailly Differential Revision: D2464555
-
Subodh Iyengar authored
Summary: There is a potential double free in destructor guard if someone calls a method which takes a DG in the destructor of the DG. This is potential in the case when someone is holding onto a DG while calling destroy() on the object. Reviewed By: @djwatson Differential Revision: D2463113
-
Chip Turner authored
Summary: strncpy is bad. strlcpy is somewhat less bad. We already had this function, but let's move it somewhere more reasonable. This would make sense to live in String.h, but then we have circular dependencies. Since String.h includes Demangle.h, though, you get strlcpy by including it, so this should be okay enough. Reviewed By: @lbrandy Differential Revision: D2097590
-
Marc Horowitz authored
Summary: to<bool>(42) should return true, not throw an exception. Reviewed By: @yfeldblum Differential Revision: D2459766
-
- 20 Sep, 2015 1 commit
-
-
Yedidya Feldblum authored
Summary: [Folly] Use string for benchmark names to support computed names. A benchmark program might call `folly::addBenchmark` with a computed benchmark name without wishing to maintain the lifetime of the string. Support this case. Reviewed By: @philippv Differential Revision: D2460621
-
- 19 Sep, 2015 1 commit
-
-
Philip Pronin authored
Summary: Semantics matches `Arena<>::totalSize()`. Reviewed By: @luciang, @ot Differential Revision: D2456388
-
- 18 Sep, 2015 2 commits
-
-
James Sedgwick authored
Summary: This can be useful on its own, will use in twagent Reviewed By: @fugalh Differential Revision: D2457778
-
Yedidya Feldblum authored
Summary: [Folly] Support MSVC, which does not have VLAs, in `folly/io/async/AsyncSocket.cpp`. We use VLAs in compilers that have them, and fixed-size arrays in compilers that do not. Reviewed By: @JoelMarcey Differential Revision: D2450689
-
- 17 Sep, 2015 2 commits
-
-
Steve O'Brien authored
Summary: Instead of the default lazy-loading behavior (still the default) some singletons might need to get initialized at startup time. This would be for singletons which take a long time for the instance's constructor to run, e.g. expensive initialization by reading some large dataset, talking to an outside service, and so on. Provides a way for singletons to opt-in to this, and get populated at the time `registrationComplete()` is called, instead of lazily. Some notes about the way I implemented here, mainly, why I did this as a "builder-pattern" kind of thing and not some other way. I could probably be convinced to do otherwise. :) * Changing the constructor: the constructor's already slightly fiddly with the two optional -- well, one optional construct function, and another optional-but-only-if-construct-provided, destruct function. Didn't want to pile more into the ctor. * New superclass called `EagerLoadedSingleton`; just didn't want to add more classes, esp. if it's just to add one more option. * Method like `void setEagerLoad()` that makes this eager-load; not sure where one would write the `shouldEagerLoad()` call, probably in some central initialization spot in `main()`, but all the maintenance would have to go there. I like that it's "attached" to the singleton being defined. (Though you can still do this.) Bonus #2; the rule that builds the cpp containing "main" doesn't need to import this dependency and the cpp doesn't have to include Singleton just to do this eager-load call, nor the header for the type itself. * Omitting this altogether and just saying `folly::Singleton<Foo>::get_weak()` to "ping" the singleton and bring into existence: see last point. Still might need to have the file containing this initialization decorum include/link against Foo, as well as have one place to maintain the list of things to load up-front. Reviewed By: @meyering Differential Revision: D2449081
-
Lucian Grijincu authored
Reviewed By: @yfeldblum Differential Revision: D2446000
-
- 16 Sep, 2015 5 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Compatibility: libevent: accessors for `struct event`. Some libevent fields in `struct event` moved between `v1.4` and `v2`. Add some accessors which are defined per-libevent-version. Reviewed By: @JoelMarcey Differential Revision: D2447537
-
Lucian Grijincu authored
Summary: there's no need for this static member, but it does get generated. We're only curious about it's type. Replace with Meyer's singleton to get the same effect. Reviewed By: @ddrcoder, @yfeldblum Differential Revision: D2446131
-
Lucian Grijincu authored
Reviewed By: @elsteveogrande Differential Revision: D2446056
-
Sara Golemon authored
Summary: __m128i is only available in SSE 2 and later. We technically only use it in folly/GroupVarint.h for SSE 3+, but that's due to various other intrinsics and we could potentially lower the requirement in certain contexts, so do the right thing in the generated table. Revisit the uses in folly/GroupVarint.h later. Reviewed By: @yfeldblum Differential Revision: D2445798
-
James Sedgwick authored
Summary: For the perfs - big improvement on one fd per timeout. Reviewed By: @djwatson, @fugalh Differential Revision: D2379210
-