- 13 Jul, 2015 2 commits
-
-
Kjell Schubert authored
Summary: This is only a simple #include file split, no functional change was made. SmallLocks.h provides 2 classes: MicroSpinLock and PicoSpinLock, with the latter not being available on 32bit platforms. There are several classes in folly that included SmallLocks.h but only needed MicroSpinLock, these also refused to compile on 32bit, e.g. folly/futures/Future.h. Now these compile fine. Reviewed By: @yfeldblum Differential Revision: D2234263
-
Yedidya Feldblum authored
Summary: [Folly] An has_member_type macro. Reviewed By: @juchem Differential Revision: D2229775
-
- 09 Jul, 2015 6 commits
-
-
Joe Richey authored
Summary: After discussion with Tom about frozen files, we noticed that the use case of filtering out somthing that looks like false (0, nullptr, folly::none) is unnecessarily tedious. So folly::gen::filter now filters by the value of the item by default. Reviewed By: @ddrcoder Differential Revision: D2220582
-
Subodh Iyengar authored
Summary: Add mocks for the new isBufferMovable methods. Reviewed By: @yfeldblum Differential Revision: D2222642
-
Yedidya Feldblum authored
Summary: [Folly] ThreadedExecutor. It's an Executor that runs functions each in its own thread. Kind of simple. Suitable for a few types of strange cases. Reviewed By: @hannesr Differential Revision: D2226211
-
Tudor Bosman authored
Summary: Add a way to tell whether an IOBuf (either indvidually or the whole chain) refers to memory that's outside of IOBuf's control (via WRAP_BUFFER). That is, can you assume that clone() will extend the lifetime of the memory? Is it safe to use clone() instead of copying the data (and avoid a copy)? Reviewed By: @simpkins Differential Revision: D2191883
-
Steve O'Brien authored
Summary: Early in the startup process there may not be a default signal handler installed, and stack traces are not available; also during the startup process is when init-order fiascos occur. Dump a stacktrace and fatal when an unregistered singleton is used. Also fatals -- with glog `LOG(FATAL)`, which triggers an ABRT signal -- on other illegal and unrecoverable usage like double-registration or circular dependency. Reviewed By: @andriigrynenko Differential Revision: D2200408
-
Mark McDuff authored
Summary: Ran into a bug in D2158570 where we dtor'ing these data structures before the event bases destructed, so the assert on line 47 (of the old code) failed. Reviewed By: @andriigrynenko Differential Revision: D2198318
-
- 07 Jul, 2015 6 commits
-
-
Sara Golemon authored
-
Alexey Spiridonov authored
Summary: This is the first of a series of diffs to get folly, fbthrift, and bistro to run on Ubuntu 12.04 LTS, which is what powers Travis CI. It's important for folly to be easily usable with Travis CI, since everything C++ depends on it, and we really want all FB open-source projects to be monitored via continuous integration to avoid breaking their OSS builds. Thanks to @int's work on `mcrouter`, this was considerably easier than it would have been otherwise. This puts us a hop and a skip away from actually running folly's `make && make check && make install` on Travis CI. Do y'all think this is useful? Reviewed By: @yfeldblum Differential Revision: D2217441
-
Sara Golemon authored
-
James Sedgwick authored
Summary: Another stab at D2111063 now that we have the go ahead to actually open up the wangle github repo Reviewed By: @djwatson, @mdordal Differential Revision: D2178291
-
Philip Pronin authored
Summary: Drop those `const_cast<>` hacks. Reviewed By: @ot Differential Revision: D2217629
-
Hans Fugal authored
Summary: This is a documentation dump, with updates from the past couple weeks. Most notably, the new information about `Future<Unit>` replacing `Future<void>`. Reviewed By: @hannesr Differential Revision: D2211135
-
- 02 Jul, 2015 7 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Lift thrift/lib/cpp/test/TNotificationQueueTest. `NotificationQueue` is already moved into folly; move its accompanying test suite as well. Reviewed By: @simpkins Differential Revision: D2207104
-
Sara Golemon authored
Summary: Got this ifdef wrong in my last change here. Reviewed By: @paulbiss Differential Revision: D2213708
-
Hans Fugal authored
Summary: If you try to make a future or promise of `void`, you will get this nice error message telling you to use `Unit` instead. Reviewed By: @djwatson Differential Revision: D2211239
-
Michael Lee authored
Summary: The Homebrew setup fails to compile on OSX. Reviewed By: @paulbiss Differential Revision: D2212084
-
Yedidya Feldblum authored
Summary: [Folly] folly::Unit::Drop. Antisymmetric to folly::Unit::Lift. Reviewed By: @fugalh Differential Revision: D2211725
-
Hans Fugal authored
Summary: Fix so `Timekeeper::at(now() - something)` works. Also introduce a test which explicitly tests when <= now codepath, which wasn't broken per se here, but which test also tickled this bug. Reviewed By: @jsedgwick Differential Revision: D2209166
-
Hans Fugal authored
Reviewed By: @yfeldblum Differential Revision: D2209095
-
- 01 Jul, 2015 12 commits
-
-
Hans Fugal authored
Summary: This is three codemods: * `(folly::(Future|Promise|Try))<void>` -> `\1<folly::Unit>` * `(Future|Promise|Try)<void>` -> `\1<Unit>` * add `using folly::Unit` statements where needed Then * undo false positives in javascript files and fibers::Promise cf D2201259, which this will land with Reviewed By: @djwatson Differential Revision: D2201801
-
Hans Fugal authored
Summary: Mostly this is `s/(Promise|Future|Try)<void>/\1<Unit>/` Reviewed By: @djwatson Differential Revision: D2201272
-
Hans Fugal authored
Summary: Nuke Future<void> in favor of Future<Unit>, for the `folly/futures` subdirectory. Reviewed By: @djwatson Differential Revision: D2201259
-
Sara Golemon authored
Summary: The current #if directive is a laundry list of "strerror_r defaults to XSI style on these platforms", and we keep missing some, so let's just do a proper test and simplify the code directives. Closes #232 Reviewed By: @paulbiss Differential Revision: D2208843
-
Hans Fugal authored
Reviewed By: @yfeldblum Differential Revision: D2209197
-
Vignesh Gowda authored
Summary: Implemented a BitVector Encoder and BitVector Reader with the same interface as EliasFanoCoding.h Reviewed By: @ot, @philippv Differential Revision: D2198935
-
Andrey Goder authored
Summary: Apparently this test sometimes fails. @Gownta suggests it's because we're storing temproaries in StringPiece. Change it to store in a std::string, which should hopefully fix it. Reviewed By: @Gownta Differential Revision: D2208643
-
Hans Fugal authored
Summary: More people are starting to use Rx. Yay! But they're trying to use `wangle/rx`. So make sure there's no doubt about its deprecated status. Reviewed By: @yfeldblum Differential Revision: D2196273
-
Sara Golemon authored
Summary: flock() expects sys/file.h which on many platforms is getting included as a side-effect, but on at least one this isn't the case. Add the explicit include to fix builds on those platforms. Closes #232 Facebook Unrelated runtime failures. Reviewed By: @JoelMarcey Differential Revision: D2196306
-
Marc Horowitz authored
Summary: When doing android development, we need to compile with FOLLY_HAVE_BITS_FUNCTEXCEPT_H set for some flavors, and FOLLY_HAVE_BITS_FUNCTEXCEPT_H unset for others (primarily for tests run in the local (xcode) development platform). This diff adds some more conditionals so it all works. In this repro, these files are never used, so this is more or less a noop, but this is the upstream so I'm making these changes here. Reviewed By: @Gownta Differential Revision: D2202107
-
Woo Xie authored
Summary: before the first setReadCallback(), the readCallback_ is nullptr. Thanks @siyengar for pointing out this! Reviewed By: @siyengar Differential Revision: D2203489
-
Woo Xie authored
Summary: refactor D2201181 Reviewed By: @afrind Differential Revision: D2202245
-
- 29 Jun, 2015 4 commits
-
-
Sara Golemon authored
-
Kjell Schubert authored
Summary: a subset of folly now compiles with Windows mingw64 toolchain Reviewed By: @djwatson Differential Revision: D2171872
-
Philip Pronin authored
Summary: `folly/Format.h` pulls in `folly/small_vector.h` and `folly/FBVector.h`, which (according to @oleksandr's analysis) are the most expensive includes for multiple fbcode projects. Reviewed By: @ot Differential Revision: D2198904
-
Tom Jackson authored
Summary: Resplit violated the contract of `apply()`; it returned `false` even though the input sequence was fully consumed. Reviewed By: @philippv Differential Revision: D2195889
-
- 26 Jun, 2015 3 commits
-
-
Mike Arpaia authored
Summary: double-conversion was recently added to homebrew, making it the last folly dependency to do so. this diff modifies the existing OS X bootstrap tool to account for that. I also added an rm for the gtest wget, so there wasn't a leftover zip file in your repo. alternatively, we could remove that and add it to the gitignore. Reviewed By: @fugalh Differential Revision: D2196000 Pulled By: @sgolemon
-
Alex Landau authored
Summary: If x->add() executes its lambda on a different thread and doesn't pass the context on its own, the callback wouldn't have the correct context set. Reviewed By: @djwatson Differential Revision: D2189318
-
Dave Watson authored
Summary: make it std::atomic Reviewed By: @tudor Differential Revision: D2191861
-