1. 24 Feb, 2020 4 commits
    • Shrikrishna Khare's avatar
      fbcode_builder: getdeps: add Python3.7.6 manifest · 4a44929c
      Shrikrishna Khare authored
      Summary:
      As titled.
      
      FBOSS depends on Python3.7.6, subsequent diff in the stack adds Python3.7.6
      depedency for FBOSS.
      
      Differential Revision: D20064316
      
      fbshipit-source-id: 27b328dc25e326f3927ea6cb003fb7bb45732d61
      4a44929c
    • Maged Michael's avatar
      Add indicators of process phases · 7414a33e
      Maged Michael authored
      Summary:
      Add function `get_process_phase` that returns indicators of process phases:
      - `ProcessPhase::Init`: Not all global variables may have been initialized.
      - `ProcessPhase::Regular`: All globals have been initialized and have not been destroyed.
      - `ProcessPhase::Exit`: Some globals may have been destroyed.
      
      Add function `set_process_phases` and calls to it from `folly::init` and `common/init/Init.cpp` wherever `SingletonVault::singleton()->registrationComplete` is called.
      
      Will add calls to `set_process_phases` in separate diffs to other places that call `registrationComplete ` directly.
      
      See Section 6.9.3 Start and termination [basic.start] of the C++ Standard Working Draft [N4849](https://github.com/cplusplus/draft/releases/download/n4849/n4849.pdf).
      
      In general this addition is useful for simplifying cases of dependence on the existence of certain globals during main, where it is safe to ignore such globals at shutdown.
      For example, the destructor of `hazptr_obj_cohort` normally needs to access the default `hazptr_domain`, but it is safe to skip that access at shutdown.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19567170
      
      fbshipit-source-id: a44cbd3301aa9dc77a1e992922403635a3ff6552
      7414a33e
    • Lukas Piatkowski's avatar
      mononoke: make mononoke_types OSS-buildable · 75b2e2f4
      Lukas Piatkowski authored
      Summary: (Note: this ignores all push blocking failures!)
      
      Reviewed By: farnz
      
      Differential Revision: D19948740
      
      fbshipit-source-id: 9d0cfc4ccbcb3c08bb969f23229ed3096470fa86
      75b2e2f4
    • Giuseppe Ottaviano's avatar
      Move F14 fallbacks to separate headers · 594f484b
      Giuseppe Ottaviano authored
      Summary:
      Having the fallbacks in the public header files makes searching for classes/methods cumbersome, and some people have mistakenly assumed that F14 classes inherit from `unordered_*` because they landed on the wrong line.
      
      In addition, when the fallback implementation is used, any compilation errors will come from the `*Fallback.h` files, making it clear that the main implementation is not being selected.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19926873
      
      fbshipit-source-id: 492b0c252f33c0cbbf3c22dae38fa0bd63825f72
      594f484b
  2. 23 Feb, 2020 2 commits
    • Giuseppe Ottaviano's avatar
      Use sized deallocation in small_vector when possible · 0266f281
      Giuseppe Ottaviano authored
      Summary: Capacity is known in almost all the modes (except when it's inferred from `malloc_usable_size`, which is probably something we should not do in the first place), so we can easily plug in sized deallocation.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19976657
      
      fbshipit-source-id: cb03f7107195af614514645c88d12ac4999dea53
      0266f281
    • Misha Shneerson's avatar
      rootid should be unique · d0f956f5
      Misha Shneerson authored
      Summary:
      rootid is the thing we use to correlate running Thrift requests with a folly::RequestContext. The problem is that today rootid is unique only for active requests but not unique throughout the lifetime of the process - as a consequence we see some subtle bugs like mistakenly attributing threads to already finished requests. The root cause of rootid collisions is that default implementation of rootid is just an address of folly::RequestContext - so once request finishes the address is reused.
      
      The solution suggested here is to assign rootids explicitly when folly::RequestContext is set for the request. To construct such rootid we pack two counters:
      * 12 MSB are dedicated to an ID of Cpp2Worker (should be more than enough)
      * 51 LSB are dedicated to a running counter within Cpp2Worker.
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D20036950
      
      fbshipit-source-id: 76687db12a32f33c82ce86accb4cdaab3e981458
      d0f956f5
  3. 22 Feb, 2020 3 commits
    • Luca Niccolini's avatar
      Async UDP Socket: socket options · 54c6d875
      Luca Niccolini authored
      Summary:
      generic API for setting socket options on a UDP socket
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: yangchi
      
      Differential Revision: D19763927
      
      fbshipit-source-id: d1a7720b04c24592e98c6e30c93c26e650ccd0b0
      54c6d875
    • Luca Niccolini's avatar
      delete folly::AsyncSocket::OptionMap/OptionKey/emptyOptionMap aliases · 549476f0
      Luca Niccolini authored
      Summary: delete the folly::AsyncSocket::OptionMap/OptionKey/emptyOptionMap aliases
      
      Reviewed By: yangchi
      
      Differential Revision: D19963346
      
      fbshipit-source-id: 6beae0961a82d12efd4d784ec390031d9445cd2b
      549476f0
    • Luca Niccolini's avatar
      move AsyncSocket::OptionMap into SocketOptionMap (base) · 44a7106b
      Luca Niccolini authored
      Summary: base diff to move AsyncSocket::OptionMap into SocketOptionMap. folly only changes and an alias for previous usages of AsyncSocket::OptionMap
      
      Reviewed By: yangchi
      
      Differential Revision: D19961899
      
      fbshipit-source-id: fab060cc73409c77ea07ced663fbd0ee15a35be7
      44a7106b
  4. 21 Feb, 2020 2 commits
  5. 20 Feb, 2020 2 commits
    • Dan Melnic's avatar
      Use sdallocx for IOBuf::releaseStorage · 7ec006ed
      Dan Melnic authored
      Summary: Use sdallocx for IOBuf::releaseStorage
      
      Reviewed By: marksantaniello
      
      Differential Revision: D19925485
      
      fbshipit-source-id: 142276fb64e570e10bfd0b6e22d8c83b204d1c2b
      7ec006ed
    • Dan Melnic's avatar
      Add FOLLY_CLANG_DISABLE_WARNING for Unistd.h · 12c92eaa
      Dan Melnic authored
      Summary:
      Add FOLLY_CLANG_DISABLE_WARNING for Unistd.h
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19652177
      
      fbshipit-source-id: 1fcc3bb65c3b0d73870e599f9fc0463c6836cf9b
      12c92eaa
  6. 19 Feb, 2020 5 commits
    • Chad Austin's avatar
      enable lz4 in the getdeps build of rocksdb · 6156dc3d
      Chad Austin authored
      Summary:
      The Buck build of RocksDB supports LZ4, so if an Eden instance's
      object cache ends up compressed with LZ4 compression, the opensource
      getdeps build cannot open it. Enable LZ4 in the open source getdeps
      build of rocksdb.
      
      Reviewed By: pkaush
      
      Differential Revision: D19961878
      
      fbshipit-source-id: 9a4f37e12bd2b40a0c5dcf2dd1684876886fae26
      6156dc3d
    • TJ Yin's avatar
      Replace folly::Optional::clear() by reset() · 95c7d18c
      TJ Yin authored
      Reviewed By: yfeldblum
      
      Differential Revision: D19953637
      
      fbshipit-source-id: c2135fc24084b7bba0c9d6fc978c8b6c8f9943d4
      95c7d18c
    • Ter Chrng Ng's avatar
      Revert D19848850: Add missing libraries back to ovrsource · 19f6ae0d
      Ter Chrng Ng authored
      Differential Revision:
      D19848850
      
      Original commit changeset: 21e61529d8b9
      
      fbshipit-source-id: c490eb0024a4cda830389a359ee2631615345f2d
      19f6ae0d
    • Nick Cooper's avatar
      Improve blockingWait test · f29e87cf
      Nick Cooper authored
      Summary: Previously if the loop simply failed to execute the test could pass, add some minor changes to ensure control flow is as required.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D19960864
      
      fbshipit-source-id: 5a437d9e7d3b7c249cbf999fe7ea5eecfe668658
      f29e87cf
    • Andrew Gallagher's avatar
      Add some missing includes · 0d305cb1
      Andrew Gallagher authored
      Summary: Missing includes which break modular builds.
      
      Reviewed By: igorsugak, luciang
      
      Differential Revision: D19738860
      
      fbshipit-source-id: 97a0329f3e558309ca87f4dd7be8dd96e9ba09a8
      0d305cb1
  7. 18 Feb, 2020 3 commits
    • Nick Cooper's avatar
      folly::coro::blockingWait should gracefully handle cases with thrown exceptions · 19910c37
      Nick Cooper authored
      Summary:
      If the waited upon object throws an exception when blockingWait is called within a fiber context this can cause a SIGABT as it is not permissible to yield (due to the inner baton) in an exception context.
      
      To fix this, instead capture the exception and permit destruction to occur outside of exception handling.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D19951124
      
      fbshipit-source-id: cf1bf9a62557147863390132f551d08e20c02c2d
      19910c37
    • Ter Chrng Ng's avatar
      Add missing libraries back to ovrsource · c9e346af
      Ter Chrng Ng authored
      Summary: It was originally disabled to let test pass in ovrsource, they are now passing, enabling them back
      
      Reviewed By: pranjalssh
      
      Differential Revision: D19848850
      
      fbshipit-source-id: 21e61529d8b9f519b4c8cbf4787c8e3f28b99bb1
      c9e346af
    • Dan Melnic's avatar
      Add folly::sizedFree · 8bc1252f
      Dan Melnic authored
      Summary:
      Add folly::sizedFree
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: ot
      
      Differential Revision: D19944311
      
      fbshipit-source-id: b5b1a648a180662fe838237c3c3b153e42fe0617
      8bc1252f
  8. 16 Feb, 2020 1 commit
    • Orvid King's avatar
      Support u8 as char8_t in StringPiece literals · cae89fc3
      Orvid King authored
      Summary: In C++20, u8 prefixed strings are typed as `char8_t` not `char`, so we need to support that in `StringPiece`.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19822967
      
      fbshipit-source-id: c3441ba718b40f0781766d4a80c3432b4514a35c
      cae89fc3
  9. 15 Feb, 2020 1 commit
  10. 14 Feb, 2020 6 commits
    • Shai Szulanski's avatar
      Add coro::toSemiFuture · 64fc8458
      Shai Szulanski authored
      Summary:
      Currently the best way to get an eager SemiFuture from an AsyncGenerator is
        folly::coro::co_invoke(
            [&]()
                -> folly::coro::Task<folly::coro::AsyncGenerator<T&&>::NextResult> {
              co_return co_await gen.next();
            })
            .scheduleOn(&ex)
            .start();
      which is very verbose. This diff adds helpers to make this a simple function call.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D19835473
      
      fbshipit-source-id: f6e7e72cad0e0596df375d2662c87d4412536c03
      64fc8458
    • Zhengxu Chen's avatar
      Make thrift metadata available across fbcode oss builds. · 0b5752df
      Zhengxu Chen authored
      Summary: There are downstream oss builds showing build failure caused by introduction of metadata. We want to make them proceed to build so we won't get errors in CI.
      
      Reviewed By: iahs
      
      Differential Revision: D19900007
      
      fbshipit-source-id: 4201448f7980b53e407fd2bc1c74ed4ffa8e18c1
      0b5752df
    • Nathan Bronson's avatar
      fix missing eraseInto overload for key with permissive constructor · 6aa06e7f
      Nathan Bronson authored
      Summary:
      If a key type has a templated constructor that can implicitly
      accept const_iterator, then a call to erase or eraseInto with a non-const
      iterator results in an ambiguous overload. This diff adds an extra
      overload of eraseInto to avoid the ambiguity, as well as adding unit
      tests that cover the rare corner case.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19809069
      
      fbshipit-source-id: 499849da2d6ad64070b13eb0a9ed86a3d49ad9b0
      6aa06e7f
    • Nathan Bronson's avatar
      add eraseInto to F14 maps · 10abef97
      Nathan Bronson authored
      Summary:
      It's useful to be able to move the key and value
      out of a hash table as that entry is being erased. Since
      std::unordered_map's extract API isn't implementable for hash tables
      that perform bulk allocation, we expose similar functionality via
      F14{Fast,Value,Vector,Node}Map::eraseInto.  eraseInto gives a key_type&&
      and mapped_type&& to the specified callback, allowing it to move them
      elsewhere before the underlying value_type is destroyed.
      
      The keen observer will note that there is no way to move the key out
      of a std::pair<key_type const,mapped_type> without relying on undefined
      behavior. We already rely on this form of UB to avoid copying keys during
      rehash, and perform it only when we have total control over the lifecycle
      of the object and the memory backing the value_type.
      
      eraseInto was previously implemented for F14 sets.
      
      Reviewed By: shixiao
      
      Differential Revision: D19777644
      
      fbshipit-source-id: 9904224af2c6e51abeadae62cc5e66f7bf4b1ae7
      10abef97
    • Orvid King's avatar
      Another fix for newer Windows SDK · 7d2114a5
      Orvid King authored
      Summary: This issue was only showing up in a single test, but include orders meant that stdio.h could end up being included in a way that caused it to not properly define the normal names it's supposed to, as they were getting disabled due to the `_CRT_INTERNAL_NON_STDC_NAMES` changes being made.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19866950
      
      fbshipit-source-id: 9d6391f5c0e5a2ef44f0f8ba6dad064cfecf0a82
      7d2114a5
    • Orvid King's avatar
      Support newer versions of boost in the portable PThread implementation · 52dcff2e
      Orvid King authored
      Summary: Newer versions of boost thread re-wrote how this works, so use the new way.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19824658
      
      fbshipit-source-id: a3d66fd6ef781ac83c92f6313cf47a7920cfebda
      52dcff2e
  11. 13 Feb, 2020 5 commits
  12. 12 Feb, 2020 4 commits
    • Joseph Wu's avatar
      Fix missing re2 dep in opensource · f3957689
      Joseph Wu authored
      Summary: platform_mapping library needs RE2 lib.
      
      Reviewed By: shri-khare
      
      Differential Revision: D19838529
      
      fbshipit-source-id: 71a2c06437ce05a42396a2867ddadb029e36926e
      f3957689
    • Dan Melnic's avatar
      Remove trivial-copyability req from LockFreeRingBuffer · bcaf9cdf
      Dan Melnic authored
      Summary: [Folly] Remove trivial-copyability requirement from `LockFreeRingBuffer` since we can rely on the compiler to optimize copy operations over types which are trivially-copyable without our code having to specify `memcpy`.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D19844612
      
      fbshipit-source-id: 4770e46ac8c63fa68b68598fb5012cb58896f550
      bcaf9cdf
    • Yedidya Feldblum's avatar
      Use SingletonThreadLocal for the current fiber manager · 7ce27feb
      Yedidya Feldblum authored
      Summary: [Folly] Use SingletonThreadLocal for the current fiber manager, which does not depend on whether `__thread` or `thread_local` is available.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D19229511
      
      fbshipit-source-id: a92016aca89205c2842dc4f71054b1b6306b14b9
      7ce27feb
    • Yedidya Feldblum's avatar
      Prefer invoke_result_t in DistributedMutex · 5bdf434f
      Yedidya Feldblum authored
      Summary: [Folly] Prefer `invoke_result_t` in `DistributedMutex` over the underlying `decltype` and `declval` implementation.
      
      Reviewed By: aary
      
      Differential Revision: D19321643
      
      fbshipit-source-id: 323a0fce49447d2f009ad3bc61e285de3f311ff1
      5bdf434f
  13. 11 Feb, 2020 2 commits
    • Yedidya Feldblum's avatar
      Use invocability helper variables · 59e20c74
      Yedidya Feldblum authored
      Summary: [Folly] Use invocability helper variables in preference to types.
      
      Reviewed By: aary
      
      Differential Revision: D18748026
      
      fbshipit-source-id: e7a76c1238360c55dd6d41c53f763e9df4069acb
      59e20c74
    • Ming Yi Teo's avatar
      Enable -Wshorten-64-to-32 in wangle · 0ea41166
      Ming Yi Teo authored
      Summary:
      1. Add `"-Wshorten-64-to-32"` to `_extra_clang_flags`
      2. Fix warnings generated from `buck build --keep-going wangle/...`
      
      Reviewed By: chadaustin
      
      Differential Revision: D19647345
      
      fbshipit-source-id: 417840fe82ed3d5c9c2d989a0acf67e12758c1f9
      0ea41166