Summary: MSVC was failing to resolve `AllocTraits` within this specific context.

Reviewed By: yfeldblum

Differential Revision: D8179354

fbshipit-source-id: 236094f704bc89ec81236e9a67054e2081590cf6

Summary:
There are quite a few things in Folly that are not compatible with C++11.

Closes: https://github.com/facebook/folly/issues/851

Reviewed By: yfeldblum

Differential Revision: D8179239

fbshipit-source-id: b4ce23b98311a7c5ac15c3b7c9787f568535c950

Summary:
Step 2 in adding full set of r-value-qualified unambiguous continuation methods to folly::Future for consistency with folly::SemiFuture.
 * Adds r-value qualified thenTry which directly forwards to then, but has compile-time restrictions on the continuations that can be passed to avoid ambiguity.

Reviewed By: yfeldblum

Differential Revision: D7944820

fbshipit-source-id: 55ee09455703bb73168694175e884b053caff426

Summary:
[Folly] Invoke SemiFutures defer-continuations with the same cvref as passed.
for example, if passed as const&&, invoke as const&&, and if passed as volatile&, invoke as volatile&.
This brings a little more consistency to the library.

Reviewed By: yfeldblum

Differential Revision: D8125144

fbshipit-source-id: f2cda643aaae40e0293d5d79608541771642ce06

Summary:
Step 1 in adding full set of r-value-qualified unambiguous continuation methods to folly::Future for consistency with folly::SemiFuture.

 * Add r-value qualified Future<T>::thenValue.
 * Make callableResult structs consistently named so they work for Future and SemiFuture.
 * Correct call behaviour for consistency with invokeCallbackReturningFutureAsRvalue test.

Reviewed By: yfeldblum

Differential Revision: D7944603

fbshipit-source-id: 081383a91749310472a8106289671cffa6139691

Summary: This gets Folly working with the zstd package provided by vcpkg.

Reviewed By: yfeldblum

Differential Revision: D8176531

fbshipit-source-id: 05fdd5915a677a862791cfcc5587f7a396fb4c51

Summary: We are changing `folly::collectAll` to return `SemiFuture` rather than `Future` and this is needed as an interim step. After all calls to `collectAll` are changed to `collectAllSemiFuture`, we'll be renaming it back to `collectAll`.

Reviewed By: yfeldblum

Differential Revision: D8157548

fbshipit-source-id: 27b768ac7ff0d6572bde57f01601045a1fd5d5e5

Summary:
Discussion in D7923362 included validity & behavior of `wait()` vs. fulfillment and `wait()` vs. `then()`.

18 test-cases:

8 cases with `.wait(...)` and fulfillment:

- Future vs. SemiFuture
- wait() vs. wait(dur)
- fulfilled before wait(...) call vs. during wait(...) call

10 cases with `.wait(...)` and `.then(...)`:

- 4 wait() cases: {Future vs. SemiFuture} that gets fulfilled {prior to, during} the wait() call.
- 6 wait(dur) cases: {Future vs. SemiFuture} that gets fulfilled {prior to, during, after} the wait(dur) call.

Reviewed By: yfeldblum

Differential Revision: D8048426

fbshipit-source-id: c79cc337706f08f8fb9c6057a114723320a90820

Summary:
This diff adds recurring tests of F14's ability to use stateful
functors with no default constructor.

This is a test-only diff.

Reviewed By: yfeldblum

Differential Revision: D8170593

fbshipit-source-id: 6ce8c7751ce32ed69b60c6884b5deb7e6378a5d1

Summary:
We are using facebook::proxygen to build Http-utility on top of it. One of the main server-connector class `Proxygen::HTTPConnector` requires `folly::HHWheelTimer` to perform timer stuff inside it.

Now, `folly::HHWheelTimer` is a very large object and we would like to avoid `folly::HHWheelTimer` creation for every new `Proxygen::HTTPConnector` therefore, we are thinking to reuse `EventBase::timer()` that creates one timer per EventBase (application creates it 1 per io thread).

But `EventBase::timer()` creates timer with default-time and caller can not modify it. Because of that other dependent component can't use it and proxygen gives below error:
```
F0522 23:50:19.629158  7775 WheelTimerInstance.cpp:71] Check failed: defaultTimeoutMS_.count() >= 0 (-1 vs. 0)
*** Check failure stack trace: ***
    @     0x7f5e6ce26e6d  (unknown)
    @     0x7f5e6ce28ced  (unknown)
    @     0x7f5e6ce26a5c  (unknown)
    @     0x7f5e6ce2963e  (unknown)
    @     0x7f5e6de8c1ad  proxygen::WheelTimerInstance::scheduleTimeout()
    @     0x7f5e6de7c059  proxygen::HTTPTransaction::HTTPTransaction()
    @     0x7f5e6deacff1  ...
    @     0x7f5e6deaa23a  proxygen::HTTPSession::createTransaction()
    @           0x4f7f93  proxygen::HTTPUpstreamSession::newTransaction()
    @           0x4ad9a4  Sherpa::HttpSession::sendRequest()
    @           0x4aee08  Sherpa::HttpSession::connectSuccess()
    @           0x4f5c69  proxygen::HTTPConnector::connectSuccess()
    @     0x7f5e6d47e414  folly::AsyncSocket::handleConnect()
    @     0x7f5e6d48769d  folly::AsyncSocket::handleWrite()
    @     0x7f5e6d47a05c  folly::AsyncSocket::ioReady()
```

- add `setDefaultTimeout()` method into timer so, application can configure it.

- No functional change but it facilitates application to configure defaultTimeout after `folly::HHWheelTimer` is created.
Closes https://github.com/facebook/folly/pull/850

Reviewed By: djwatson

Differential Revision: D8123617

Pulled By: yfeldblum

fbshipit-source-id: 4dd9b19506bea380239200b6207ac05a40a0686c

Summary:
The move constructor and move assignment operator for
allocator-aware containers is supposed to allocate new memory and
move values across when the underlying allocators are not equal.
Previously F14 just checked that this wasn't the case.  This diff
implements this feature.  This allows F14 tables to be moved into and
out of allocator-managed memory segments, such as arenas or shared
memory extents.

Reviewed By: yfeldblum

Differential Revision: D8022286

fbshipit-source-id: ff0b220450bb76822cc68cebad079a7ef43e2429

Summary:
The value passed to the eraseInto beforeDestroy callback will
be immediately destroyed, so it makes more sense for it to be an rvalue
reference than an lvalue reference.

Reviewed By: yfeldblum, shixiao

Differential Revision: D7986157

fbshipit-source-id: 9dcc5371635a860033fe901aaad3a73230d652f6

Summary:
F14 maps and sets support fancy pointers and stateful allocators.
This diff includes tests that verify this functionality and show how
boost::interprocess's location-relative pointers can be used to construct
address-independent F14 maps and sets in shared memory segments.

This is a test-only diff.

Reviewed By: shixiao

Differential Revision: D7969966

fbshipit-source-id: 77b3e2705bc7462518246a96b73e0f3f9c542c6a

Summary:
[Folly] Cut `Try` ctor taking `std::exception_ptr`.

It is legacy, from a time before `exception_wrapper`.

Reviewed By: marshallcline

Differential Revision: D8110107

fbshipit-source-id: 2d8f4d56fdf1043012d72813a8686a8d02392a0b

Summary:
[Folly] Cut `Promise::setException` overload taking `std::exception_ptr`.

It is from a time before `exception_wrapper`.

Reviewed By: marshallcline

Differential Revision: D8110117

fbshipit-source-id: f3a3f150267efc8c22a83dc90c7f52a728ef3de7

Summary:
[Folly] Cut `SharedPromise::setException` overload taking `std::exception_ptr`.

It is from a time before `exception_wrapper`.

Reviewed By: marshallcline

Differential Revision: D8132039

fbshipit-source-id: eb82f6b766fd5cf82443ef447bbc751e7319f0ab

Summary:
Currently, scheduling only allows specifying an interval, not the next run time. This makes it impossible to schedule for a given startDelay modulo the interval. This refactors things internally to use a customizable NextRunTimeFunc, and exposes a way to run at a consistent startDelay or pass in a NextRunTimeFunc.

A use case: if we have n FunctionSchedulers schedule with different startDelays but the same interval, and they sync up (e.g. they all get blocked on some IO call, which eventually gets fixed), then they won't unsync or will unsync slowly.

Reviewed By: yfeldblum

Differential Revision: D7651111

fbshipit-source-id: 3c7a49dbfaa073b913107474f039a53a0a03cfa0

Summary: This fixes a compile error on 32-bit platforms.

Reviewed By: Orvid

Differential Revision: D8147916

fbshipit-source-id: 86b66b684bed5ffb262630a361cf239948b8bb97

Reviewed By: yfeldblum

Differential Revision: D8134836

fbshipit-source-id: 0b736bd61aa024574756634358ddc0e45c31944b

Summary: Add contracts to Promise

Reviewed By: LeeHowes

Differential Revision: D7923804

fbshipit-source-id: f7f29646d523ee69f00ac8576e2edf7e003f25e3

Summary:
Detach evb from asyncudpsocket to be able to
switch the socket between threads

Reviewed By: yfeldblum

Differential Revision: D8131599

fbshipit-source-id: 5d2a6f9b43b72076da1f6c09ce37b3c0bcd43db2

Summary: Change name to reserve the word await for coroutines.

Reviewed By: yfeldblum

Differential Revision: D8076750

fbshipit-source-id: 38771dc22c39e194888ac272299ec1ae83df6389

Summary:
`ConcurrentHashMap` provides `cbegin` and `cend`, but they are not suitable for range-based loops.
This diff adds const versions of `begin` and `end` that are required for range-based loops.

Reviewed By: yfeldblum

Differential Revision: D8131142

fbshipit-source-id: b3af164d403c86ddfe4d27aaca293fbc4e2bb9d2

Summary: To expedite, I'm splitting the class-level summary-docs from the method-level docs. This is just the former.

Reviewed By: LeeHowes

Differential Revision: D7956570

fbshipit-source-id: b38539082ac0f6537f20a4f1d5a097407c277adc

Summary:
fbthrift generate errorneous code when cpp type IOBuf pointer is used. Let's use
IOBuf object instead as it is cheap to copy construct and underlying buffer is
anyway shared when objects are copied.

Reviewed By: plapukhov

Differential Revision: D8130040

fbshipit-source-id: 3c109a85951054fed890707f56170b46cfefc917

Summary:
See code comment

(Note: this ignores all push blocking failures!)

Reviewed By: andriigrynenko

Differential Revision: D8130722

fbshipit-source-id: c2a3e4b0de1fe7d07e28c4a7558e4367a1591ac1

Summary: [Folly] Give Try constructors and assignment operators pedantic exception specifiers deriving from corresponding exception specifiers of element type.

Reviewed By: marshallcline

Differential Revision: D8105158

fbshipit-source-id: 3cc9aae022ddaeef3ef2b742dde8ba084bfca830

Summary:
[Folly] Make `exception_wrapper` be `noexcept`-copyable.

This works across the storage types:
* InSitu - only store `noexcept`-copyable objects in-situ.
* OnHeap - `std::shared_ptr` is `noexcept`-copyable.
* Thrown - `std::exception_ptr` is in practice `noexcept`-copyable since it is a smart-ptr for thrown objects.

Reviewed By: marshallcline

Differential Revision: D8109991

fbshipit-source-id: e637c72466b22ab3076f52b4654a7538dcb1d30f

Reviewed By: yfeldblum

Differential Revision: D8022229

fbshipit-source-id: 1ba1d777cbbeb1d1ad95dc3f4bae6b3d431b9440

Summary:
Original commit changeset: 577063f920fb

(Note: this ignores all push blocking failures!)

Reviewed By: djwatson

Differential Revision: D8126439

fbshipit-source-id: 30154738262274a688f432465119b0730d395df6

Summary:
[Folly] Invoke Futures `then`-continuations with the same cvref as passed.

for example, if passed as `const&&`, invoke as `const&&`, and if passed as `volatile&`, invoke as `volatile&`.

This brings a little more consistency to the library.

Reviewed By: LeeHowes, phoad

Differential Revision: D8109784

fbshipit-source-id: 8dd56c6197211091ed53eba94aeec9d604268d15

Summary:
Fix usage of atomic::store() where memory order is the only argument.

It worked because of memory_order value is implicit casted to correct value luckily.

Reviewed By: djwatson

Differential Revision: D8108348

fbshipit-source-id: 7c4050b8cb50ec3ab6977cd9adce45249130320c

Summary: I broke the build because MSVC versions prior to Visual Studio 2017 Update 7 failed to compile it :)

Reviewed By: yfeldblum

Differential Revision: D8107563

fbshipit-source-id: 0c8f97325fd76a56d335ff71c9b969ad2bfaa5a1

Summary: Iterate only through the threads that have in use entries

Reviewed By: djwatson

Differential Revision: D7931363

fbshipit-source-id: 577063f920fb432e255a59e90faa32ab72107124

Summary: [Folly] Minimize `AtFork` deps by using removing use of `checkPosixError`. The owning library is a bit heavyweight.

Reviewed By: simpkins

Differential Revision: D8109884

fbshipit-source-id: a0a41ff64fd44b843970ae30f8fdb8ff4ff22acd

Summary: Mark non-linux unused parameters as unused

Reviewed By: yfeldblum, Orvid

Differential Revision: D8103305

fbshipit-source-id: dc67849177e95718d0d6d658d1e2af88e867d81f

Summary: As per title.

Reviewed By: yfeldblum

Differential Revision: D8103967

fbshipit-source-id: 27fbc45df3ee1ec8934ea3c16aaa490fb06ef622

Summary: Visual Studio 2017 Update 7.2 is out, so this is no longer needed. This should fix GCC 4.9 as well :)

Reviewed By: yfeldblum

Differential Revision: D8104179

fbshipit-source-id: e3b01c2f7f0fe69dc7286d2cfaa5c2c99d821b23

Summary:
* Use the new advanced API.
* Support all advanced compression options and decompression window size.
* Dictionary support is easy to add later when needed.
* Remove the one-pass optimizations since zstd supports them by default now.

Reviewed By: yfeldblum

Differential Revision: D7898697

fbshipit-source-id: 42d84808a9bf2200ebfb8d2071b853960a19eb79

Summary: A simpler manual executor that can be executed by a python thread, and release the GIL while waiting.

Reviewed By: andriigrynenko

Differential Revision: D8087779

fbshipit-source-id: a75ecbda3804a53f1b705aa04546b74368738b7b