1. 02 Sep, 2020 5 commits
    • Yedidya Feldblum's avatar
      Test constexpr_strlen, constexpr_strcmp fallbacks · 6b2d55ec
      Yedidya Feldblum authored
      Summary: [Folly] Test `constexpr_strlen`, `constexpr_strcmp` fallback implementations alongside the main implementations, since the main implementations may fall back to the fallback implementations on some platforms but not on others, and we may only be testing on the other platforms.
      
      Differential Revision: D23432301
      
      fbshipit-source-id: 271705cb8c2b1ab6d11c1be20e2c3023cacab583
      6b2d55ec
    • Yedidya Feldblum's avatar
      Cut FOLLY_CREATE_HAS_MEMBER_FN_TRAITS · 3b18d435
      Yedidya Feldblum authored
      Summary: [Folly] Cut `FOLLY_CREATE_HAS_MEMBER_FN_TRAITS` since it is unused and does not match the current invoker model, replacing uses which need it with `FOLLY_CREATE_MEMBER_INVOKER`.
      
      Reviewed By: vitaut
      
      Differential Revision: D23371070
      
      fbshipit-source-id: 7fb0f5af21321a5056e06933ebd364a0a48a8fa1
      3b18d435
    • Shai Szulanski's avatar
      Add folly::coro::makeTask · d61f81cc
      Shai Szulanski authored
      Summary: Reduce boilerplate when defining simple coroutines, e.g. in tests
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23404552
      
      fbshipit-source-id: a19e9cb6640e3897d3c166499014ebe4c19fbf04
      d61f81cc
    • Giuseppe Ottaviano's avatar
      Fix atomic_shared_ptr tests · 69f66b7e
      Giuseppe Ottaviano authored
      Summary: D9312236 (https://github.com/facebook/folly/commit/bc16b096b1f6659e29379a650998bbfcf0c03eca) made these tests conditional on using libstdc++, but the header that defines the macro is not included prior to the `#ifdef`, so the tests (and benchmarks) are disabled unconditionally.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23469536
      
      fbshipit-source-id: 2ab0b2d28748419d88e946eff9b09b98d361dedb
      69f66b7e
    • Yedidya Feldblum's avatar
      Revise is_transparent_v and is_transparent · c5adaa59
      Yedidya Feldblum authored
      Summary: [Folly] Revise `is_transparent_v` as a variable and as eager, and atop `is_detected`, and `is_transparent` as a type and as deferred.
      
      Reviewed By: Mizuchi
      
      Differential Revision: D23367991
      
      fbshipit-source-id: be30184b04e2a1977db3faccd57e947dd33282ce
      c5adaa59
  2. 01 Sep, 2020 7 commits
    • Maged Michael's avatar
      hazptr: Rename warning function · 92a2a9b3
      Maged Michael authored
      Summary:
      Change name of warning_list_too_large to hazptr_warning_list_too_large for consistency with other hazptr warning functions.
      
      Add missing  FOLLY_EXPORT.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23436826
      
      fbshipit-source-id: 149c62c9d1cd3320ef525a90c0b591b274228054
      92a2a9b3
    • Yedidya Feldblum's avatar
      is_detected · 2d4d958f
      Yedidya Feldblum authored
      Summary: [Folly] `is_detected`, for a common pattern around `void_t`, backported from Library Fundamentals TS v2.
      
      Reviewed By: Mizuchi
      
      Differential Revision: D23367990
      
      fbshipit-source-id: 3a0e9a5b7eb668f872ce699757e32bb620bb5404
      2d4d958f
    • Dan Melnic's avatar
      Add support for microsecond intervals in the function scheduler · 354e50d4
      Dan Melnic authored
      Summary: Add support for microsecond intervals in the function scheduler
      
      Reviewed By: arushiagg
      
      Differential Revision: D23433411
      
      fbshipit-source-id: 39d201feaaed8007ec880a799129ed94bedd827a
      354e50d4
    • Dan Melnic's avatar
      Add io_uring registered buffers support · 16d63941
      Dan Melnic authored
      Summary: Add io_uring registered buffers support
      
      Reviewed By: kevin-vigor
      
      Differential Revision: D23421043
      
      fbshipit-source-id: b9c6a4bbd7a6b6cc580b1e3f64320d9e59d04ab2
      16d63941
    • Yedidya Feldblum's avatar
      Revise is_instantiation_of_v and is_instantiation_of · 6226f8a2
      Yedidya Feldblum authored
      Summary: [Folly] Revise is_instantiation_of_v as a variable and as eager, and is_instantiation_of as a type and as deferred.
      
      Reviewed By: Mizuchi
      
      Differential Revision: D23367989
      
      fbshipit-source-id: bf6ebd74b8e7758818dfcebd04152e1297bc99e4
      6226f8a2
    • Lucian Grijincu's avatar
      folly: doNotOptimizeAway + makeUnpredictable to their own library: folly/BenchmarkUtil.h · 8132af20
      Lucian Grijincu authored
      Summary: These lightweight functions are useful on their own, but were tied to `Benchmarking.h` & all their dependencies.
      
      Reviewed By: yfeldblum, ot
      
      Differential Revision: D20239087
      
      fbshipit-source-id: 644601b6f869191db1492d0738f3af723b9e0f4b
      8132af20
    • Victor Zverovich's avatar
      Fix LoggerTest · 0dd60e57
      Victor Zverovich authored
      Summary: Fix overspecified LoggerTest.
      
      Reviewed By: yfeldblum, simpkins
      
      Differential Revision: D23425421
      
      fbshipit-source-id: ecfd7d0e73555b3a94a81b54ffd1287bf9664697
      0dd60e57
  3. 31 Aug, 2020 3 commits
  4. 28 Aug, 2020 8 commits
    • Chad Austin's avatar
      stop using deprecated std::iterator · 8dc2d39f
      Chad Austin authored
      Summary:
      std::iterator was deprecated in C++17, so define the iterator trait
      properties directly. This fixes warnings during compilation with Clang
      on Windows.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23353495
      
      fbshipit-source-id: 7c6c0b7fb175251260e5b519ce98bd679b6c99c4
      8dc2d39f
    • Dan Melnic's avatar
      Add support for async range submit · db7a54ac
      Dan Melnic authored
      Summary: Add support for async range submit
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23389493
      
      fbshipit-source-id: 7171893a2eeccc20fcdd625e98f88d365027c930
      db7a54ac
    • Andrii Grynenko's avatar
      Workaround for TSAN symmetric transfer bug · 135f8252
      Andrii Grynenko authored
      Summary: TSAN breaks symmetric transfer behavior in compiler. Work around it by rescheduling work on executor when possible.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23391328
      
      fbshipit-source-id: 7b25a0c89664ca14114f8ae0dc650ff9bb786fe1
      135f8252
    • Dan Melnic's avatar
      Switch from VLA to folly::small_vector · 687f3fe8
      Dan Melnic authored
      Summary: Switch from VLA to folly::small_vector
      
      Reviewed By: yfeldblum, ot
      
      Differential Revision: D23391426
      
      fbshipit-source-id: c6c61f3f0eef5b6e71ad3a639fcfdb4fa1b7268e
      687f3fe8
    • Dan Melnic's avatar
      Add support for microsecond intervals in the function scheduler · defe385b
      Dan Melnic authored
      Summary: Add support for microsecond intervals in the function scheduler
      
      Reviewed By: yfeldblum, Mizuchi
      
      Differential Revision: D23153179
      
      fbshipit-source-id: 10f18d7b774c47659fe8191f8d92dca341e1cf97
      defe385b
    • Yedidya Feldblum's avatar
      Remove the guard around tag · d2a3bb4f
      Yedidya Feldblum authored
      Summary: [Folly] Remove the guard around `tag`, the inline variable of type `tag_t`.
      
      Reviewed By: Mizuchi
      
      Differential Revision: D23370037
      
      fbshipit-source-id: 59a48d834904b7e503f807c62fff8534568c9a0a
      d2a3bb4f
    • Andrew Smith's avatar
      Make folly::coro::co_invoke work with folly::coro::Generator · 28cc462f
      Andrew Smith authored
      Summary: This diff makes folly::coro::co_invoke work with folly::coro::Generator.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23332912
      
      fbshipit-source-id: b3e25d160a94aed8892bf55ad5007f4018786e47
      28cc462f
    • Lewis Baker's avatar
      Add folly::coro::AsyncScope::remaining() · 4c6cb736
      Lewis Baker authored
      Summary:
      Add a method for querying the number of remaining tasks
      that have been added to an AsyncScope but that have not
      yet completed.
      
      This can be useful for implementing some load-shedding
      strategies based on the current number of active tasks
      added to a scope.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D21461637
      
      fbshipit-source-id: 628c236e0c99fa952e63f84366186246e5286bc8
      4c6cb736
  5. 27 Aug, 2020 2 commits
    • Zhengxu Chen's avatar
      Update OSS CMakeLists.txt to use CMAKE_CXX_STANDARD · 9fdb0d52
      Zhengxu Chen authored
      Summary: Adjust low level deps in OSS builds to use standard `CMAKE_CXX_STANDARD` variables to control std level in cpp builds.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23333713
      
      fbshipit-source-id: cd76712d6b045f1d0aff30d4874d9bf0ce6f1e01
      9fdb0d52
    • Yedidya Feldblum's avatar
      Use C++ to check for mobile in IOBuf · 8af2de83
      Yedidya Feldblum authored
      Summary:
      [Folly] Use C++ v.s. the preprocessor to check for mobile in `IOBuf`.
      
      Using C++ allows the compiler, when compiling for any platform, to see the full code for every platform and to typecheck and report errors.
      
      Reviewed By: aditya7fb
      
      Differential Revision: D23365674
      
      fbshipit-source-id: 9cfe048a3114be3d6ef4522e279e19fb21f50a17
      8af2de83
  6. 26 Aug, 2020 2 commits
    • Chad Austin's avatar
      unconditionally build symbolizer sources even if FOLLY_USE_SYMBOLIZER is unset... · 90ab2b68
      Chad Austin authored
      unconditionally build symbolizer sources even if FOLLY_USE_SYMBOLIZER is unset or the platform is non-ELF
      
      Summary:
      Rather than conditionally include the folly symbolizer sources in the
      CMake build, always build them, and add appropriate dependency defines
      to conditionally enable functionality.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D22970595
      
      fbshipit-source-id: 957242b7fde28584edd78a1a6dbe9f830e98e726
      90ab2b68
    • Robin Cheng's avatar
      Disable some slow StlVectorTest cases under TSAN. · 6da515d7
      Robin Cheng authored
      Summary: These tests time out under TSAN and there's not much value to run them under TSAN because the tests are single-threaded.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23302147
      
      fbshipit-source-id: 6fc8bd3e29c9cde72bfa85a14fd7726850540285
      6da515d7
  7. 25 Aug, 2020 4 commits
  8. 24 Aug, 2020 1 commit
  9. 22 Aug, 2020 2 commits
    • Michael Park's avatar
      Add `std::variant` support for `folly::variant_match`. · a5683e13
      Michael Park authored
      Summary: This patch adds support for `std::variant` to `folly::variant_match` but without including `<variant>`.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23196572
      
      fbshipit-source-id: 9d5b519958b04c13cc024d393247c73cec00ac67
      a5683e13
    • Misha Shneerson's avatar
      Do not capture RCTX in HHWheelTimer's underlying AsyncTimeout · e72f5c7b
      Misha Shneerson authored
      Summary:
      We should only be capturing `folly::RequestContext` in HHWheelTimer's callback
      objects (already  happens). And avoid capturing it in underlying AsyncTimeout.
      
      Notice that `AsyncTimeout::scheduleTimeout`/`scheduleTimeoutHighRes` APIs capture
      current `folly::RequestContext` and `AsyncTimeout::cancelTimeout`
      releases the captured `folly::RequestContext`
      
      Now, the way HHWheelTimer works, it re-uses one instance of AsyncTimeout for
      multiple timeouts. This opens up possibility for leaking lifetime of RCTX.
      Imagine first  request A and then B schedule timeouts using same HHWheelTimer
      instnace. A's RCTX is captured by underlying AsyncTimeout. Next, request A is
      complete and we need to cancel its timeout. Notice, however that A's RCTX will
      not be destroyed as long as B is still running. That's the lifetime management
      leak.
      
      Reviewed By: jordalgo, andriigrynenko
      
      Differential Revision: D23260733
      
      fbshipit-source-id: 0bdf79db40d34d6682e89e87ce30811ffccc8cbf
      e72f5c7b
  10. 21 Aug, 2020 2 commits
  11. 20 Aug, 2020 4 commits
    • Shai Szulanski's avatar
      Add deduction guide to co_result · 694c1cbc
      Shai Szulanski authored
      Reviewed By: yfeldblum, lewissbaker
      
      Differential Revision: D23240860
      
      fbshipit-source-id: 74aab6151c9c44159a2d3fc4e041b475b69e29e7
      694c1cbc
    • Dan Melnic's avatar
      Do not call scheduleImmediateRead() if the EVB has changed · c4c78b82
      Dan Melnic authored
      Summary: Do not call scheduleImmediateRead() if the EVB has changed
      
      Reviewed By: yfeldblum
      
      Differential Revision: D23234912
      
      fbshipit-source-id: 8394700a53b4e2fa925519271c1c27fc0ce11a85
      c4c78b82
    • Nanshu Chen's avatar
      refactor Enum code generation · ad89a017
      Nanshu Chen authored
      Summary:
      Changed the way how enums generated in thrift-py3:
      
      1. Use C++ map to store name to unique Enum Python instances cache
      2. Dynamically find instances from cache (or create one and add to cache) instead of populating all instances at module load time
      3. use `__getattr__` and `__getitem__` instead of code-gen all the getters
      
      Reviewed By: asp2insp
      
      Differential Revision: D23182622
      
      fbshipit-source-id: 75baef997ee2d604b4ef7606f282cfc3306208ac
      ad89a017
    • Andrew Gallagher's avatar
      Remove self-include · 1ceb5acb
      Andrew Gallagher authored
      Reviewed By: yfeldblum
      
      Differential Revision: D23223918
      
      fbshipit-source-id: 72fb70ccabb57229298515f55334807ad2dfff36
      1ceb5acb