1. 11 Apr, 2019 4 commits
    • Caleb Marchent's avatar
      fbcode_builder support for using Python virtualenv (#76) · 6eecca09
      Caleb Marchent authored
      Summary:
      Needs to be enabled by option PYTHON_VENV in the config.
      
      shell_builder.py sets up the venv and uses it once; calling activate
      
      For docker we set ENV; resulting in the virtual environment being present
      when the resulting container is run as well as at build time. This is also cleaner
      and easier to follow than re-asserting on each RUN step.
      
      For Lego builder we need to source activate on each command as environment
      will not persist between commands.
      
      While man on the posts say it makes no sense to use virtualenv within docker
      container, this method simplifies the process considerably as we can rely on the
      name pip being valid and we don't need to either ensure we are root or pass the
      --user flag to pip and setuptools.
      
      Pull Request resolved: https://github.com/facebookincubator/LogDevice/pull/76
      
      Reviewed By: wez
      
      Differential Revision: D14875633
      
      Pulled By: calebmarchent
      
      fbshipit-source-id: aabbcdd509d2a59fa36f8004032a052f014ce1ba
      6eecca09
    • Kirk Shoop's avatar
      add take_until · 5b474b9d
      Kirk Shoop authored
      Summary: add take_until algorithm
      
      Reviewed By: ericniebler
      
      Differential Revision: D13697233
      
      fbshipit-source-id: b2e060bc88cb652dc196e4915961d811a97b414d
      5b474b9d
    • Caleb Marchent's avatar
      Add .pyc to gitignore · 1689b2f7
      Caleb Marchent authored
      Reviewed By: wez
      
      Differential Revision: D14890912
      
      fbshipit-source-id: 7ea8f28348d27131cf896bd8b5669153211af591
      1689b2f7
    • Long Cheng's avatar
      Cleanup SemiFutureTest · de260dd8
      Long Cheng authored
      Summary:
      - Removed unused EventBase
      - Simplified
      ```
      auto f = p.getSemiFuture().toUnsafeFuture();
      auto sf = std::move(f).semi().defer(...);
      ```
      
      to
      
      ```
      auto sf = p.getSemiFuture().defer(...);
      ```
      
      - Corrected `semiFutureWithinNoValueReferenceWhenTimeOut`. it wasn't testing anything because the future is not waited for and if it's waited for, `callbackInput` has exception, not value.
      
      Reviewed By: LeeHowes
      
      Differential Revision: D14877386
      
      fbshipit-source-id: 03df59af0339b20aa9e85506640e89cc383f3b9a
      de260dd8
  2. 10 Apr, 2019 4 commits
    • Orvid King's avatar
      AsyncServerSocket::AcceptCallback::connectionAccepted to NetworkSocket (attempt #2) · 3c6096c2
      Orvid King authored
      Summary:
      The file descriptor API here needs to go away, so switch this API to NetworkSocket
      
      It is expected that this commit will cause a number of Open Source projects to temporarily show up as broken. This is due to the fact that not all projects get synced to Github at the exact same time, so the builds may temporarily be fetching an older version of it's dependencies than it needs to :) It should fix itself quickly.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14673328
      
      fbshipit-source-id: c5842fa5dc383d50043e0d8228e35d03b10a1c6b
      3c6096c2
    • Yedidya Feldblum's avatar
      Address gcc-5.3 ice in pretty_name (#1106) · f75287f2
      Yedidya Feldblum authored
      Summary:
      [Folly] Address gcc-5.3 ice in `pretty_name`.
      
      Fixes #1105.
      
      Pull Request resolved: https://github.com/facebook/folly/pull/1106
      
      Reviewed By: Orvid
      
      Differential Revision: D14864700
      
      fbshipit-source-id: bd336135c8c39daca63e2a23fa5e9ea8589dd067
      f75287f2
    • Yedidya Feldblum's avatar
      Wait on the specified child in the rcu fork test · 41eed442
      Yedidya Feldblum authored
      Summary: [Folly] Wait on the specified child in the rcu fork test, v.s. waiting on any child. Makes the test more exact.
      
      Differential Revision: D14869269
      
      fbshipit-source-id: 2bb0110e5097f1dfe21602a09893a33e92421555
      41eed442
    • Doron Roberts-Kedes's avatar
      Introduce SIMDTable for ConcurrentHashMapSegment · 8ad6b845
      Doron Roberts-Kedes authored
      Summary:
      As an alternative to backend to BucketTable, introduce SIMDTable, which mimics the use of SSE intrinsics to filter tags as found in F14 code.
      
      On synthetic benchmarks, SIMDTable outperforms BucketTable by between 1.1x and 2.6x operations per second when the map does not fit in cache. However, when the map fits in cache SIMDTable executes around 10% fewer operations per second compared with BucketTable.
      
      BucketTable, the existing backend, remains the default.
      
      Reviewed By: djwatson
      
      Differential Revision: D14458269
      
      fbshipit-source-id: 5b6b01db5eb2430bdfc6f3500458f25971a6ad3d
      8ad6b845
  3. 09 Apr, 2019 12 commits
    • Yedidya Feldblum's avatar
      Handle Clang on Windows in pretty_name · 1060fb28
      Yedidya Feldblum authored
      Summary: [Folly] Handle Clang on Windows in `pretty_name`.
      
      Reviewed By: Orvid
      
      Differential Revision: D14844690
      
      fbshipit-source-id: 1f995604d5be0cd571caa344e5b18f877188390d
      1060fb28
    • Alejandro Mallea's avatar
      Removes unused function for non-MS compilers. · 47b5e69f
      Alejandro Mallea authored
      Summary:
      When building without Microsoft Visual C++, `do_nothing` is not used
      at all, potentially triggering unused function warnings, which makes it useless
      to compile with strict flags such as `-Wall -Werror`.
      
      Reviewed By: yfeldblum, aary
      
      Differential Revision: D14843227
      
      fbshipit-source-id: 28f0041ccae8bf07dc1f3e41e1cf67291c3d8447
      47b5e69f
    • Orvid King's avatar
      Fix Folly for C++ p0482 · 3621a2f9
      Orvid King authored
      Summary:
      TLDR; The element type of a utf8 string literal was changed from a `char` to a `char8_t`, which are incompatible. There is a paper that aims to resolve some of these issues, but the next version of MSVC has already implemented p0482, so we need to add a workaround for now.
      
      Fixes: https://github.com/facebook/folly/issues/1102
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14856705
      
      fbshipit-source-id: 983548cb0cb210341ec55d9dcdc63e726bfe4f62
      3621a2f9
    • Adam Norton's avatar
      Fix WindowTests · 70ebf75b
      Adam Norton authored
      Summary: `collect` short-circuits on an exception, so we need to wait for all the callbacks before deallocating the captured state
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14818841
      
      fbshipit-source-id: e7af2965b7641feff1e4230a6a66c7860994f826
      70ebf75b
    • Nathan Bronson's avatar
      add missing FOLLY_ALWAYS_INLINE to F14Map erase · 2b546a7a
      Nathan Bronson authored
      Summary:
      F14Map::erase(it) returns ++it for compatibility, but it
      is often discarded. erase(const_iterator) was marked always-inline to
      enable the computation of the return value to be optimized away, but the
      annotation was missing from erase(iterator).  This also adds always-inline
      annotations to a couple more methods that participate in the optimization,
      but they are very good candidates for inlining regardless.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14854278
      
      fbshipit-source-id: ad686b2dc8996b6a7c7038653a7c9ea1567e554d
      2b546a7a
    • Long Cheng's avatar
      Delete duplicated tests · b49e3a58
      Long Cheng authored
      Summary: Appear to be leftover from D8683752
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14854252
      
      fbshipit-source-id: bef87438201f9292fb0e5c62222d1a248163eda2
      b49e3a58
    • Doron Roberts-Kedes's avatar
      folly: Move reusable f14 code into F14Mask.h · 9bcd9d44
      Doron Roberts-Kedes authored
      Summary: Reusable mask/iter code moves into folly/container/detail/F14Mask.h. This is in preparation for reuse by SIMDTable in ConcurrentHashMap.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14729170
      
      fbshipit-source-id: fbf5e10a13eeb5e964f52d4fe262f9e5ae2e8f73
      9bcd9d44
    • Doron Roberts-Kedes's avatar
      Refactor folly::ConcurrentHashMapSegment to delegate internal work to BucketTable impl_ member · 6e6f1db2
      Doron Roberts-Kedes authored
      Summary:
      This sets the stage for D14458269, which adds a 2nd possible ImplT class.
      
      Move code shared between ImplT's into shared area.
      
      Work done in *_internal functions and functions that access member fields other than `batch_` now goes into this impl_ member.
      
      ConcurrentHashMapSegment basically is now just a wrapper that knows how to translate things like emplace, try_emplace, assign, etc. to various flavors of insert_internal. Changes to erase control flow are analogous.
      
      Reviewed By: davidtgoldblatt
      
      Differential Revision: D14458241
      
      fbshipit-source-id: 41d103141ead1eb306b6fe863932f00f827f68c3
      6e6f1db2
    • Joe Loser's avatar
      Fix deduction guide macro guard for Replaceable (#1097) · 5caa4e1d
      Joe Loser authored
      Summary:
      - `Replaceable` defines a deduction guide if the feature test macro for
        it is met, or if we are on MSVC. However, the MSVC version that folly
        supports also defines the feature test macro for deduction guides. As
        such, remove the extra check for MSVC.
      - Add `ReplaceableTest` to the  cmake build.
      - Add test for deduction guide.
      Pull Request resolved: https://github.com/facebook/folly/pull/1097
      
      Reviewed By: Orvid
      
      Differential Revision: D14699047
      
      Pulled By: yfeldblum
      
      fbshipit-source-id: ee62bae0f4b05f1a110c2bd90470fecbb0666d24
      5caa4e1d
    • Yedidya Feldblum's avatar
      kIsClang · abc7ab99
      Yedidya Feldblum authored
      Summary: [Folly] `kIsClang`.
      
      Reviewed By: Igman
      
      Differential Revision: D14844691
      
      fbshipit-source-id: 80a738d5925d6d61e69f38ef5b43bf47691d233a
      abc7ab99
    • Orvid King's avatar
      Fix build of DistributedMutex · 9a38d122
      Orvid King authored
      Summary:
      It was broken, fix it.
      
      Fixes https://github.com/facebook/folly/issues/1092
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14842180
      
      fbshipit-source-id: 899c95fdac3622c78c9c6f326cd14898007ddf6c
      9a38d122
    • Orvid King's avatar
      Remove the fd overloads of AsyncPipe components · 845936ce
      Orvid King authored
      Summary: They're dead
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14838871
      
      fbshipit-source-id: 4b136d7a5914a1564f32bb87e6bec2b8d1411829
      845936ce
  4. 08 Apr, 2019 6 commits
    • Eric Niebler's avatar
      Simplify constraints on operator co_await for SingleTypedSenders · fab6cad7
      Eric Niebler authored
      Summary: Because of the guard against constraint recursion in the definition of `struct awaitable_sender_traits` (awaitable/concepts.h, line 75), there is no need to be so conservative with the constraints of the generic `operator co_await` for `SingleTypedSender`s.
      
      Reviewed By: kirkshoop
      
      Differential Revision: D14816672
      
      fbshipit-source-id: b2f49588ae98ea63a24f4044692470c59be15e29
      fab6cad7
    • Orvid King's avatar
      Remove the fd overload of EventHandler::EventHandler · 85525f39
      Orvid King authored
      Summary: Things have been ported, time to remove the fd version.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14703143
      
      fbshipit-source-id: 13498d5a4c20d19c30c0d0fe942c5d62bb99aa08
      85525f39
    • Wez Furlong's avatar
      Back out "folly: cmake: enable DistributedMutexTest.cpp" · a96c8c4f
      Wez Furlong authored
      Summary:
      I only enabled this speculatively, but since it quite a heavyweight
      test, it is timing out in the open source build, so let's turn it off again.
      
      Reviewed By: lewissbaker
      
      Differential Revision: D14817162
      
      fbshipit-source-id: 343b021890974e5b92975bdfc7b4fa554d20a703
      a96c8c4f
    • Wez Furlong's avatar
      oss: FindLibEvent.cmake: workaround cmake POLICY annoyances · f39f7560
      Wez Furlong authored
      Summary:
      When pulled in as an external project into an environment
      that has changed the default cmake policy, the trick we're using
      to extract the full library path errors out.  This works around
      that issue by saving the policy settings and then setting them
      how we need them before restoring them after we're done.
      
      refs https://github.com/facebook/folly/issues/1100
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14766991
      
      fbshipit-source-id: e2506bc0aebd9e66bc70b12c4c538c9e034f9f73
      f39f7560
    • Orvid King's avatar
      Shift AsyncPipe to NetworkSocket · a484a114
      Orvid King authored
      Summary:
      Shift AsyncPipe to be backed by NetworkSocket, as the only things this can be used for are listenable to by libevent. At the moment, the APIs for what are listenable to by libevent are all described in terms of NetworkSocket.
      While, by name, this may seem incorrect, in practice, it is correct in function, due to the limitations of how NetworkSocket's are obtainable on Windows, and all existing calls to these functions on posix platforms are already functional by being file descriptor backed.
      The plan is to have this, slightly badly named for the location, interface for the moment, and to clean it up in the future.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14702972
      
      fbshipit-source-id: 785281a7bb9fafc63f5295e33f5bc136b9bc70f1
      a484a114
    • Yedidya Feldblum's avatar
      Lower quadratic iteration count in an elias-fano test · dbff71d2
      Yedidya Feldblum authored
      Summary: [Folly] Lower quadratic iteration count in an elias-fano test to make it take less wall time to run.
      
      Reviewed By: philippv
      
      Differential Revision: D14821341
      
      fbshipit-source-id: 726fe5bd17442661196593ea6279314509622832
      dbff71d2
  5. 07 Apr, 2019 1 commit
  6. 06 Apr, 2019 3 commits
  7. 05 Apr, 2019 10 commits
    • Orvid King's avatar
      Remove fd overload of AsyncServerSocket::useExistingSocket · a89579c3
      Orvid King authored
      Summary: All calls have been converted to the NetworkSocket overload
      
      Reviewed By: yfeldblum
      
      Differential Revision: D13566829
      
      fbshipit-source-id: c6a3b155ffe35534c0297eba7819413e4ce77282
      a89579c3
    • Yedidya Feldblum's avatar
      Cut fbcode_builder dep for thrift on krb5 · 2105cec0
      Yedidya Feldblum authored
      Summary: [Thrift] Cut `fbcode_builder` dep for `thrift` on `krb5`. In the past, Thrift depended on Kerberos and the `krb5` implementation for its transport-layer security. However, Thrift has since migrated fully to Transport Layer Security for its transport-layer security and no longer has any build-time dependency on `krb5`. Clean this up.
      
      Reviewed By: stevegury, vitaut
      
      Differential Revision: D14814205
      
      fbshipit-source-id: dca469d22098e34573674194facaaac6c4c6aa32
      2105cec0
    • Lewis Baker's avatar
      Add folly::coro::collectAll[Try]Range() · 699acb25
      Lewis Baker authored
      Summary:
      Add functions for concurrently awaiting a collection of SemiAwaitable objects.
      
      * `folly::coro::collectAllRange()` takes an InputRange of SemiAwaitable objects and concurrently awaits them, producing a `std::vector` of the results. This will throw an exception if any of the input operations failed with an exception.
      * `folly::coro::collectAllTryRange()` takes an InputRange of SemiAwaitable objects and concurrently awaits them, producing a `std::vector<folly::Try<T>>` containing the results. Failure of individual operations can be determined by inspecting the corresponding `Try` value.
      
      This diff also refactors the existing implementations of `folly::coro::collectAll()` to make use of a new `Barrier` and `BarrierTask` implementation detail rather than using `DetachedInlineTask`, `Baton` and an atomic counter. This allows delaying the start of the child corouines until after all coroutines have been created which was necessary for cases where we didn't know the number of elements in the input range to allow storage for the results to be allocated in a vector before the tasks start producing results.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D14430147
      
      fbshipit-source-id: 5ba4b7cdc3c9b65d1736f14a2d39f7beb6cb82b0
      699acb25
    • Orvid King's avatar
      Remove the fd overload of AsyncServerSocket::getSocket · 1290f5f2
      Orvid King authored
      Summary: It's dead.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14191959
      
      fbshipit-source-id: 8cfb68fa8f10b1f847bf6601aec8d869cb9c008d
      1290f5f2
    • Eric Niebler's avatar
      rename many_sender to simply sender · fbc1a619
      Eric Niebler authored
      Summary: To reflect the fact that the concept `SingleSender` is a refinement of `Sender` (there is no "`ManySender`"), rename `(any_)?(flow_)?many_sender` to `(any_)?(flow_)?sender`.
      
      Reviewed By: kirkshoop
      
      Differential Revision: D14803648
      
      fbshipit-source-id: 5987ebe5ba877d0a3ab38e84b036f97302bcc70b
      fbc1a619
    • Eric Niebler's avatar
      reorganize pushmi headers · bb73ffc6
      Eric Niebler authored
      Summary:
      The pushmi library has grown to the point where a little more structure would aid comprehensibility.
      
      Also, finer-grained headers and build targets would make it easier for downstream projects to include only what they absolutely need.
      
      Reviewed By: kirkshoop
      
      Differential Revision: D14802895
      
      fbshipit-source-id: 8d253f97c5d0529530cc3b7110505000f513ce83
      bb73ffc6
    • Adam Norton's avatar
      Avoid executor re-queue in collect[All]SemiFuture · 8e5c2b92
      Adam Norton authored
      Summary:
      This is a performance optimization to avoid an executor re-queue for the collect[All] continuations which just move the result.
      
      The biggest problem with this now is that these futures are often on a thread pool backed with a blocking MPMCQueue which means the add can potentially deadlock. This diff is not meant as a true fix to the problem though; just an improvement.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14754908
      
      fbshipit-source-id: e533bfa6b9d2d820d50422b612c1489b560ec9d5
      8e5c2b92
    • Yedidya Feldblum's avatar
      PriorityUnboundedBlockingQueue · 4fa5101b
      Yedidya Feldblum authored
      Summary: [Folly] `PriorityUnboundedBlockingQueue`, paralleling `UnboundedBlockingQueue` and `PriorityLifoSemMPMCQueue`.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D14536886
      
      fbshipit-source-id: b3ea04c3f67d3e1e9d80626d963be70de1ae79ba
      4fa5101b
    • Yedidya Feldblum's avatar
      Cut traits for old-ABI std::basic_string · d48cea50
      Yedidya Feldblum authored
      Summary: [Folly] Cut traits for old-ABI `std::basic_string` under libstdc++.
      
      Reviewed By: pixelb
      
      Differential Revision: D14764155
      
      fbshipit-source-id: fa4991f4b70fb407672212886c84f1be4c33581f
      d48cea50
    • Lee Howes's avatar
      Add executor-taking forms of deferValue and thenValue · c316166d
      Lee Howes authored
      Summary: For consistency adds thenExValue and deferExValue.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14793864
      
      fbshipit-source-id: 700f02cfb27b93e1739c511f01142c30c1896990
      c316166d