1. 07 Sep, 2017 1 commit
    • Kenny Yu's avatar
      Fix data race in folly/executors/Codel.cpp exposed by TSAN · 88903796
      Kenny Yu authored
      Summary:
      I found a data race with TSAN while attempting to run a sanitizer version of my service:
      
      ```
      WARNING: ThreadSanitizer: data race (pid=266)
        Read of size 8 at 0x7b58000c0c08 by thread T370:
          @ folly::Codel::overloaded(std::chrono::duration<long, std::ratio<1l, 1000000000l> >) at ./folly/executors/Codel.cpp:44
          @ apache::thrift::concurrency::ThreadManager::ImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::Worker<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::run() at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:119
          @ apache::thrift::concurrency::PthreadThread::threadMain(void*) at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:200
          @ __tsan_thread_start_func at crtstuff.c:?
      
        Previous write of size 8 at 0x7b58000c0c08 by thread T371:
          @ folly::Codel::overloaded(std::chrono::duration<long, std::ratio<1l, 1000000000l> >) at ./folly/executors/Codel.cpp:62
          @ apache::thrift::concurrency::ThreadManager::ImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::Worker<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::run() at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:119
          @ apache::thrift::concurrency::PthreadThread::threadMain(void*) at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:200
          @ __tsan_thread_start_func at crtstuff.c:?
      
        Location is heap block of size 744 at 0x7b58000c0c00 allocated by thread T314:
          @ operator new(unsigned long) at ??:?
          @ PriorityImplT at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:826
          @ void __gnu_cxx::new_allocator<apache::thrift::concurrency::PriorityThreadManager::PriorityImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > > >::construct<apache::thrift::concurrency::PriorityThreadManager::PriorityImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >, std::array<std::pair<std::shared_ptr<apache::thrift::concurrency::ThreadFactory>, unsigned long>, 5ul>&, bool&, unsigned long&>(apache::thrift::concurrency::PriorityThreadManager::PriorityImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >*, std::array<std::pair<std::shared_ptr<apache::thrift::concurrency::ThreadFactory>, unsigned long>, 5ul>&, bool&, unsigned long&)
          @ std::shared_ptr<apache::thrift::concurrency::PriorityThreadManager> apache::thrift::concurrency::PriorityThreadManager::newPriorityThreadManager<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >(std::array<unsigned long, 5ul> const&, bool, unsigned long) at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:1090
          @ std::shared_ptr<apache::thrift::concurrency::PriorityThreadManager> apache::thrift::concurrency::PriorityThreadManager::newPriorityThreadManager<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >(unsigned long, bool, unsigned long) at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:1100
          @ apache::thrift::ThriftServer::serve() at ./thrift/lib/cpp2/server/ThriftServer.cpp:475
          @ apache::thrift::server::TServer::run() at ./thrift/lib/cpp/server/TServer.h:186
          @ apache::thrift::concurrency::PthreadThread::threadMain(void*) at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:200
          @ __tsan_thread_start_func at crtstuff.c:?
      
        Thread T370 (tid=638, running) created by thread T314 at:
          @ pthread_create at ??:?
          @ apache::thrift::concurrency::PthreadThread::start() at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:108
          @ apache::thrift::concurrency::ThreadManager::ImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::addWorker(unsigned long) at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:185
          @ apache::thrift::concurrency::PriorityThreadManager::PriorityImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::start() at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:840
          @ apache::thrift::ThriftServer::setup() at ./thrift/lib/cpp2/server/ThriftServer.cpp:347
          @ apache::thrift::ThriftServer::serve() at ./thrift/lib/cpp2/server/ThriftServer.cpp:475
          @ apache::thrift::server::TServer::run() at ./thrift/lib/cpp/server/TServer.h:186
          @ apache::thrift::concurrency::PthreadThread::threadMain(void*) at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:200
          @ __tsan_thread_start_func at crtstuff.c:?
      
        Thread T371 (tid=639, running) created by thread T314 at:
          @ pthread_create at ??:?
          @ apache::thrift::concurrency::PthreadThread::start() at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:108
          @ apache::thrift::concurrency::ThreadManager::ImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::addWorker(unsigned long) at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:185
          @ apache::thrift::concurrency::PriorityThreadManager::PriorityImplT<folly::LifoSemImpl<std::atomic, folly::Baton<std::atomic, true, true> > >::start() at ./thrift/lib/cpp/concurrency/ThreadManager.tcc:840
          @ apache::thrift::ThriftServer::setup() at ./thrift/lib/cpp2/server/ThriftServer.cpp:347
          @ apache::thrift::ThriftServer::serve() at ./thrift/lib/cpp2/server/ThriftServer.cpp:475
          @ apache::thrift::server::TServer::run() at ./thrift/lib/cpp/server/TServer.h:186
          @ apache::thrift::concurrency::PthreadThread::threadMain(void*) at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:200
          @ __tsan_thread_start_func at crtstuff.c:?
      
        Thread T314 (tid=582, running) created by main thread at:
          @ pthread_create at ??:?
          @ apache::thrift::concurrency::PthreadThread::start() at ./thrift/lib/cpp/concurrency/PosixThreadFactory.cpp:108
          ...
      ```
      
      Looks like there is a data race in how `codelMinDelay_` is used. I couldn't get `std::atomic` to compile with `std::chrono::nanoseconds`,
      so I used `std::atomic<uint64_t>` and converted between `uint64_t` and time types appropriately.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5759588
      
      fbshipit-source-id: 8213f3789808265ddfe5ab122f0f86490d0ea6ea
      88903796
  2. 06 Sep, 2017 1 commit
    • James Sedgwick's avatar
      move wangle/concurrent to folly/executors · af4a3352
      James Sedgwick authored
      Summary:
      For the initial cutover, just pull the copies in folly into the wangle namespace
      The main problem with that approach is that forward declarations of wangle components no longer work, so I fixed those manually
      
      ALSO, IMPORTANT: This is a great, once in a lifetime opportunity to rename/restructure these components. I have a few ideas that I'll noodle and share eventually, e.g. changing LifoSemMPMCQueue so it's just descriptive and not an enumeration of implementation details. Please chip in with yr ideas!
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5694213
      
      fbshipit-source-id: 4fc0ea9359d1216191676fc9729fb53a3f06339f
      af4a3352
  3. 05 Sep, 2017 1 commit
    • Stella Lau's avatar
      Compress empty strings with underlying compressor · 049fb12e
      Stella Lau authored
      Summary:
      - Current behavior compresses empty strings to empty strings. This is undesirable as decompression using underlying decompressor (side-stepping the codec) will fail. This change passes empty strings to the underlying compressor
      - Decompressing empty string -> empty string was kept for backwards compatibility
      - Fix `getUncompressedLength` for zlib
      
      Reviewed By: terrelln, yfeldblum
      
      Differential Revision: D5740034
      
      fbshipit-source-id: 5a747ea4963dad872103209aa4410197f6c605db
      049fb12e
  4. 02 Sep, 2017 1 commit
    • Yedidya Feldblum's avatar
      Fix constexpr_min after D5739715 · 4fd5e900
      Yedidya Feldblum authored
      Summary:
      [Folly] Fix `constexpr_min` after {D5739715} (facebook/folly@6d7c6d55f0f4b7b75607608ef9037db58083368f).
      
      Add new unit-tests for `constexpr_min` and `constexpr_max` to avoid silly mistakes like this in the future.
      
      It was defined recursively in terms of `constexpr_max` rather than, as intended, in terns of `constexpr_min`. HT Mandar12.
      
      Reviewed By: Orvid
      
      Differential Revision: D5761831
      
      fbshipit-source-id: 2dad5833e05679232b3c529d33325a0205c2e4e4
      4fd5e900
  5. 01 Sep, 2017 2 commits
    • Igor Sugak's avatar
      increase stack size when TSAN is enabled · 555494f0
      Igor Sugak authored
      Reviewed By: meyering
      
      Differential Revision: D5757469
      
      fbshipit-source-id: ad70c47251993c79a502d30f312534e28c9241d4
      555494f0
    • Kyle Nekritz's avatar
      Deflake some AsyncSSLSocket tests. · bb9a2237
      Kyle Nekritz authored
      Summary: Fulfilling starts destroying the evb in another thread which races with the socket closing on the evb.
      
      Reviewed By: siyengar, ngoyal
      
      Differential Revision: D5755271
      
      fbshipit-source-id: ace37eee63e684c97ca0fe503293eee83514e0ac
      bb9a2237
  6. 31 Aug, 2017 3 commits
    • Aravind Anbudurai's avatar
      Add a comment on File.h · e540cbee
      Aravind Anbudurai authored
      Summary: title
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5751299
      
      fbshipit-source-id: d3967c2499da9a2c98c2862b9bdc9994c12edc76
      e540cbee
    • Yedidya Feldblum's avatar
      Extract non-portability constexpr math functions to new header · 6d7c6d55
      Yedidya Feldblum authored
      Summary:
      [Folly] Extract non-portability `constexpr` math functions to new header.
      
      This new header, `folly/ConstexprMath.h`, is specifically for compile-time-computable math functions. We start with `min`, `max`, `abs`, and `log2`.
      
      Included substantive changes:
      * Add new tests for `constexpr_strlen`, which remains in the portability header.
      * Make `constexpr_min` and `constexpr_max` variadic.
      * Make `constexpr_log2` tail-recursive, remove `const_log2` in `FixedString.h`, and move the related comment.
      
      Reviewed By: Orvid
      
      Differential Revision: D5739715
      
      fbshipit-source-id: 29d3cc846ce98bb4bdddcc8b0fa80e4d32075fe0
      6d7c6d55
    • Philip Jameson's avatar
      Don't use symbolizer on OSX · 4717bdad
      Philip Jameson authored
      Summary:
      When trying to build with targets files on OSX, I couldn't use the symbolizer because it needs StackTrace, which requires libunwind and elf. This makes it so that we only build on linux for now. This also makes it so that we set FOLLY_USE_SYMBOLIZER in autoconf, since that wasn't set before.
      
      Does a few things surrounding usage of the symbolizer library:
      - Introduce FOLLY_USE_SYMBOLIZER in folly-config.h and USE_SYMBOLIZER as an AM definition
      -- Filter some code out of init and some other random libs that optionally need the symbolizer
      - Fix libdwarf detection. Previously on a fresh ubuntu container, we didn't find libdwarf/dwarf.h, so we stopped trying before looking at dwarf.h
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5644352
      
      fbshipit-source-id: f0a3580c41122e5e8fdfd17a9fdbb0921be21401
      4717bdad
  7. 30 Aug, 2017 6 commits
    • Michael Lee's avatar
      Include `<array>` for test · faa5f598
      Michael Lee authored
      Summary: <array> is sometimes necessary for using `std::array`. Fix up
      
      Reviewed By: aary
      
      Differential Revision: D5740866
      
      fbshipit-source-id: 13bafadd26fdd0f2eff3513115b43811682e7cda
      faa5f598
    • Aaryaman Sagar's avatar
      Conditionally compiled for_each with constexpr · f45b792f
      Aaryaman Sagar authored
      Summary:
      Code was breaking in versions of C++ where constexpr functions are
      required to have one line bodies
      
      Reviewed By: yfeldblum, mzlee
      
      Differential Revision: D5739062
      
      fbshipit-source-id: 6c509f1daf77751d33ce9c173a0d7f1d3bd2a006
      f45b792f
    • Maged Michael's avatar
      Dynamic MPMCQueue: Eliminate cases of enqueue indefinite blocking and failure... · 9ce176b1
      Maged Michael authored
      Dynamic MPMCQueue: Eliminate cases of enqueue indefinite blocking and failure in the extensible version that impossible under the default pre-allocated version
      
      Summary:
      Currently under the extensible version (Dynamic == true), some enqueue operations may block indefinitely or fail (return false) even though such outcomes are impossible under the default (Dynamic == false) pre-allocated version.
      
      This diff eliminates such cases by changing the algorithms for the extensible version. Some of the high-level changes:
      - The offset formula for an expansion guarantees that no enqueue operation left behind in a closed array does not have an existing dequeue operation that unblocks it. The old formula was 1 + max(head, tail). The new formula is max(head, current offset) + current capacity.
      - Conditional operations validate state after the success of CAS.
      
      Reviewed By: djwatson
      
      Differential Revision: D5701013
      
      fbshipit-source-id: 4917c5b35b7e2a2fddfd2e11fb5aeb478502137c
      9ce176b1
    • Yedidya Feldblum's avatar
      constexpr_log2 · f7ec2efe
      Yedidya Feldblum authored
      Summary:
      [Folly] `constexpr_log2`.
      
      Useful for anything that needs to compute log2 at compile time.
      
      Reviewed By: eduardo-elizondo
      
      Differential Revision: D5734727
      
      fbshipit-source-id: 8eab7991eea2104570eecd8e84ede6160bb0b549
      f7ec2efe
    • Yedidya Feldblum's avatar
      Shrink MicroSpinLock.h transitive includes and inline methods · 70137200
      Yedidya Feldblum authored
      Summary: [Folly] Shrink `MicroSpinLock.h` transitive includes and inline methods.
      
      Reviewed By: meyering
      
      Differential Revision: D5732693
      
      fbshipit-source-id: 386816f0d97c145ff8a4180d41c8a682694aa6cb
      70137200
    • Xiao Shi's avatar
      rm old comment on HHWheelTimer::UniquePtr · 985a7f47
      Xiao Shi authored
      Summary: This comment is outdated.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5730049
      
      fbshipit-source-id: f6088c4354210fafb019656cdf8246abf90fbc06
      985a7f47
  8. 29 Aug, 2017 7 commits
  9. 28 Aug, 2017 3 commits
    • Christopher Dykes's avatar
      Enable auto-deps in all of Folly · 2ccbaf9e
      Christopher Dykes authored
      Summary: This enables the last of the magic internally.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5719795
      
      fbshipit-source-id: fb59a0d7873e9a9f3b73f556b42b647091ca7e67
      2ccbaf9e
    • Yedidya Feldblum's avatar
      Shrink MicroSpinLock.h transitive includes and inline methods · 053fb025
      Yedidya Feldblum authored
      Summary: [Folly] Shrink `MicroSpinLock.h` transitive includes and inline methods.
      
      Reviewed By: Orvid
      
      Differential Revision: D5714883
      
      fbshipit-source-id: 1744685ff9fa8d3620aef2545c8fe3ebc481df06
      053fb025
    • Patryk Zaryjewski's avatar
      Make cancelling and rescheduling of functions O(1) · 951a822c
      Patryk Zaryjewski authored
      Summary: Currently FunctionScheduler calls that cancel/restart timer for a function of particular id are O(n). By introducing hashmap that translate id to pointer of particular RepeatFunc, we make it O(1).
      
      Reviewed By: simpkins
      
      Differential Revision: D5668557
      
      fbshipit-source-id: e5e8bf9bd75b6d5d42f0bfa398d476703e5801fa
      951a822c
  10. 25 Aug, 2017 5 commits
    • Aaryaman Sagar's avatar
      gcc 6.2 was not accepting the current definition of void_t · db9fd491
      Aaryaman Sagar authored
      Summary:
      The current definition of void_t was leading to errors because unused
      template parameters are ignored and SFINAE SFIAEs
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5700825
      
      fbshipit-source-id: d23336070c217e8594980d6db710cb417b014236
      db9fd491
    • Marko Novakovic's avatar
      Added a flag FOLLY_FORCE_EXCEPTION_COUNT_USE_STD · 04a42b09
      Marko Novakovic authored
      Summary:
      The flag FOLLY_FORCE_EXCEPTION_COUNT_USE_STD forces
      the usage of std:uncaught_exceptions() for folly's
      implementation of uncaught_exceptions()
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5542302
      
      fbshipit-source-id: 2c2f507ab9dde916a160a9c370a267cdcfd7203a
      04a42b09
    • Stella Lau's avatar
      Enforce forward progress with StreamCodec · 91022bb0
      Stella Lau authored
      Summary:
      - Throw exception if no forward progress was made with `StreamCodec.compress()` and `StreamCodec.uncompress()`
      - Prevents infinite looping behavior when no forward progress was made
      - Update tests
      
      Reviewed By: terrelln
      
      Differential Revision: D5685690
      
      fbshipit-source-id: 969393896b74f51250f0e0ce3af0cd4fedcab49a
      91022bb0
    • Qinfan Wu's avatar
      Fix typo in Function.h · 82ee3be4
      Qinfan Wu authored
      Summary: [Folly] Fix typo in `Function.h`.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5703550
      
      fbshipit-source-id: 9dc09697fd09db6c65b1a4f2d8bdf44451b4aab2
      82ee3be4
    • Greg Nisbet's avatar
      add public kSlotSize to IndexedMemPool · 37c61971
      Greg Nisbet authored
      Summary:
      add public kSlotSize to IndexedMemPool,
      needed to support getting the approximate memory footprint of the pool
      (since a Slot has two atomic uint32_t's more than a bare Elem)
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5690225
      
      fbshipit-source-id: 667da6b67b339038b92b0e5acde17219fe1c85c5
      37c61971
  11. 24 Aug, 2017 9 commits
    • Aaryaman Sagar's avatar
      Added rvalue and const rvalue overloads to Try · 51647aaa
      Aaryaman Sagar authored
      Summary:
      Try was missing some important-ish overloads that help it behave well
      in rvalue contexts
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5692021
      
      fbshipit-source-id: c34627b56eb52dceaeb1f00ae930ee3bc6e00306
      51647aaa
    • Aaryaman Sagar's avatar
      unwrapTryTuple only accepted rvalue tuple types · 374d408b
      Aaryaman Sagar authored
      Summary:
      unwrapTryTuple only accepted rvalue tuple types, this diff fixes that
      to work with forwarding reference tuple types.
      
      Also reduces the number of template instantiations
      
      Reviewed By: yfeldblum
      
      Differential Revision: D5682996
      
      fbshipit-source-id: ee6dd2c20d8dfca33e769a98a6ca56fa96c73b72
      374d408b
    • Andrii Kryzhyk's avatar
      Create generic method to extract mac address from EUI-64 constructed addresses · de75bdc4
      Andrii Kryzhyk authored
      Summary: Link local is not the only type of address that is based on mac address, therefore create generic function to extract mac address from EUI-64 autoconfigured addresses using the same logic as for getMacAddressFromLinkLocal
      
      Reviewed By: pallotron
      
      Differential Revision: D5697781
      
      fbshipit-source-id: 4d69085a1d8f08e06496b8a9b638ac7ff31c6c3a
      de75bdc4
    • Peter DeLong's avatar
      Improve formatting of scripts and test files · f2d4ac87
      Peter DeLong authored
      Summary: Reformatted the scripts and test files to look better and also to avoid lint warnings in the future
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D5673856
      
      fbshipit-source-id: 5818625ec14d18ef3b9b804df53949afefc3b98f
      f2d4ac87
    • Stella Lau's avatar
      Add LZMA streaming interface · 9dc004f8
      Stella Lau authored
      Summary:
      - Replace LZMA2Codec with LZMA2StreamCodec
      - Update tests to reflect LZMA2_VARINT_SIZE requiring data length
      
      Reviewed By: terrelln
      
      Differential Revision: D5625388
      
      fbshipit-source-id: 3303c6dda5d41f40615c87504a46923815b0b716
      9dc004f8
    • Yedidya Feldblum's avatar
      Try::exception overload for Try&& · 4d4a549d
      Yedidya Feldblum authored
      Summary:
      [Folly] `Try::exception` overload for `Try&&`.
      
      For consistency with `Try::value`.
      
      Reviewed By: WillerZ
      
      Differential Revision: D5691758
      
      fbshipit-source-id: 9904b2a5c90f4575a3c09dc012658d359d11fdd9
      4d4a549d
    • Christopher Dykes's avatar
      Rename FOLLY_A64 to FOLLY_AARCH64 · aa86aa27
      Christopher Dykes authored
      Summary:
      `FOLLY_AARCH64` is more descriptive.
      (searching for A64 tells you nothing, searching for aarch64 tells you a lot)
      
      Reviewed By: yfeldblum, andrewjcg
      
      Differential Revision: D5663075
      
      fbshipit-source-id: 8f31fde4aa394f5452305929541af6d38e4d8a37
      aa86aa27
    • shane's avatar
      update README for ubuntu 16.04 LTS + custom boost installation details · a901072c
      shane authored
      Summary:
      the README didn't have explicit instructions for ubuntu 16.04 LTS...  now it does.
      
      i also added a section for how to handle building folly w/a custom boost installation.
      Closes https://github.com/facebook/folly/pull/664
      
      Reviewed By: eduardo-elizondo
      
      Differential Revision: D5694143
      
      Pulled By: yfeldblum
      
      fbshipit-source-id: e2786d045c3459cac49c8b052d90ca24d10f7922
      a901072c
    • Alison Tsai's avatar
      macro to enable scoped trace section functionality · f74bfffc
      Alison Tsai authored
      Summary: Add a macro to enable optional scoped trace section functionality (user-defined). This macro will have no effect unless configured to do so. This change means that if proxygen is being upgraded, folly must also be updated.
      
      Reviewed By: mzlee
      
      Differential Revision: D5635123
      
      fbshipit-source-id: 7db17f6ae8c0d1484cf9fad043eb42717279bd0a
      f74bfffc
  12. 22 Aug, 2017 1 commit