Summary: `StaticSingletonManager::create<T, Tag>` is larger than necessary, which may not be desirable when using many tags with the same type. Permit call-sites to use static data to shrink the functions.

Reviewed By: aary

Differential Revision: D27863037

fbshipit-source-id: 9f6ced3e7d7a85b78e671f69d7a475ab4de5eea0

Summary: By suppressing `-Wdeprecated-declarations` v.s. `-Wdeprecated`, which latter works only under clang.

Reviewed By: Orvid

Differential Revision: D27987616

fbshipit-source-id: 4bf2a225a65d8ac7c7555123343e9536759fcfcc

Summary:
Reported by clang-12:
```
folly/test/SynchronizedTestLib-inl.h:587:7: error: expression result unused [-Werror,-Wunused-value]
      SYNCHRONIZED_DUAL(lv, v, lm, m) {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
folly/Synchronized.h:1819:5: note: expanded from macro 'SYNCHRONIZED_DUAL'
    ::folly::detail::SYNCHRONIZED_macro_is_deprecated{};                       \
    ^                                                ~~
```

Reviewed By: chadaustin

Differential Revision: D27954777

fbshipit-source-id: bd1dba5ebf563b34b496457b980568ea1c978442

Reviewed By: Orvid

Differential Revision: D27559485

fbshipit-source-id: be2db59ef6d9b4cf178216a4b8851e27e7ecef93

Summary: The facility was renamed in gtest.

Reviewed By: praihan

Differential Revision: D27985919

fbshipit-source-id: d35795d7bfb985767b5e6c28141dac47a4b9f0ce

Summary: No risk of mismatched types.

Reviewed By: vitaut

Differential Revision: D27933275

fbshipit-source-id: 41bf921748299ead7388bb0dc4197eb4390aa007

Summary: To avoid the extra and unusual dependency in this particular case.

Differential Revision: D27933052

fbshipit-source-id: aeda0b7b5916c3fe05581f9880472d194412c461

Summary: The release order is not valid for compare-exchange-failure-load.

Reviewed By: magedm

Differential Revision: D27932613

fbshipit-source-id: 689929ecdef8feaec268dc2cd350ce001103ee75

Summary: Prefer not to have polyfills. The class `NativeSemaphore` replaces this polyfill.

Reviewed By: Orvid

Differential Revision: D27971239

fbshipit-source-id: 39bd8b2d9be895a947faee4d522420535378fdc3

Summary: Rename ForbidTag to TrackTag as a counter to PermitTag. ForbidTag did not capture the idea that in practice we simply log blocking operations. TrackTag allows for that and opens scope for a more aggressive form of tracking on top.

Reviewed By: andriigrynenko

Differential Revision: D27914911

fbshipit-source-id: d56132b7e389825167503934b7af08f9a3ccf1fe

Summary:
Thread 1:
  - Creates an eventfd X
  - Registers X with an event base
  - Closes X
  - Unregisters X from the event base

Thread 2:
  - Creates some other file descriptor (eventfd or socket or whatever); the operating system reuses file descriptor #X.

The unregistering of X from the event base in thread 1 races with the opening of reused X in thread 2.

The fix is to unregister X before closing X.

Reviewed By: yfeldblum

Differential Revision: D27962155

fbshipit-source-id: 1bcb62c7ebe0297ab9687e1a0edf37d319637fda

Summary: Replace the uses of `FOLLY_CL_USE_FOLLY_TLS` in some cases with C++ checks on `kIsMobile`.

Differential Revision: D27669672

fbshipit-source-id: 79a29896653f2fa62b10b488220d8cf83cba3d00

Summary: To use `std::atomic`, we need `#include <atomic>`.

Reviewed By: Mizuchi

Differential Revision: D27932606

fbshipit-source-id: 8d29a56a75b27ae35bac37b87a7e6d6d1661030e

Summary: The facility was renamed in gtest.

Reviewed By: praihan

Differential Revision: D27904281

fbshipit-source-id: 3f00b4371e17cd85672ad7ef706cea4ca1ba5c64

Summary: On apple platforms, posix sem is deprecated. On windows, it does not exist. So switch to the native-semaphore wrapper.

Reviewed By: chadaustin

Differential Revision: D27903002

fbshipit-source-id: d53c7762fea3123cf67cda48fdd87489a0ee496c

Summary:
A semaphore type which wraps the platform native semaphore type.

On Windows, this is the Windows semaphore type. On Apple, this is the semaphore type from libdispatch. Otherwise, this is the POSIX semaphore type, which is deprecated on Apple and unavailable on Windows.

Reviewed By: Orvid

Differential Revision: D27951114

fbshipit-source-id: e6a870f656eecd3ba41c2efed038b916c124d0e8

Summary:
The migration to tpx broke Watchman's tests because test_bser relies on YARN_YARN_OFFLINE_MIRROR being set in the environment and tpx doesn't forward environment variables into the test.

Explicitly forward them ourselves.

Reviewed By: fanzeyi

Differential Revision: D27897172

fbshipit-source-id: 16c8017a89979802bd9d443825ed4e22cb6ff6c9

Summary:
This diff enables a symmetrical pattern to `makeGuard()`/`dismiss()`: `makeDismissedGuard()` will create a guard that will not execute unless `rehired()`'d.

This is for use cases where the guard's scope is wider than where the condition on whether it should execute is evaluated. For example
```
State state;
auto guard = makeDismissedGuard([&] { cleanup(state); });
if (modifyStateInAWayThatRequiresCleanup(state)) {
  guard.rehire();
}
// Use state.
```

Reviewed By: yfeldblum

Differential Revision: D27931274

fbshipit-source-id: fbf7048dc991b73553cd6429f5e73345e4104d49

Summary:
Permit calls of the form:

```lang=c++
FOLLY_SAFE_DCHECK(expr);
```

Reviewed By: ot

Differential Revision: D27843903

fbshipit-source-id: 23869720822fcdba0845c42279855b101c8e2b36

Reviewed By: praihan

Differential Revision: D27800735

fbshipit-source-id: 26f2c1be72bb66864173beb87244129dd6194c8d

Summary: It is possible to have concurrent calls to `SingletonVault::setType` and `SingletonHolder::createInstance`. In which cases, non-atomic accesses to `SingletonVault::type_` race.

Differential Revision: D27904167

fbshipit-source-id: be01ee375d37839629b2e1d64bec99e32cd7e213

Summary:
Add a benchmark for `rcu_retire`. Remove perf code from the rcu tests.

As a motivating side-effect, removes faulty calls to `printf` which fail to compile across platforms, including mac.

Differential Revision: D27902852

fbshipit-source-id: 1698a0fd8ca3731f0b794cb1c2cb08c4bfb5d714

Summary:
Using `extern template struct` can be tricky - best to avoid.

Use static storage but no longer use static initialization to avoid all issues surrounding ODR, global initializers, etc. Microbenchmarks show no significant hit.

Add a global constructor to continue triggering initialization at static initialization time.

Differential Revision: D27746718

fbshipit-source-id: c5288c33412a80bb813c8d615794b9773cef323c

Differential Revision: D27859994

fbshipit-source-id: afde93e853a08a3d65f3d817cd2bbad337bfbfce

Summary:
To encourage migration to safer executors, add transitional *Unsafe names for the old, mutable, global executors. This is consistent with the use of *Unsafe elsewhere in the async framework.

(Note: this ignores all push blocking failures!)

Reviewed By: yfeldblum

Differential Revision: D26418111

fbshipit-source-id: 414ee238ed4ae43619ce8d671fa5725f0679f67e

Summary:
It looks like the various CMAKE_CXX_FLAGS_* are simply ineffective, and I'm not
sure why, setting CMAKE_CXX_FLAGS does work though, and CMake appears to add
some release/debug flags to it when generating Ninja files.

Reviewed By: fanzeyi

Differential Revision: D27862117

fbshipit-source-id: a89f6182b5bae9a087f8fcfd4c5f9526f91e2adf

Summary: Avoid calling arbitrary user code from within the scope of framework `catch` blocks. Instead, get the current exception in the catch block, save it, and call the user code after.

Differential Revision: D27842318

fbshipit-source-id: de3ebabc5c08332701a619a93b6e01bfccc0ea71

Summary:
Storing the `__PRETTY_FUNCTION__` for logging has an unreasonable cost on (non-strippable) binary size for debug builds, as different template instantiation will produce long, demangled, and non-mergeable strings.

If necessary, all the information is retrievable from the debug info (even if the function is inlined), where it's stored in much more efficient form. So, switch to `__func__`, which is stripped.

Reviewed By: yfeldblum, luciang

Differential Revision: D27825136

fbshipit-source-id: d499084c7e7b24db1cd46aa2b03f4a590c6eddc3

Summary: Doing so is a bug that can take some time to pin down. Fail at the callsite instead to make this easier.

Reviewed By: yfeldblum

Differential Revision: D27829947

fbshipit-source-id: e3628331ffb687718309e130e8e0f2f78c4eb1aa

Summary:
Add support for AsyncSocket connect bind to device

(Note: this ignores all push blocking failures!)

Reviewed By: danobi

Differential Revision: D27784176

fbshipit-source-id: d7efe3ef59b26aa69552d5f8109f89457ee5fe66

Summary: To avoid the marginal but still unnecessary compile-time cost of constructing a lambda. And enclose the full thing in braces so it can be used in an unbraced `if`.

Reviewed By: ot, luciang

Differential Revision: D27817005

fbshipit-source-id: 9a1a6e0389fea5907a3a20cffbd6a029b0a85eb9

Reviewed By: Mizuchi

Differential Revision: D27669414

fbshipit-source-id: 617e0b5f17fa8ce5505f7f16b00516ba7f21b064

Summary: Why is unsafeGetUnlocked() used here? It seems obviously not safe when we're iterating on the vector after. Am I missing something?

Reviewed By: andriigrynenko

Differential Revision: D27748519

fbshipit-source-id: fe8a78408fdf59e83f5261740e4703f876ad9f9d

Summary: Avoid enlarging data sections. The use of `static` causes data sections to be smaller in certain critical cases.

Reviewed By: cmds, luciang

Differential Revision: D27813138

fbshipit-source-id: 020b14927be5ac035d5f66e7cd652a58f8f820d0

Summary:
Add support for AsyncSocket readv operations

(Note: this ignores all push blocking failures!)

Reviewed By: danobi

Differential Revision: D27585275

fbshipit-source-id: d9a410a4c5d60af06c187e0abb5bd11b7054a6b9

Summary: Should address various build issues.

Reviewed By: Orvid

Differential Revision: D27699043

fbshipit-source-id: 7bcb827c3372e6243554e8bf04426c041b2c62a4

Summary:
It's not safe to expect that the executor is alive after a task is added to the queue (this task could be holding the last KeepAlive and when finished - it may unblock the executor shutdown).
The fix is to hold a KeepAlive if some operation has to be done after adding to the queue. However it's safe to avoid this in a case where executor thread count will never drop below 1 (otherwise not having active threads may result in a deadlock) and we already have the maximum number of threads running. This optimization should help avoid grabbing the KeepAlive on the fast path.

The difference from the previous implementation is that we still start with 0 threads. But keep minThreads at at least 1.

Differential Revision: D27751098

fbshipit-source-id: 7b992a73b40984376893c1fe2a4a072002f0a12a

Summary: To differentiate serialization and deserialization errors.

Reviewed By: yfeldblum

Differential Revision: D27743086

fbshipit-source-id: 8eb4fe1a1733e3effd0aa0478f59160381738db2

Summary:
The build was failing at link time with the claim that `__PRETTY_FUNCTION__` was in a discarded section. This occurs only under some versions of gcc with asan enabled.

This approach works by making a copy of `__PRETTY_FUNCTION__` without ever taking a reference to it.

This may not be the ideal fix, but it is the first one that worked upon experimentation.

Differential Revision: D27786615

fbshipit-source-id: 2845c85bdc8158d4b2da7cd200ce55f982285a21

Summary: Since `[[gnu::weakref]]` can be used effectively in cases where `[[gnu::weak]]` cannot.

Reviewed By: Orvid

Differential Revision: D27672340

fbshipit-source-id: 4882f0176726aece411359c25411f0f4be7fc59f