1. 29 Dec, 2020 2 commits
  2. 28 Dec, 2020 3 commits
    • Yedidya Feldblum's avatar
      let AsyncPipe::create return the correct type · a1251f06
      Yedidya Feldblum authored
      Summary: Let `AsyncPipe::create` return the correct pipe type, namely, the type on which it is a member rather than a different instantiation of the template.
      
      Reviewed By: iahs
      
      Differential Revision: D25717180
      
      fbshipit-source-id: 94a5a657e83b5d4cac866277ec5925c0b5b0af28
      a1251f06
    • Orvid King's avatar
      Include <optional> where required · 33df23f4
      Orvid King authored
      Summary: Using std::optional requires including it first.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25704383
      
      fbshipit-source-id: 755dfd4a6dec9695cb0ed156166d13b550fd8b40
      33df23f4
    • Lewis Baker's avatar
      Add co_current_async_stack_trace awaitable · 184d54bb
      Lewis Baker authored
      Summary:
      Adds a new awaitable that extracs the current async stack-trace as a vector
      of program counters from within the current coroutine.
      
      Usage:
      ```
      std::vector<std::uintptr_t> programCounters =
        co_await folly::coro::co_current_async_stack_trace;
      ```
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D21130683
      
      fbshipit-source-id: bf67a9969f73bdb8b91b4cc2858883b8e87762e2
      184d54bb
  3. 27 Dec, 2020 1 commit
    • Efrat Lewis's avatar
      AsyncSocket facility to read ancillary data · 7a2b83b4
      Efrat Lewis authored
      Summary: Defined new callback - ReadAncillaryDataCallback, which enables getting ancillary data when receive a message using recvmsg API.
      
      Reviewed By: cgrushko
      
      Differential Revision: D24246707
      
      fbshipit-source-id: 3363b5fafe8d370cf5560afe00476fc8ea723e7a
      7a2b83b4
  4. 26 Dec, 2020 1 commit
  5. 25 Dec, 2020 3 commits
  6. 24 Dec, 2020 1 commit
    • Dan Melnic's avatar
      Fix gso typo · d99290f5
      Dan Melnic authored
      Summary:
      Fix gso typo
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: kevin-vigor
      
      Differential Revision: D25699054
      
      fbshipit-source-id: bac1a7a5c13efa5a58ecec11edf72c500b0783b5
      d99290f5
  7. 23 Dec, 2020 3 commits
    • Yedidya Feldblum's avatar
      add co_cancelled · 0c47744a
      Yedidya Feldblum authored
      Summary: [folly] Add `co_cancelled`, effectively a shorthand for `co_error(OperationCancelled{})`.
      
      Reviewed By: Mizuchi, lewissbaker
      
      Differential Revision: D25627993
      
      fbshipit-source-id: 91f80772a8b179a4de0fe3b29dfe7eecaafb8e1b
      0c47744a
    • Dan Melnic's avatar
      Fix nullptr dereference · 590d4349
      Dan Melnic authored
      Summary: Fix nullptr dereference
      
      Reviewed By: kevin-vigor
      
      Differential Revision: D25687105
      
      fbshipit-source-id: 59b0f3e4adc810f6e1a89447667cd167c52f7fb5
      590d4349
    • Andrii Grynenko's avatar
      Replace after-fork-use DFATAL with ERROR · 69bbfc4b
      Andrii Grynenko authored
      Differential Revision: D25683616
      
      fbshipit-source-id: 7f199b0e43e0a5a76c4cf16412b22abdc28833ac
      69bbfc4b
  8. 22 Dec, 2020 4 commits
    • Yedidya Feldblum's avatar
      fix Arena bytes-used accounting across merge · e124ab8e
      Yedidya Feldblum authored
      Summary: Fix `Arena` bytes-used accounting across calls to member `merge`.
      
      Reviewed By: luciang
      
      Differential Revision: D25656949
      
      fbshipit-source-id: b230b0cdbf51b146fd566cbf688f49817bdf874d
      e124ab8e
    • Yedidya Feldblum's avatar
      rename coro Error.h to Result.h · 37f3868a
      Yedidya Feldblum authored
      Summary: [folly] Rename coro `Error.h` to `Result.h` since it has multiple result types.
      
      Reviewed By: Mizuchi
      
      Differential Revision: D25625178
      
      fbshipit-source-id: 45f8194922b764429969329563a4695b1c13da6f
      37f3868a
    • Yedidya Feldblum's avatar
      fix Arena bytes-used accounting across clear · 4c2177f5
      Yedidya Feldblum authored
      Summary: Fix `Arena` bytes-used accounting across calls to member `clear` after a sequence of all-large allocations.
      
      Reviewed By: luciang
      
      Differential Revision: D25656875
      
      fbshipit-source-id: e79aca5f58b61bf1bd4790f8badd0dad6063a6ed
      4c2177f5
    • Andrii Grynenko's avatar
      Detect singletons that are created in parent process and used in child process · c55c0192
      Andrii Grynenko authored
      Summary: folly::Singleton is used for singletons that manage resources (thread, fds etc.) and it's generally not safe to use previously created folly::Singletons in child process after fork.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25292667
      
      fbshipit-source-id: 5343d26c72bb9203429a918a3bb5d458c44e9f3b
      c55c0192
  9. 21 Dec, 2020 5 commits
    • Arthur Kushka's avatar
      Forced watchman daemon to always operate in non elevated mode on Windows (#878) · e45e8964
      Arthur Kushka authored
      Summary:
      Recently I found that its impossible to access elevated Watchman daemon from non-elevated process on Windows.
      
      ```
      events.js:174
            throw er; // Unhandled 'error' event
            ^
      Error: connect EPERM \\.\pipe\watchman
          at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1106:14)
      Emitted 'error' event at:
          at Socket.<anonymous> (C:\open\ovrsource\unity\socialvr\_js\node_modules\fb-watchman\index.js:118:12)
          at Socket.emit (events.js:198:13)
          at emitErrorNT (internal/streams/destroy.js:91:8)
          at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
          at process._tickCallback (internal/process/next_tick.js:63:19)
      ```
      
      To fix this, it was suggested by wez to use [his library](https://github.com/wez/EleDo) to force Watchman daemon always start in normal mode on Windows. In this stack of commits I did integrated his library into project and used it to force daemon restart in normal mode when spawned from elevated terminal.
      
      To make it happen, I checked-in library sources and created proxy project which depends on the initial library and contains header bindings and cmake configuration. I did copy pasted Rust cmake macroses from another facebook project - eden, and also created analogue of autogen.sh but for Windows - autogen.cmd.
      
      Pull Request resolved: https://github.com/facebook/watchman/pull/878
      
      Test Plan:
      Launch elevated terminal
      Start watchman.exe produced from sources
      Observe daemon starting and answering
      In process monitor, observe watchman.exe process running under user group
      
      Reviewed By: fanzeyi
      
      Differential Revision: D25595879
      
      Pulled By: arhelmus
      
      fbshipit-source-id: 15eb29adcf5bd4a5708b6533a1b2bacbf13f431c
      e45e8964
    • Yedidya Feldblum's avatar
      Cut FOLLY_HAVE_MEMRCHR · ea0cdfe1
      Yedidya Feldblum authored
      Summary: [Folly] Cut `FOLLY_HAVE_MEMRCHR` since it is now unused.
      
      Reviewed By: Orvid
      
      Differential Revision: D22130149
      
      fbshipit-source-id: b10c5a52354f5c549d96b54e0c165f08b96612b1
      ea0cdfe1
    • Pranjal Raihan's avatar
      Remove folly::observer::waitForAllUpdates · 79dc5c64
      Pranjal Raihan authored
      Summary: Since this API is discouraged from use, users should call `folly::observer_detail::ObserverManager::waitForAllUpdates` (and face whatever consequences may come with it).
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25629064
      
      fbshipit-source-id: 141b27bbc4f7cf9b628f15f837c38dd4d8a04f31
      79dc5c64
    • generatedunixname89002005325676's avatar
      Daily `arc lint --take CLANGFORMAT` · 9cc99a5c
      generatedunixname89002005325676 authored
      Reviewed By: zertosh
      
      Differential Revision: D25662961
      
      fbshipit-source-id: f5811a5797fd6dc8733fdf86f35c93d12a08d53a
      9cc99a5c
    • Yedidya Feldblum's avatar
      fix Arena total-size accounting across clear · 78fe8913
      Yedidya Feldblum authored
      Summary: Fix `Arena` total-size accounting across calls to `clear`, as reported by member `totalSize`.
      
      Reviewed By: luciang
      
      Differential Revision: D25656867
      
      fbshipit-source-id: b5c7bb0e95199a9fa2c94c04de65b8f494eef146
      78fe8913
  10. 20 Dec, 2020 3 commits
    • Orvid King's avatar
      Use portability/GTest.h · 2d871f2f
      Orvid King authored
      Summary: Don't use gtest/gtest.h directly.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25659806
      
      fbshipit-source-id: a8dd0da814465a787ab7904bdd0256f22b6e3ed8
      2d871f2f
    • Orvid King's avatar
      Match DoubleRadixSort test name to file name · e4eb39f3
      Orvid King authored
      Summary: As per title
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25636982
      
      fbshipit-source-id: a59c2325558175e122941000ab645c8735a3a425
      e4eb39f3
    • Yedidya Feldblum's avatar
      use throw_exception in Arena · bc8c42bb
      Yedidya Feldblum authored
      Summary: Use `throw_exception` consistently in `Arena` for consistency.
      
      Differential Revision: D25637401
      
      fbshipit-source-id: 92cda5acc09b871fed78044fa3f3fa2c41b01609
      bc8c42bb
  11. 19 Dec, 2020 6 commits
    • Yedidya Feldblum's avatar
      asan_region_is_poisoned · e6955f4d
      Yedidya Feldblum authored
      Summary: [folly] `asan_region_is_poisoned` to wrap Address Sanitizer's `__asan_region_is_poisoned`.
      
      Reviewed By: ot, luciang, markisaa
      
      Differential Revision: D25651040
      
      fbshipit-source-id: 0c8f1d0203ada43746b5e2e71c1bd8b883248f68
      e6955f4d
    • Alfred Fuller's avatar
      Fix include order and grouping in folly - 7/13 · 59fe375d
      Alfred Fuller authored
      Summary: All changes were automated
      
      Reviewed By: Orvid
      
      Differential Revision: D25507555
      
      fbshipit-source-id: c0be9a04b8a5f502f4753ce6e163a78c428bfad6
      59fe375d
    • Dan Melnic's avatar
      Fix QUIC OSS build · 4cc7f892
      Dan Melnic authored
      Summary:
      Fix QUIC OSS build
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: danobi
      
      Differential Revision: D25645282
      
      fbshipit-source-id: fcb71d4e930d7ac3802f31d71599338fb346eb80
      4cc7f892
    • Orvid King's avatar
      Include portability/SysTypes.h for ssize_t · e01b9f04
      Orvid King authored
      Summary: Required for Windows with the more strict include order via upcoming formatting diffs.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25636437
      
      fbshipit-source-id: 0a5fd400f63220400f89affb11b66e9692e9b352
      e01b9f04
    • Orvid King's avatar
      Remove dependence on common for a test · 47de1a56
      Orvid King authored
      Summary: Because folly can't depend on common.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25636772
      
      fbshipit-source-id: d7b049330c9ca68eb4013fde5ca6de9413433823
      47de1a56
    • Misha Shneerson's avatar
      Fix race conditions on shutdown of MeteredExecutor · d7c40bc1
      Misha Shneerson authored
      Summary: Allow scheduling a "poison" task to indicate shutdown
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D25609015
      
      fbshipit-source-id: 8a42b99b402d78db7cfa3bd194730bb6948567c6
      d7c40bc1
  12. 18 Dec, 2020 7 commits
    • Andrew Huang's avatar
      Add opt-out switch for TLS 1.3 in SSLContext · ed4b5a77
      Andrew Huang authored
      Summary: Currently doesn't do anything since TLS 1.3 is not yet enabled by default. Once it is, calling disableTLS13() on a context will set the max TLS version to TLS 1.2.
      
      Reviewed By: mingtaoy
      
      Differential Revision: D25642589
      
      fbshipit-source-id: 0e580916b929111ed9721ca142b59eab0ea187df
      ed4b5a77
    • Shai Szulanski's avatar
      Template get_optional on Optional type · 20f47e6c
      Shai Szulanski authored
      Summary: Allows use with std::optional when available
      
      Reviewed By: WillerZ
      
      Differential Revision: D25618828
      
      fbshipit-source-id: 3e039406ff1e885fd1767148b907635b23f7a88b
      20f47e6c
    • Yedidya Feldblum's avatar
      use comparison expectations in Arena test · 2a41f3f0
      Yedidya Feldblum authored
      Summary: Use comparison expectations like `EXPECT_GE` in `Arena` test as v.s. `EXPECT_TRUE` with the comparison inside.
      
      Reviewed By: markisaa
      
      Differential Revision: D25631097
      
      fbshipit-source-id: 4fb430f34d7683e3b82dd3fbb4408360f8990353
      2a41f3f0
    • Alfred Fuller's avatar
      Fix include order and grouping in folly - 10/13 · 376557bb
      Alfred Fuller authored
      Summary: All changes were automated
      
      Reviewed By: Orvid
      
      Differential Revision: D25507575
      
      fbshipit-source-id: cbddef5a79008d9bf8b6e0234e6433084e5d8df9
      376557bb
    • Orvid King's avatar
      Remove vim edit modes from the 4 files that have them · 5a51004b
      Orvid King authored
      Summary: These are the only files out of hundreds in folly that have them, so just remove them entirely.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25612198
      
      fbshipit-source-id: 88d4f5c2ffa08d45d0a901c9ef874cddc2730291
      5a51004b
    • Maged Michael's avatar
      hazptr: Reduce noisy logging · f8dbfec6
      Maged Michael authored
      Summary: Eliminate noisy log message and provide the intended deadlock clue in a function name.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25627130
      
      fbshipit-source-id: 8d92007d4fa7eff1efb5857f7f49bebde2d59b70
      f8dbfec6
    • Orvid King's avatar
      Rename a couple of tests for consistency · 8b6ee86f
      Orvid King authored
      Summary: Specifically, ending in Test, singular, and reflecting the file being tested in full.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D25612187
      
      fbshipit-source-id: 514477e08b9e231d8574cae19640717b689b7d56
      8b6ee86f
  13. 17 Dec, 2020 1 commit