- 15 Aug, 2016 5 commits
-
-
Eric Niebler authored
Summary: This change adds a non-throwing interface for folly::to<T>: tryTo<T>, which returns an Expected<T, ConversionCode>. Here is how the non-throwing interface compares to the regular interface in terms of performance. On the successful path, there's generally not much difference between using the throwing and non-throwing interfaces. For the error path, tryTo<> is about three orders of magnitude faster than to<>. Reviewed By: mhx Differential Revision: D3557832 fbshipit-source-id: 21f06b3c1a72b06dcf867ed3a3410f51e0fdaf45
-
Eric Niebler authored
Summary: This change adds a non-throwing interface for folly::to<T>: tryTo<T>, which returns an Expected<T, ConversionCode>. Here is how the non-throwing interface compares to the regular interface in terms of performance. On the successful path, there's generally not much difference between using the throwing and non-throwing interfaces. For the error path, tryTo<> is about three orders of magnitude faster than to<>. Reviewed By: mhx Differential Revision: D3557832 fbshipit-source-id: 25b29834b6fda474a7cdd43a7dea69ff4ee183c8
-
Alex Orlov authored
Summary: instead fetch it only on exception Reviewed By: andriigrynenko Differential Revision: D3718303 fbshipit-source-id: a021d150f20ab00fe8146f17b19a69fa0da2b0da
-
Christopher Dykes authored
Summary: This is a workaround to an (already reported) bug in MSVC that results in it not considering the constructors of `dynamic` when attempting to construct the default value of a parameter if the type of the parameter is a universal reference. It works by simply adding a pair of template specializations that cause MSVC to properly construct the default value. This also removes the default value on the universal reference version, as the only things that should be using that overload now are non-dynamic values. Reviewed By: yfeldblum Differential Revision: D3704990 fbshipit-source-id: 7b85c4e48a1a1023bc2fe0a76a9632b11c4e9364
-
Eric Niebler authored
Summary: Expected is like an Optional with extra state for reporting //why// the Expected is empty. Something like it is currently under review for inclusion in the C++ standard [1], and Andrei Alexandrescu has spoken about it [2]. It corresponds to the Either Monad in Haskell, where it is used as a return type of an API that has more than one failure mode. By adding folly::Expected, we get a way to implement non-throwing APIs with a consistent and composable interface. [^1]: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4015.pdf [^2]: https://channel9.msdn.com/Shows/Going+Deep/C-and-Beyond-2012-Andrei-Alexandrescu-Systematic-Error-Handling-in-C Reviewed By: mhx Differential Revision: D3522501 fbshipit-source-id: 48b8ea2dfbd0769f26ec84d2d52fd41db75dc05a
-
- 14 Aug, 2016 1 commit
-
-
Sven Over authored
Summary: ApplyTupleTest.cpp was never added to Makefile.am. This commit fixes that. Reviewed By: yfeldblum Differential Revision: D3715213 fbshipit-source-id: e1e914438d44affb6fe683614506338c3a3355c6
-
- 13 Aug, 2016 1 commit
-
-
Guobao Sun authored
Summary: Found this nit while trying to understand how fbvector works. 1) grwoing -> growing 2) remove that unnecessary "and" Not sure about reviewers' choosing so I included the author and whoever phabricator suggested to me. Reviewed By: meyering, yfeldblum Differential Revision: D3714166 fbshipit-source-id: 8bf575c3f2954feb9e92611acd0aa23c5eee9a0a
-
- 12 Aug, 2016 4 commits
-
-
Christopher Dykes authored
Summary: Because it's a terrible idea. It also didn't work. Reviewed By: yfeldblum Differential Revision: D3711443 fbshipit-source-id: 48ab77dfff005347c72daeaf0d27390bb86f4bd1
-
Sven Over authored
Summary: folly::NotificationQueue::tryConsume did not compile for move-only types such as folly::Function. This diff fixes that. Reviewed By: andriigrynenko Differential Revision: D3711406 fbshipit-source-id: a52eba3eb31743165e4726f830f2a38d241f25a5
-
Sven Over authored
Summary: A bunch of small changes that are necessary before we change the definition of folly::Func from std::function<void()> to folly::Function<void()>. Reviewed By: yfeldblum, mzlee Differential Revision: D3706210 fbshipit-source-id: 198d8a391ef6f545ad4411d316ba9e271ea795e3
-
Giuseppe Ottaviano authored
Summary: Changes discussed on the initial MicroLock diff, but that were accidentally lost before commit. Reviewed By: luciang, yfeldblum Differential Revision: D3010789 fbshipit-source-id: 9538ebd1383d1561dd2ce210a2d05e342c6863e6
-
- 11 Aug, 2016 12 commits
-
-
Christopher Dykes authored
Summary: Because it doesn't need to be escaped, and MSVC will warn about invalid escape sequences. If being built with HHVM's settings for MSVC, it's actually an error, as the same warning is produced for multi-byte escape sequences in narrow strings. Reviewed By: yfeldblum Differential Revision: D3704596 fbshipit-source-id: 603e57a35f8b7433d1f6e47f4c2882244536b14f
-
Christopher Dykes authored
Summary: MSVC doesn't currently guarantee left-to-right argument evaluation order for values constructed via braced initializers, and produces a warning if you try to pass an argument with a non-trivial copy constructor by-value in a constructor used by the braced initializer. This prevents the warning by simply accepting a const reference instead. Reviewed By: yfeldblum Differential Revision: D3705073 fbshipit-source-id: 917ec1bb776d6ec4bfefe50907d4c5ac2f2379b1
-
Christopher Dykes authored
Summary: Some shuffling and elmination of other includes exposed the fact that this was calling the cpuid builtins, but hadn't included the header they were defined in. Reviewed By: yfeldblum Differential Revision: D3704321 fbshipit-source-id: 332c2d22714abaa74090abe7e7a5b28aec6b905a
-
Christopher Dykes authored
Summary: Winsock doesn't let you listen to a socket if it hasn't been bound to anything, so bind it to the port first. TestServer was also never closing the file descriptor, causing the socket to leak. Reviewed By: yfeldblum Differential Revision: D3698467 fbshipit-source-id: cca415143009fbee99ebf94d7f46aedc9c59191d
-
Christopher Dykes authored
Summary: Because they aren't currently constexpr under MSVC. Reviewed By: yfeldblum Differential Revision: D3705095 fbshipit-source-id: ea266ebd9677fb2ba232476160f7c10a23954db9
-
Christopher Dykes authored
Summary: Because the tests are explicitly dependent on the size of these types, and `long` is a different size on Windows. Reviewed By: yfeldblum Differential Revision: D3704488 fbshipit-source-id: e15e95242c5e9c84165a50cfd2c3bc6e0d2e0c49
-
Christopher Dykes authored
Summary: `<::` is a trigraph, which, although removed in C++17, MSVC still warns about the sequences (although it doesn't actually intepret them as trigraphs) Reviewed By: yfeldblum Differential Revision: D3704382 fbshipit-source-id: b093f854343db01bc166b1cc44763676fdd97a51
-
Max Wang authored
Summary: Using _r_debug offers a number of benefits: - It allows us to symbolize addresses in data segments like .bss that are marked "[heap]" in /proc/<pid>/maps. - It requires a lot less code. It also fixes a preexisting bug where we would fail to symbolize addresses that fell in any section past the first in any position- independent objects. Since `elfFile->getBaseAddress()` should always return 0 for any PIEs, we wouldn't correctly adjust the address to be ELF-relative when performing symbol lookup. (For the first section, we just used the start of the range we found in /perf/<pid>/maps.) There is a minor downside: - We have to open an ELF header for each object in order to check if a given address is in the range of some segment. Before, we used /proc/<pid>/maps to make the range check, and only opened the header once we knew it was the one we wanted. In the common case, however, where the addresses are from our own executable, we don't open any more files than before (and, in fact, one fewer). Reviewed By: luciang Differential Revision: D3695872 fbshipit-source-id: 9bdcc77da4d658ffad5c671f9b8ea65a471ed64f
-
Yedidya Feldblum authored
Summary: [Folly] Remove `ConditionallyExistent`, because it violates the C++ spec. The spec says that struct and class types occupy at least one byte. But the point of this class is to occupy zero bytes when the condition is false. That can't be made to work. GCC and Clang support an extension allowing, in some cases, structs to occupy no space at all. But it violates the spec, and MSVC does not support the extension. There is, sort of, the possibility of empty-base-class-optimization. But it will be very painful to use, and it will only work in some cases. Since this is broken now, and fixing it would violate the C++ spec and break this under MSVC, it's better just to remove it. Reviewed By: nbronson, Orvid Differential Revision: D3696371 fbshipit-source-id: c475c6e15d9ff1bc4c44dc7e336ce74e6db640ef
-
Sven Over authored
Summary: Instead of passing exactly one tuple of arguments to applyTuple, this diff allows to pass any number (zero or more) of tuples. This can be very handy when piecing together arguments for a function call. Reviewed By: yfeldblum Differential Revision: D3681499 fbshipit-source-id: a75a448636759f71db8d303e9dccada5b559af54
-
Lucian Grijincu authored
__google_stl_debug_vector: erase() at invalid position: folly/experimental/test:future_dag_test - FutureDAGTest.RemoveNodeComplex Summary: ``` [ RUN ] FutureDAGTest.RemoveNodeComplex terminate called after throwing an instance of 'std::out_of_range' what(): erase() at invalid position *** Aborted at 1470867850 (Unix time, try 'date -d 1470867850') *** *** Signal 6 (SIGABRT) (0x133c001ed107) received by PID 2019591 (pthread TID 0x7ff1e6df5980) (linux TID 2019591) (maybe from PID 2019591, UID 4924), stack trace: *** @ 00007ff1e702020f folly::symbolizer::(anonymous namespace)::innerSignalHandler(int, siginfo_t*, void*) @ 00007ff1e701faf1 folly::symbolizer::(anonymous namespace)::signalHandler(int, siginfo_t*, void*) @ 00007ff1e87c714f (unknown) @ 00007ff1e7cf6d02 gsignal @ 00007ff1e7cf8af5 abort @ 00007ff1e73880e4 __gnu_cxx::__verbose_terminate_handler() @ 00007ff1e7385ee5 __cxxabiv1::__terminate(void (*)()) @ 00007ff1e7385f30 std::terminate() @ 00007ff1e73861c0 __cxa_throw @ 00007ff1e740ae00 std::__throw_out_of_range(char const*) @ 00000000004483db std::vector<folly::FutureDAG::Node, std::allocator<folly::FutureDAG::Node> >::_M_erase(__gnu_cxx::__normal_iterator<folly::FutureDAG::Node*, std::vector<folly::FutureDAG::Node, std::allocator<folly::FutureDAG::Node> > >) @ 00000000004478fa std::vector<folly::FutureDAG::Node, std::allocator<folly::FutureDAG::Node> >::erase(__gnu_cxx::__normal_iterator<folly::FutureDAG::Node const*, std::vector<folly::FutureDAG::Node, std::allocator<folly::FutureDAG::Node> > >) @ 000000000044770a folly::FutureDAG::remove(unsigned long) @ 0000000000424bc2 FutureDAGTest::remove(unsigned long) @ 000000000041f7ed FutureDAGTest_RemoveNodeComplex_Test::TestBody() @ 00007ff1e9b19361 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest.cc:2420 -> /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest-all.cc @ 00007ff1e9b029de testing::Test::Run() /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest.cc:2437 -> /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest-all.cc @ 00007ff1e9b02aca testing::TestInfo::Run() /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest.cc:2612 -> /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest-all.cc @ 00007ff1e9b02cfc testing::TestCase::Run() /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest.cc:2730 -> /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest-all.cc @ 00007ff1e9b0d2a7 testing::internal::UnitTestImpl::RunAllTests() /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest.cc:4602 -> /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest-all.cc @ 00007ff1e9b0d60c testing::UnitTest::Run() /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest.cc:2420 -> /home/engshare/third-party2/gtest/1.7.0/src/gtest-1.7.0/src/gtest-all.cc @ 00007ff1eb64ec70 RUN_ALL_TESTS() @ 00007ff1eb64ec3c main @ 00007ff1e7ce10f5 __libc_start_main @ 000000000041f2d2 (unknown) Summary (total time 0.07s): PASS: 0 FAIL: 0 SKIP: 0 FATAL: 1 folly/experimental/test:future_dag_test - FutureDAGTest.RemoveNodeComplex TIMEOUT: 0 ```` Reviewed By: yfeldblum Differential Revision: D3700956 fbshipit-source-id: dffca9460ccca1d8069218c5b7310e4d6e061697
-
Shayan Mohanty authored
Summary: Implements a polymorphic functor for FutureDAGs. In order for FutureDAGs to be stateful they must be wrapped by a class of some sort. This is a really common pattern which we've been using in Gossit (and further - across the RedWood stack) in order to maintain state, and we feel it's generalized enough to be useful elsewhere. `state` is an instance of the type declared in the template, and the exec* methods wrap go().get() so client-side implementations only have to touch the functor after construction in order to drive their DAGs. Reviewed By: tjkswaine Differential Revision: D3685651 fbshipit-source-id: 81169aefcff13ac8cc6cbb6bef6d90047732ad8a
-
- 10 Aug, 2016 11 commits
-
-
Michael Lee authored
Summary: Gate `kIsLinux` to not include `FOLLY_MOBILE` because "mobile" linux does not really behave like real linux. Differential Revision: D3697717 fbshipit-source-id: 1b0f4208d2f71c35399c30f20a71bfa4ba4724e8
-
Dave Watson authored
Summary: Noticed this while debugging other timerwheel changes. Scheduling new events in callbacks may result in us *running them right away* if they land in a bucket we are currently processing. Instead, round up all the timeouts, then run them separately. This means you can never schedule a timeout that will run immediately (0ticks), but that's probably fine. Reviewed By: yfeldblum Differential Revision: D3679413 fbshipit-source-id: 7e18632f23ea33c072c2718e30b378641895b094
-
Philip Pronin authored
Summary: Standard (21.4.7.2 / 1): > Determines the lowest position xpos, if possible, such that both of the following conditions obtain: - pos <= xpos and xpos + str.size() <= size(); - traits::eq(at(xpos+I), str.at(I)) for all elements I of the string controlled by str. The existing logic violates the first requirement for `str.size() == 0` by unconditionally returning `pos`. Reviewed By: ot, Gownta Differential Revision: D3698862 fbshipit-source-id: 9622f1b99b259d2d81ae83795dff9cd94619c725
-
Christopher Dykes authored
Summary: Because, if no inlining is enabled, the absence of this attribute caused compile errors due to functions that were expected to return a value not returning a value. Reviewed By: meyering Differential Revision: D3698413 fbshipit-source-id: 8f3505b17a2fa7b9710e3fb56d18c6ca00feacb3
-
Christopher Dykes authored
Summary: With WinSock, calling `getsockname` on a socket before it's been bound will always result in an error, so make sure to bind the socket first. Reviewed By: yfeldblum Differential Revision: D3698112 fbshipit-source-id: e9efe05323b242add3808ee1a6fec2593beb04ac
-
Christopher Dykes authored
Summary: `/dev/null` doesn't exist on Windows, but thankfully, `NUL` does, and has the same semantics. Reviewed By: meyering Differential Revision: D3698007 fbshipit-source-id: 5ef31c6576f988dd747ea3c39e296c244bc640b7
-
Andrii Grynenko authored
Reviewed By: yfeldblum Differential Revision: D3691541 fbshipit-source-id: 9488c1487ebd0500a23300292215456ca3220f03
-
Andrii Grynenko authored
Summary: Deleter helper object, which may release multiple ReadMostlyMainPtrs at once. This allows underlying ref count implementation to perform expensive synchronization operations (e.g. asymmetric heavy barrier only once). Reviewed By: yfeldblum Differential Revision: D3691524 fbshipit-source-id: 3ac593b0d813345daba3a81ff4e2eb71b4db292e
-
Christopher Dykes authored
Summary: If one of the assertions failed, it would result in any threads that are still running accessing already-disposed data, so wait for the threads to exit, even when an exception is thrown. This also slightly cleans up the handling of threads a bit further down, because the mess it was doing was completely unnecessary. Reviewed By: yfeldblum Differential Revision: D3692438 fbshipit-source-id: 9082ba248b2cf1062e46c97faf0bc062312ee9ae
-
Christopher Dykes authored
Summary: See the comment on `msvcReturnInvalidParams` for more info on the issue. This also adds a use of it to TestUtilTest. Reviewed By: yfeldblum Differential Revision: D3691526 fbshipit-source-id: f0f596e9b4c830e1d31de01926162636757329e8
-
Christopher Dykes authored
Summary: Also switch `pipe` to return a socket pair instead, as libevent can't poll against a pipe on Windows. And lastly, fix the file descriptor for sockets leaking when close is called. Reviewed By: yfeldblum Differential Revision: D3691255 fbshipit-source-id: c684242d255ac5158a4c805d432d345dac1b3bd8
-
- 09 Aug, 2016 6 commits
-
-
Christopher Dykes authored
Summary: Pah! This definitely wasn't causing the lock tests to segfault. Nope, not at all <_>. Reviewed By: yfeldblum Differential Revision: D3691120 fbshipit-source-id: 6601db637f22c7b0bc326907a2a7976f6df7c159
-
Christopher Dykes authored
Summary: Also handle invalid file descriptors correctly and switch away from `WSASendMsg` for the implementation of `sendmsg` due to limitations imposed by WinSock. This also fixes up a few places that were explicitly referencing the global version of some socket functions, which was bypassing the socket portability layer. Reviewed By: yfeldblum Differential Revision: D3692358 fbshipit-source-id: 05f394dcc9bac0591df7581345071ba2501b7695
-
Christopher Dykes authored
Summary: Just calling `SetEnvironmentVariableA` wasn't updating `_environ`, which meant that calls to `getenv` weren't reflecting the changes made via `setenv`. The correct way to implement it is using `_putenv_s`, but there's one problem with that: passing an empty string as the value to `_putenv_s` results in the environment variable being unset. To make it possible to set the environment variable to an empty string, we shall dive head-first into the implementation details of the CRT and emerge victorious by blatently ignoring the documentation of `getenv` and modifying the string it returns to terminate it early. Reviewed By: yfeldblum Differential Revision: D3691007 fbshipit-source-id: 350c2ec72ec90b9178a9a45b2c2ed2659b788e37
-
Christopher Dykes authored
Summary: Windows is weird and calls it USERNAME instead, so just use one that everything agrees on: PATH Reviewed By: yfeldblum Differential Revision: D3691072 fbshipit-source-id: 579c6484736ef47e130049c29bef8b59c66a4482
-
Christopher Dykes authored
Summary: Because the comment was a lie; sockets are blocking by default, not non-blocking. Reviewed By: yfeldblum Differential Revision: D3691145 fbshipit-source-id: 5d3c62b3573205fe416d77fe4b5b9fbd593ffd93
-
Subodh Iyengar authored
Summary: The getTFOsucceeded doesn't really work right now as intended. Currently we check right after sendmsg, however we can only know whether or not the server has acked the data after 1-RTT. This removes getTFOSucceeded. Will fix in another diff. Differential Revision: D3679235 fbshipit-source-id: 6b2bb01d3743ea7e68ad3cc9a26be6806f17ffbe
-