Summary: Trivial change to remove comments that were initially accurate but inaccurate once we decided to DCHECK on the executor instead.

Reviewed By: yfeldblum

Differential Revision: D15148289

fbshipit-source-id: 5d0495f4b36db3a0c8610592bc759e121ed1dcff

Summary:
When built as a static library on Win32, `zstd` has an output name like `zstd_static.lib` and `zstd_staticd.lib`:
https://github.com/facebook/zstd/blob/69baaee3e42f90dedea2c946bc19bfeac4e782ee/build/cmake/lib/CMakeLists.txt#L140
So `FindZstd.cmake` should also take this into consideration.
Pull Request resolved: https://github.com/facebook/folly/pull/1120

Reviewed By: yfeldblum

Differential Revision: D15149814

Pulled By: Orvid

fbshipit-source-id: 298809a524468ab5aa68e58f5fef0cbb0f366051

Differential Revision:
D15057633

Original commit changeset: 6ba47a57a78e

fbshipit-source-id: 1ae1384e5e9de3f2e80571b626a41ef6e713b3b2

Summary:
[Folly] Enforce `SingletonThreadLocal` uniqueness also in the case where `FOLLY_TLS` is not defined.

Since the uniqueness check should happen in all scenarios, just move it to a place which is not subject to conditional compilation.

Reviewed By: yfeldblum

Differential Revision: D15142661

fbshipit-source-id: 04dbc7bc775255a010f24c1496552cfc27970e1f

Summary: Another overload that is not really necessary and adds complication. Removing to simplify.

Reviewed By: yfeldblum

Differential Revision: D15110009

fbshipit-source-id: a7a90799ff4d89d45ae82d2e755be5ee3799104c

Summary: This is mainly to workaround bugs triggered by LTO, when stack allocated variables in await_suspend end up on a coroutine frame.

Reviewed By: lewissbaker

Differential Revision: D15143193

fbshipit-source-id: 9553274e2d9c021902d9d19e7ecb2a91a86e787a

Summary:
Disabling the nullptr conversion to non-pointer folly::Optional<T> has
baked long enough. Re-enabled it with the same behavior that
std::optional has.

Reviewed By: yfeldblum

Differential Revision: D15057633

fbshipit-source-id: 6ba47a57a78ec4834ed4ecc8987a7c8870102ae4

Summary: Another overload that is not really necessary and adds complication. Removing to simplify.

Reviewed By: yfeldblum

Differential Revision: D15109455

fbshipit-source-id: 4312aab817d9796358e0b659c50c6e8f9d9ccb4e

Summary:
after discussion with Lewis, change the contract for empty and error signals from the underlying executor in the strand implementation.

error will forward the error to items in the queue and then reschedule for any remaining items

done will forward the empty signal to items in the queue and then reschedule for any remaining items.

These changes should prevent infinite scheduling loops and allow the underlying executor to push back against the items being submitted to the strand.

Reviewed By: lewissbaker

Differential Revision: D14955343

fbshipit-source-id: 926109594d7aed1766d868b705c84a6ed664e2f3

Summary: Adds a SemiFuture variant of collectAny and forwards collectAny to it. This ensures that both options are available.

Reviewed By: yfeldblum

Differential Revision: D15111077

fbshipit-source-id: f4d6efc684ca632b71f7a8d2659ca4d968d15b6f

Summary: Make sure the future object doesn't get destroyed concurrently with the setCallback_ call.

Reviewed By: yfeldblum

Differential Revision: D15122238

fbshipit-source-id: c8de1cd158f317c3ed7591460ca2cccfa7633ae7

Summary: Allow calling `baton.reset()` concurrently with `co_await`.

Reviewed By: yfeldblum

Differential Revision: D15058504

fbshipit-source-id: af7ff69ddc2c8a4663e0f7ef03121c01502a984d

Summary:
Just a minor typo fix: `Github` -> `GitHub`.
Pull Request resolved: https://github.com/facebook/folly/pull/1119

Differential Revision: D15120076

Pulled By: yfeldblum

fbshipit-source-id: e0caccc022d0d740fd25ad1697b130fe7680f9a3

Summary:
`WriteFlags::EOR` currently marks the end of a record (e.g., an HTTP response) and is used to request ACK timestamping.

`WriteFlags::TIMESTAMP_TX` will be used to request timestamping when the entire write buffer has been transmitted by the NIC. If hardware timestamps are unavailable, then the timestamp will be taken when the the entire buffer has been handed to the NIC by the kernel. TX timestamps can be compared to send() timestamps to determine how long the write buffer was waiting in the kernel to be sent to the NIC. In the case of a large CWND + LOWAT, this could be a significant amount of time. In addition, TX timestamps help with throughput calculations as they enable the precise transmit time to be determined.

We may want to rename `WriteFlags::EOR` or add a separate flag for ACK timestamping. For now, I've clarified the purpose of this field.

Reviewed By: yfeldblum

Differential Revision: D15081941

fbshipit-source-id: 239833cd5a0413e7468840960118a038ffdac068

Summary: It's unsafe to read Executor from Core, because it can be concurrently modified by a consumer thread.

Reviewed By: yfeldblum

Differential Revision: D15117907

fbshipit-source-id: 40caf4b2878609775c1c8476336349ddf3764d4d

Summary:
- `HasArgumentTypes` uses nested `boost::mpl::transform` calls to strip
  reference qualifiers from the function argument types and then another
  `mpl::transform` call to remove `const` qualifiers.
- Replace the nested `mpl::transform` calls to just one call by using
  `folly::remove_cvref`.
Pull Request resolved: https://github.com/facebook/folly/pull/1086

Reviewed By: Orvid

Differential Revision: D14638843

Pulled By: yfeldblum

fbshipit-source-id: 8c360e50ffaba0328aa8e4c86245ce25d45bc01b

Reviewed By: lewissbaker

Differential Revision: D15114457

fbshipit-source-id: 0f49d631bd316fda828946971b607c94ee75250b

Summary:
- `fbstring_core` defines constants based on the host endianness.
- This is purely duplicated as these constants live in `Portability.h`.
  As such, remove them from `fbstring_core` class.
Pull Request resolved: https://github.com/facebook/folly/pull/1117

Reviewed By: Orvid

Differential Revision: D15096910

Pulled By: yfeldblum

fbshipit-source-id: ff4e828dfd1b19daeedf48bbf1719a3fd72c0843

Summary:
- Implement `erase` and `erase_if` for both `FBVector` and
  `small_vector`.
- This matches the APIs as in the C++20 Library Fundamentals v2.
Pull Request resolved: https://github.com/facebook/folly/pull/1089

Reviewed By: Orvid

Differential Revision: D15112753

Pulled By: yfeldblum

fbshipit-source-id: dc93c600fa8e7e8a7ed42d6a6e07439d4fa51204

Summary: as title

Differential Revision: D15115871

fbshipit-source-id: 16eff7f913bdd782192ffc0e06f03f1cf8f48393

Summary:
This change has no effect for normal use of the semaphore.

With try_acquire (previous change), we now allow the callers to pass their own baton.
It's possible that the caller ends up not needing to use the `post`, and simply wants to signal the semaphore. It's basically useful in scenario where the caller wants to wait for the first of multiple events.
Current code would deadlock in this scenario, this fixes it.

Reviewed By: andriigrynenko

Differential Revision: D15090395

fbshipit-source-id: 8e3d73705ef3559717b7335f6a9e9ea8bed1cb17

Summary: This provides an interface for the Semaphore, which allow async waiting for more complex usage on fiber, without the future overhead.

Reviewed By: andriigrynenko

Differential Revision: D15082111

fbshipit-source-id: 76306525509f36867999db459ee0b7c42f416b6c

Summary:
This new test should have been inside the
FOLLY_F14_VECTOR_INTRINSICS_AVAILABLE conditional compilation guard.

Reviewed By: mengz0

Differential Revision: D15114483

fbshipit-source-id: 2931be7d4abf7a4a95827052905bd219c9beff13

Summary: It's unsafe to use Future after setCallback was called (its executor may be moved out), so we have to copy its executor before that.

Reviewed By: yfeldblum

Differential Revision: D15113490

fbshipit-source-id: 2fa9c323ddfe1919b84bbfe05b6c5643d0c65703

Summary: [Folly] Let `RequestContext::setContext` and `RequestContextScopeGuard` members take `shared_ptr<RequestContex>` by reference. Saves a small amount on code size and runtime performance due to code size.

Reviewed By: spalamarchuk

Differential Revision: D15074704

fbshipit-source-id: 20f1149b8c56d6c4375d63fe21560bdda5e5ccae

Summary: [Folly] Cut unused `FutureBase::setContext_` overload taking `shared_ptr<RequestContext>`.

Reviewed By: mhorowitz

Differential Revision: D15073509

fbshipit-source-id: a8a9d37e3420168e63692ba77063452849355361

Summary: [Folly] Pass context by reference in the futures `Core`, saving on code size and a small on runtime performance due to code size.

Reviewed By: Orvid

Differential Revision: D15073282

fbshipit-source-id: 7c55b9f6a55ee7ec22fde6f3ab9da232a8ee006b

Summary: [Folly] Move the context in futures `Core::doCallback` to shrink code size and to improve runtime performance (fewer branches, fewer atomic RMWs, smaller code size).

Reviewed By: andriigrynenko

Differential Revision: D15073122

fbshipit-source-id: f1b5cb01ea9ccaa69ac5b42b01a8ee5fa1badb8a

Summary: [Folly] Cut explicit class template instantiations in futures. May save on code size when some of the given instantiations are not used, or when the given instantiations are used but when some of their members are not used.

Reviewed By: LeeHowes

Differential Revision: D15073879

fbshipit-source-id: c624d7ea1dad66f05a9958239a87737367450753

Summary:
F14NodeMap and F14ValueMap copy construction could fail to copy
the chunk overflow count in a rare case where there is a suffix of chunks
that suffers an overflow, then all of the non-overflowed keys are removed,
then the map is copied. In the copy the remaining overflowed key isn't
find()able, but it is still present on the iteration sequence. This diff
fixes the problem.

Reviewed By: WillerZ, shixiao

Differential Revision: D15105104

fbshipit-source-id: cff2073246bc301054996d4bb7e8baf9ee8c0021

Summary: As part of simplifying and removing ambiguity in the interface this removes the form of then(KeepAlive, member-function-pointer). Removing this directly removes the need to make multiple overloads, and migrating to a cleaner then(KeepAlive,...) form will delegate this to the application of the nested continuation.

Reviewed By: yfeldblum

Differential Revision: D15059814

fbshipit-source-id: 8e4481cc471b4ed2dc578c52e26f2223c2468719

Summary: Add getSecurityProtocol() to MockAsyncSocket

Reviewed By: knekritz

Differential Revision: D15099025

fbshipit-source-id: 98b1337a9016e75eff11f37899180d323b67247c

Summary: zmq4.3 bring up 4 more handshake events, add proper handling in sock monitor

Reviewed By: saifhhasan

Differential Revision: D15058676

fbshipit-source-id: d2553c7e32471a2403857741cbb77a40e50d353e

Summary:
Adds a utility that allows a coroutine to reschedule itself back onto its associated executor.

This allows coroutines to cooperatively schedule themselves.

It also allows a coroutine to force itself to be asynchronous by inserting a `co_await folly::coro::co_schedule;` as the first statement in the coroutine.

Reviewed By: andriigrynenko

Differential Revision: D15076362

fbshipit-source-id: 4a4a2978519e0709d28a3e1aa8745ee30ddc7751

Summary:
:
- Replace a call site in `DynamicParser-inl.h` using `boost::is_member_pointer`
  with the standard library equivalent.
Pull Request resolved: https://github.com/facebook/folly/pull/1085

Reviewed By: meyering

Differential Revision: D14638847

Pulled By: yfeldblum

fbshipit-source-id: 8eb95607dc7134b9bbc6974052094a92623fe776

Summary:
- Defining `FBSTRING_SANITIZE_ADDRESS` is more complicated than it needs
  to be and it is in fact not even needed now.
- Remove separate `FBSTRING_SANITIZE_ADDRESS` symbol and use
  `FOLLY_SANITIZE_ADDRESS` in places which previously used
  `FBSTRING_SANITIZE_ADDRESS`.
Pull Request resolved: https://github.com/facebook/folly/pull/1094

Reviewed By: Orvid

Differential Revision: D14969931

Pulled By: yfeldblum

fbshipit-source-id: 7c1a585180ca99d1e2f616765aa77f45c4426fb8

Summary: Migrate from Folly Format to fmt which provides smaller compile times and per-call binary code size.

Reviewed By: alandau

Differential Revision: D14954926

fbshipit-source-id: 9d2c39e74a5d11e0f90c8ad0d71b79424c56747f

Summary: Remove manual include overrides

Reviewed By: k21

Differential Revision: D15085229

fbshipit-source-id: fbd3c66184a696131c61605eeb0bba119e59af9e

Reviewed By: JunqiWang

Differential Revision: D15073399

fbshipit-source-id: 909fccfaa39da8f718b1195fa09ed2628f073c51

Remove deprecation from then that simply forwards to thenTry. Deprecation was inconsistent with defer.

Summary: Future::then that forwards directly to thenTry is to be left for compatibility with Future::defer and to keep naming simple. This removes the confusing deprecation warning.

Reviewed By: yfeldblum

Differential Revision: D15057215

fbshipit-source-id: 84103e47c958f1db602804f625591ba899e98b23