- 06 Oct, 2020 2 commits
-
-
Xiaoting Tang authored
Summary: Time to update libbpf version (the latest release is now 0.1.1). Reviewed By: udippant Differential Revision: D24063680 fbshipit-source-id: 715ac74e9671f0f8ed5b8fe9174fe4070fc0f991
-
Dan Melnic authored
Summary: Add flags to set the io_uring mlock rlimit Reviewed By: danobi, kevin-vigor Differential Revision: D24063687 fbshipit-source-id: be7cdad10797c087a21370ce42811a9752e4f61a
-
- 05 Oct, 2020 2 commits
-
-
Kevin Vigor authored
Summary: Evidently unlike folly, headers may be present in cmake even if they are excluded from build. Check that we have required headers before including AsyncIO.h or IoUring.h. Differential Revision: D24117788 fbshipit-source-id: fec359c8298a21575a8714dd2abdbd9d4dc3e5c4
-
TJ Yin authored
Reviewed By: jmswen Differential Revision: D24102346 fbshipit-source-id: 9bb59bbce04285f93e9d6bb03e04841eaf10a882
-
- 03 Oct, 2020 1 commit
-
-
Felix Handte authored
Summary: Refactory `throw` -> `throw_exception`; Reviewed By: yfeldblum Differential Revision: D21773804 fbshipit-source-id: fd59f1579a143db385e05c5e3442fedee243d25f
-
- 02 Oct, 2020 4 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Backport more of `is_detected`. Reviewed By: Mizuchi Differential Revision: D23984149 fbshipit-source-id: 1e1ed3b0cf3e54999ac56aae11e7d5f0288cae4e
-
Xiaofei Du authored
Summary: small bug Differential Revision: D24080766 fbshipit-source-id: bb03739014023aa98b55859d433f88149529e5e7
-
Chad Austin authored
Summary: The only thing FOLLY_USE_SYMBOLIZER guards now is whether to install signal handlers, and we can do that on any unix. Reviewed By: yfeldblum, luciang Differential Revision: D23881199 fbshipit-source-id: 45631b59fe5df9656a227b68683f23d4ff65e223
-
Andrew Huang authored
Summary: Add API set (but not get) an OpenSSL session. This is intended to handle the situation where the user already has a TLS1.3 resumable session. For example, this currently occurs when the user obtains a session through wangle's SSLSessionCallbacks. Reviewed By: mingtaoy Differential Revision: D22285536 fbshipit-source-id: 7ad8be501909dbb80ab74624991415e74441ef6e
-
- 01 Oct, 2020 7 commits
-
-
Andrew Huang authored
Summary: See title Reviewed By: yfeldblum Differential Revision: D22046592 fbshipit-source-id: 289828fbecb83e086d75156a8696541dd3f7f194
-
Jon Janzen authored
Summary: This doesn't do anything anymore and is going to be removed in D23993306, let's remove it here first. Reviewed By: yns88 Differential Revision: D23993954 fbshipit-source-id: 4d7dd5f992e34be7a0da16ce7cf59810407649c4
-
Luca Niccolini authored
Summary: hitting https://github.com/google/googletest/issues/1373 Reviewed By: mjoras Differential Revision: D23785392 fbshipit-source-id: 114849ed966fb196bb8392bd71ee3c2972834279
-
Maged Michael authored
Summary: Move the reclamation of tagged objects outside the critical section on the tagged list lock (in asynchronous reclamation of the domain tagged list). Tagged objects are subject to both synchronous and asynchronous reclamation. Each tagged object belongs to a cohort. Currently, asynchronous reclamation of the domain list of tagged objects reclaims tagged objects while holding the lock on the list, so that synchronous reclamation of a cohort's objects does not miss such objects. This diff adds a singly linked list of objects that are safe to reclaim to the cohort structure. Asynchronous reclamation pushes reclaimable tagged objects into the safe lists in their respective cohorts, instead of reclaiming such objects while holding the lock on the list of tagged objects. By pushing objects to their respective cohorts, synchronous reclamation can find not-yet-reclaimed objects in the cohort's own safe list. Reviewed By: davidtgoldblatt Differential Revision: D23973107 fbshipit-source-id: 2a9758cc8b03bb98a45b5579bab2964d9ae3d60c
-
Laurent Stacul authored
Summary: Hello, It seems I did a mistake in PR https://github.com/facebook/folly/issues/1328 CMake find_package directive looks for Find<PackageName>.cmake. There is a mistake in the folly-deps.cmake leading to: CMake Error at CMake/folly-deps.cmake:248 (find_package): No "Findfmt.cmake" found in CMAKE_MODULE_PATH. Pull Request resolved: https://github.com/facebook/folly/pull/1462 Reviewed By: yfeldblum Differential Revision: D24000731 Pulled By: Orvid fbshipit-source-id: 2239750228f134776b57c794d04f65f69a92ed3a
-
Laurent Stacul authored
Summary: Hello, Adding data in those variables can have an impact upon feature detections. For instance, using 'check_cxx_source_compiles' to detect libatomic can fail because the link command uses -rdynamic and the list of shared objects. But as libcrypto needs zlib which is not added in CMAKE_REQUIRED_LIBRARIES, the test will fail, as we can see here (from CMakeError.log, modified for readability): ``` $ g++ -DNDEBUG -O3 -flto -ffat-lto-objects -fuse-linker-plugin -std=gnu++20 -fno-working-directory -ggdb3 -Wno-error=maybe-uninitialized -Wno-error=shadow=compatible-local -Wno-error=array-bounds -Wno-error=stringop-overflow -DFOLLY_CPP_ATOMIC_BUILTIN -std=gnu++20 -DNDEBUG -O3 -Wl,-flto -ffat-lto-objects -fuse-linker-plugin -fno-working-directory -ggdb3 -L /path/to/mylibs -pthread -lgflags -lglog -levent -levent_core -ldouble-conversion -rdynamic CMakeFiles/cmTC_4a1a2.dir/src.cxx.o -o cmTC_4a1a2 /path/to/mylibs/libgflags.so /path/to/mylibs/libssl.so /path/to/mylibs/libcrypto.so -ldl ld: warning: libz.so.1, needed by /path/to/mylibs/libssl.so, not found (try using -rpath or -rpath-link) ld: /path/to/mylibs/libcrypto.so: undefined reference to `deflateInit_' ld: /path/to/mylibs/libcrypto.so: undefined reference to `deflate' ld: /path/to/mylibs/libcrypto.so: undefined reference to `deflateEnd' ld: /path/to/mylibs/libcrypto.so: undefined reference to `inflate' ld: /path/to/mylibs/libcrypto.so: undefined reference to `inflateInit_' ld: /path/to/mylibs/libcrypto.so: undefined reference to `inflateEnd' ld: /path/to/mylibs/libcrypto.so: undefined reference to `zError' ``` I only give the example of the detection of libatomic but this error prevents the probing mechanism from detecting other features like the presence of ASN1_TIME_diff function or elf.h. I propose to avoid setting things in those variables or, if it needs to be modified, clean it up after it was useful. Pull Request resolved: https://github.com/facebook/folly/pull/1463 Reviewed By: yfeldblum Differential Revision: D24000700 Pulled By: Orvid fbshipit-source-id: ace1b5b5dee6362c4a30ab0a986984005e7dc569
-
Dave Marchevsky authored
Summary: This file contains a wrapper that is protected from `basename` fn name collision between `libiberty.h` and `libgen.h` (0fb6287719abb3cf52d7eda457efbe567985d1d4). I ran into this same issue again when trying to use `libiberty`'s `cplus_demangle_v3`, so let's add a similar wrapper for this function. Reviewed By: fjricci Differential Revision: D24008824 fbshipit-source-id: 868e90579f753f0c5b62aaeb27af2ef0a2006155
-
- 30 Sep, 2020 3 commits
-
-
Kevin Vigor authored
Summary: Add SimpleAsyncIO class. This creates an instance of an AsyncIO and manages a completion thread and a pool of ops, so user does not have to worry about any of these details. Differential Revision: D23945993 fbshipit-source-id: 90f9b83ca3447a19e3bc4aaf2a2f196ee4ea614d
-
Genevieve Helsel authored
Summary: If retries is 0, then `0 < 0` is false, meaning we will skip the `while` loop completely and just try to read retcode, which was never assigned. Reviewed By: fanzeyi Differential Revision: D23999523 fbshipit-source-id: fac4a1104eba3585fb52fc8d83163cb1a87b8fee
-
Jon Maltiel Swenson authored
Summary: This diff adds a utility `withJitter` that creates an observer proxying updates from the input observer, with the difference that each update will be propagated with a random lag. Reviewed By: andriigrynenko Differential Revision: D23795834 fbshipit-source-id: cdaee7460c3c346e70f6c8c78f18467fe8cd4e47
-
- 29 Sep, 2020 4 commits
-
-
Dan Melnic authored
Summary: Use separate b_, e_ range members Reviewed By: yfeldblum Differential Revision: D23983016 fbshipit-source-id: b17061d7c1022c4776a8a8cb76ad5d0b9da9ace2
-
Yedidya Feldblum authored
Summary: [Folly] A few simplifying tweaks to SFINAE in `Function`. Reviewed By: aary Differential Revision: D23798698 fbshipit-source-id: e5a3ecfe755f6eb371c253cfb925a23d4f5d29e4
-
Wojciech Lis authored
Summary: In the sync from fbsource to ovrsource, we found that signal_set macro from libevent has a conflict with boost::asio::signal_set function in boost_context. e.g. failure https://www.internalfb.com/intern/sandcastle/job/18014398839678371/ This undef removes the build failures on the ovrsource side. Reviewed By: yfeldblum Differential Revision: D23941679 fbshipit-source-id: 25e208bdbc93f289d787ca742623fd6815863705
-
Koby Kahane authored
Summary: Currently, Hardware.h assumes the `__rdtsc` intrinsic is always available when building with MSVC. However, this is not the case when building for Windows for ARM64. This blocks successful compilation of https://github.com/facebook/rocksdb on Windows for ARM64, since that library embeds Folly and includes this specific header. Instead, use a condition similar to the check in `asm_volatile_pause` in Asm.h. This results in successful compilation and a fallback to `steady_clock::now()` on Windows for ARM64 targets. Pull Request resolved: https://github.com/facebook/folly/pull/1461 Reviewed By: yfeldblum Differential Revision: D23952622 Pulled By: Orvid fbshipit-source-id: 1f02d04cbbbde42c80ad56d8d7ccc4dd7fe86847
-
- 28 Sep, 2020 3 commits
-
-
Zeyi (Rice) Fan authored
Summary: It seems after updating zstd to 1.4.5. `Dllexport` for zstd.dll was not being picked up correctly. Instead of having zstd being a runtime dependency let's try statically link it to avoid the DLL issue. Reviewed By: vitaut Differential Revision: D23970349 fbshipit-source-id: 3b14dddb64d410cb9546c416f27d73b7604b21ba
-
Maged Michael authored
Summary: Fix race condition in hazptr_obj_cohort deactivation Race condition: - Thread T1 is doing asynchronous reclamation of objects. - Thread T2 starts deactivating cohort C. - T1 reclaims an object that its destructor retires a tagged object A that belongs to cohort C. - T1 checks that C is active. - T2 sets C.active_ to false. - T2 pops and reclaims the objects in C's list. - T1 pushes A in C's list - T2 expects to find C's list empty but it is not. Assertion failure. With the fix. - Thread T1 is doing asynchronous reclamation of objects. - Thread T2 starts deactivating cohort C. - T1 reclaims an object that its destructor retires a tagged object A that belongs to cohort C. - T1 checks that C is active. - T2 sets C.active_ to false. - **T2 waits for T1 to release the lock on the domain tagged list** - T1 pushes A in C's list - **T1 releases the lock** - **T2 cleans up C's objects in the domain tagged list** - **No subsequent asynchronous reclamation of objects in the domain will involve objects that belong to C** - T2 pops and reclaims the objects in C's list **including A** - T2 finds C's list empty as expected. Reviewed By: yfeldblum Differential Revision: D23947490 fbshipit-source-id: 943664e61190da7b4ad1bb31ac47609bdea2314d
-
Richard Tynan authored
Summary: Simple typo that I spotted. Differential Revision: D23963553 fbshipit-source-id: 018e81c4878f4cb27b6676e88278d47d38706ed4
-
- 27 Sep, 2020 1 commit
-
-
Andrii Grynenko authored
Summary: Store a raw pointer to the managed object outside of the ReadMostlySharedPtrCore to make casting easier. Reviewed By: yfeldblum Differential Revision: D23920580 fbshipit-source-id: 4d3d3423f4ef3a78ebbd5efd45bb365ca0f72a18
-
- 26 Sep, 2020 2 commits
-
-
Lukas Piatkowski authored
Summary: Pull Request resolved: https://github.com/facebookexperimental/rust-shed/pull/12 The OpenSSL version on Mac doesn't work well with EdenSCM and Mononoke integration, just use the one from getdeps/brew. Also remove the now redundant "DEVELOPER_DIR" since the modern XCode version works. Pull Request resolved: https://github.com/facebookexperimental/eden/pull/63 Reviewed By: StanislavGlebik Differential Revision: D23927022 Pulled By: lukaspiatkowski fbshipit-source-id: 6b6b3baa33d49b567b9aa6178cbd20b7ae9edc89
-
Dan Melnic authored
Summary: Add support for SQ poll groups - this allows sharing of the same SQ kernel poll thread (Note: this ignores all push blocking failures!) Reviewed By: kevin-vigor Differential Revision: D23769744 fbshipit-source-id: c5fd3d22fd1048321896d7445d7bc7e2863ad533
-
- 25 Sep, 2020 7 commits
-
-
Dan Melnic authored
Summary: Skip deadlocking fork tests in TSAN mode Differential Revision: D23933183 fbshipit-source-id: a5fe2da954676f6ced2f00dea280e10ac88d99cd
-
Dan Melnic authored
Summary: Add support for immediate SQ poll submit Reviewed By: kevin-vigor Differential Revision: D23818098 fbshipit-source-id: d8d626c51aef0cf8c0049e081d86313cb731429a
-
Robin Cheng authored
Summary: The symbolizer takes mapped addresses (address listed in ELF, offset by the binary offset (which is zero for non-PIE)) and symbolizes it into non-mapped addresses. In a couple of places in SymbolizerTest, we took the non-mapped addresses and symbolized them again, which wouldn't work if the binary was compiled with PIE. In another place in SymbolizerTest, the mapped address was used to look up DWARF information, whereas we needed the non-mapped address. This diff addresses these issues. Additionally, I discovered that r_debug::r_map->l_addr is the "right" way to get the PIE offset, so this diff pulls that common functionality to symbolizer/detail/Debug.h and use it for Symbolizer and the three tests so far that need PIE relocation adjustments. Reviewed By: yfeldblum Differential Revision: D23492850 fbshipit-source-id: 62353e576c50b44070b323b5477fea9bb4c0b500
-
Robin Cheng authored
Summary: Similar to D23139413, this is another place where openssl causes TSAN issues widely in fbcode. Reviewed By: yfeldblum Differential Revision: D23698225 fbshipit-source-id: e883784500392c2d5be757c37cceb8bf8cc8b2aa
-
Chad Austin authored
Summary: I don't recall what previous intermediate state justified guarding use of backtrace with __APPLE__ and FOLLY_USE_SYMBOLIZER, but it no longer applies. Reviewed By: yfeldblum, luciang Differential Revision: D23881192 fbshipit-source-id: b3ca829f9c738f50f7ab7e038348ec3df65ae4b9
-
Orvid King authored
Summary: Original commit changeset: 6362acb7a668 (D23066827 (https://github.com/facebook/folly/commit/0b3d9d21b7d1496e0b592ee6ce7a687c86c0498f)) Reviewed By: yfeldblum Differential Revision: D23837145 fbshipit-source-id: 642c1401aea0b01c0c5e53c24b100f5daa600512
-
Yedidya Feldblum authored
Summary: [Folly] Fix the Apple LLVM version when disabling is-constexpr-default-constructible test expectations over types with non-trivial destructors for Xcode 12. Differential Revision: D23917973 fbshipit-source-id: 1238ec5a53ba0ff73afd67f81ad2868f37196eaa
-
- 24 Sep, 2020 4 commits
-
-
Yang Chi authored
Reviewed By: yfeldblum Differential Revision: D23847355 fbshipit-source-id: b5fbf5bea515111d34962100af0f44ae11e0845f
-
Nicholas Ormrod authored
Summary: - Changed namespace from facebook::memory to folly - Changed include paths - Left a stub file in common/memory/not_null.h Differential Revision: D23740776 fbshipit-source-id: 6eff6823017e3a5d20a540fde10b99aa0381d4b0
-
Yedidya Feldblum authored
Summary: [Folly] Internally rename `await` in `folly/fibers/` since some versions of MSVC effectively `#define await co_await` breaking the build - except it's not really a `#define` and there is no reliable way to detect it. Reviewed By: Orvid Differential Revision: D23882811 fbshipit-source-id: 836bebcbcfe01ce39c873202b67796efafa1c366
-
Kevin Vigor authored
Summary: folly::Function is non-copyable. This means it can be used with lambdas that capture a unique_ptr, whereas std::function can not. See https://www.internalfb.com/intern/wiki/Folly/Function/ Differential Revision: D23883275 fbshipit-source-id: a26cda0d3833e3ea822beef99c6a28a6dd90fa83
-