1. 13 Aug, 2021 2 commits
    • Yedidya Feldblum's avatar
      Cut an outdated comment in FutureBase::thenImplementation · e8ccd7a4
      Yedidya Feldblum authored
      Summary: [Folly] Cut an outdated comment in `FutureBase::thenImplementation`.
      
      Reviewed By: LeeHowes
      
      Differential Revision: D23493983
      
      fbshipit-source-id: 497ab55c10fc6561abb8febf55828190916441f8
      e8ccd7a4
    • Amlan Nayak's avatar
      Use WorkersProvider in CPUThreadPoolWorker to collect thread IDs · 7c93aeb3
      Amlan Nayak authored
      Summary:
      The WorkersProvider can be used to collect OS thread IDs of all active
      threads consuming tasks from the CPUThreadPoolExecutor queue. The
      WorkersProvider::KeepAlive holds a read lock for the `osThreadIds_` list here to
      block the active threads from exiting (they will need to acquire a wlock on the same list on exit)
      while the observer captures the backtraces.
      The actual logic to captures the traces in coming in a subsequent diff.
      
      Reviewed By: mshneer
      
      Differential Revision: D30133823
      
      fbshipit-source-id: 5bcdc52c55077b53fe8ec3be6d2413cac4436125
      7c93aeb3
  2. 12 Aug, 2021 2 commits
    • Cristian Lumezanu's avatar
      Move fd_ to the initializer list in AsyncSocket constructor · d365f9e4
      Cristian Lumezanu authored
      Summary: When constructing a new AsyncSocket, we can use an already connected file descriptor, which we assign to the `fd_` member variable. We move this assignment from the constructor body to the constructor initializer list to avoid a situation where an observer is unaware of an attached fd because `fd_` was assigned after the observer was created.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D30261699
      
      fbshipit-source-id: 5adbc744715355fba08f5430a77c9094e246899d
      d365f9e4
    • Igor Sugak's avatar
      add copy assignment operator to BasicDynamicTokenBucket · 2e2e7af8
      Igor Sugak authored
      Summary: `BasicDynamicTokenBucket` declares a copy constructor, but not copy assignment operator.
      
      Differential Revision: D30258099
      
      fbshipit-source-id: c993177e11023d13d01884e5060269c4d5813088
      2e2e7af8
  3. 11 Aug, 2021 1 commit
    • Maged Michael's avatar
      hazard pointers: Fix flaky test · 559c679d
      Maged Michael authored
      Summary:
      Fix flaky test. Without this fix it is possible for the background asynchronous reclamation thread to be too slow in pushing p1 into the cohorts safe list before the main thread checks for p1's reclamation.
      
      This fix lets the main thread wait for p1 to be reclaimed before checking that p2 was not reclaimed. Since p1 is considered for reclamation before p2, it is possible that this check would pass even if p2 was about to be reclaimed in error. So the test then retires p3 and waits for it to be reclaimed before checking again that p2 was not reclaimed.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D30248673
      
      fbshipit-source-id: 268edb299681ab4b7256dac591d8cacbb960a7cc
      559c679d
  4. 10 Aug, 2021 6 commits
    • Igor Sugak's avatar
      fix nullptr-with-nonzero-offset in folly/io/IOBuf.cpp · 00c5c00f
      Igor Sugak authored
      Reviewed By: yfeldblum
      
      Differential Revision: D30232471
      
      fbshipit-source-id: 1137e306fca34f687c99c7f2155a03515926da45
      00c5c00f
    • Shai Szulanski's avatar
      Add warning when using TaskWithExecutor + InlineLikeExecutor · 7e6bdbbd
      Shai Szulanski authored
      Summary: This is unsafe and leads to all kinds of bugs. It is unfortunately too late to ban it, but we can at least print a warning to help debugging and maybe discourage new uses.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D29972469
      
      fbshipit-source-id: 1534bcc69eaf8f105998d65c0a6503740924cffa
      7e6bdbbd
    • Maged Michael's avatar
      hazptr_obj_cohort: Fix reclamation of safe list · cda1e77c
      Maged Michael authored
      Summary:
      Fix a bug in hazptr_obj_cohort handling of children of reclaimed nodes during reclamation of the safe list. When the cohort is active, the children nodes should be pushed to the domain (to be checked against hazard pointers) and not reclaimed immediately because it is possible that a child node is protected by hazard pointers.
      
      Added test that catches the bug.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D30170939
      
      fbshipit-source-id: e5bfe46b6fa5d4e5ce5cef02a3934ced424138f0
      cda1e77c
    • Cristian Lumezanu's avatar
      Update TcpInfo namespaces · ae4ddebe
      Cristian Lumezanu authored
      Summary: We update the TcpInfo namespace to `folly` (previosuly `folly::tcpinfo`) to avoid introducing unnecessary namespaces and to make it slightly easier to refer to. We also move the structs in the `TcpInfoTypes.h` file to the `folly::detail` namespace and move `LookupOptions` to the `TcpInfo` class, following comments in D22134355 (https://github.com/facebook/folly/commit/68a78d99d10743b54d38a550b2f0ebdc5c872f76).
      
      Reviewed By: bschlinker
      
      Differential Revision: D30159429
      
      fbshipit-source-id: 7260fc80c2e76b3439c539b65cc188b2e5517b24
      ae4ddebe
    • Srivatsan Ramesh's avatar
      Add TerminateCancellationToken utility · 416d85c5
      Srivatsan Ramesh authored
      Summary: `getTerminateCancellationToken()` is the public API that can be used to get a cancellation token that'll be cancelled when any of the registered signal (SIGTERM or SIGINT) is received.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D29883069
      
      fbshipit-source-id: 4270c42316b80afb2c75f54de7e720dcb7a083ca
      416d85c5
    • Johan Schuijt-Li's avatar
      move to common shared directory · 957741d5
      Johan Schuijt-Li authored
      Summary: Allow this to be used by more utilities.
      
      Reviewed By: DurhamG
      
      Differential Revision: D29958512
      
      fbshipit-source-id: b6a1a7017102a4ff4ad252246d3252903bbb793f
      957741d5
  5. 09 Aug, 2021 4 commits
    • Yedidya Feldblum's avatar
      let FOLLY_TYPE_INFO_OF always use its arg · 4f9b8292
      Yedidya Feldblum authored
      Summary: Even when RTTI is disabled, to avoid unused-arg warnings. Then use `FOLLY_TYPE_INFO_OF` to simplify the conditional compilation in `UniqueInstance`.
      
      Reviewed By: praihan
      
      Differential Revision: D30183405
      
      fbshipit-source-id: 040d90751822dedb8faca561a89dcf35da25119b
      4f9b8292
    • Ruslan Sayfutdinov's avatar
      include <optional> in Channel-fwd.h · bf6d3e57
      Ruslan Sayfutdinov authored
      Reviewed By: yfeldblum
      
      Differential Revision: D30191509
      
      fbshipit-source-id: 00e782bf381bd5cb126fd7b18ee3454c6b9d13a7
      bf6d3e57
    • Cristian Lumezanu's avatar
      add fdAttach callback · 2360b227
      Cristian Lumezanu authored
      Summary: The fdAttach callback notifies all AsyncSocketLifecycleObservers attached to the socket that a file descriptor has just been associated with the socket. In AsyncSocket, the file descriptor is created when connect() is **called**, not when it succeeds. This callback lets observers know about the fd immediately; otherwise, observers would have to wait until the connect succeeds to learn about the file descriptor attached event.
      
      Reviewed By: bschlinker
      
      Differential Revision: D29910574
      
      fbshipit-source-id: c452f1091c657a7d118b1e06546555aa04a34bf1
      2360b227
    • Dave Kurtzberg's avatar
      Add a parameterized ctor and m2 getter · 15ffb9b0
      Dave Kurtzberg authored
      Summary: Allows us to serialized and unserialize StreamingStats.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D30108179
      
      fbshipit-source-id: 7a920acfa10e6c16613e9059049b8550478e81f0
      15ffb9b0
  6. 08 Aug, 2021 1 commit
  7. 07 Aug, 2021 1 commit
  8. 06 Aug, 2021 3 commits
    • Yiding Jia's avatar
      Reapply with more fixes: "[folly] Fix concurrency issues in ConcurrentSkipList."" · 379e39cc
      Yiding Jia authored
      Summary:
      Original diff D29248955 (https://github.com/facebook/folly/commit/6f4811eff3b7472347cc34c0ac9876ddd96287fc) had a bug that was causing a memory leak and was reverted.
      
      This diff reapplies it but with an extra fix.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D30082935
      
      fbshipit-source-id: 0f119189fe631fc363dffe5c515a8bfa9a054cf6
      379e39cc
    • Amlan Nayak's avatar
      Record OS thread IDs for threads used in CPUThreadPoolExecutor · 21f9cf7d
      Amlan Nayak authored
      Summary:
      In order to collect backtraces of all threads consuming from the executor's
      queue(s), we need to record their actual thread IDs. We can keep track of the IDs
      in a list owned by the executor. Each thread in the pool will add its own
      thread ID to the tracking list by calling `folly::getOSThreadID()` and is also
      responsible for removing it from the list as it exits.
      
      Reviewed By: yfeldblum, mshneer
      
      Differential Revision: D30103988
      
      fbshipit-source-id: c59a1c31811684974fdb238433bd4796d0bbf2c8
      21f9cf7d
    • Andrew Smith's avatar
      Add FanoutSender abstraction to channels framework · 7f69cb31
      Andrew Smith authored
      Summary:
      The existing FanoutChannel construct takes in an input receiver, allows the creation of output receivers, and broadcasts all received values to the output receivers. It is good for the scenario where you already have an input receiver that you want to forward to multiple output receivers.
      
      However, for the scenario for which there is no existing input receiver, it is a bit heavy weight. To use it in this scenario, you have to create a separate channel, pass its receiver as the input receiver to the FanoutChannel, and write values to the sender.
      
      In addition to having to create a separate input channel that is otherwise unnecessary, it is not optimized for the case where there is a single output receiver. In many cases, there is typically only one output receiver. It would be ideal to have a construct that uses the same amount of memory as a simple channel, in the case where there is only one output receiver.
      
      FanoutSender solves both of these problems. FanoutSender does not require an input channel, and instead allows one to directly write values to all output receivers. In addition, in the case where there is only one output receiver, it uses exactly the same amount of memory as a simple channel.
      
      Reviewed By: aary
      
      Differential Revision: D29896797
      
      fbshipit-source-id: 18178f42364d53e84fb07424ed3e8cc0497e21e1
      7f69cb31
  9. 05 Aug, 2021 5 commits
    • Amlan Nayak's avatar
      Add WorkersProvider interface to QueueObserver · b817015d
      Amlan Nayak authored
      Summary:
      In order to colect backtraces from all threads consuming from a
      task queue, we need the ability to expose their correpsonding thread IDs.
      Here we introduce a new interface `WorkerProvider` which can be used to
      collect the thread IDs. The implementations of this interface will come
      later in the stack.
      
      Reviewed By: mshneer
      
      Differential Revision: D30101184
      
      fbshipit-source-id: 24aaaeeba1983e3917c0224e94fc741b66a4f6a4
      b817015d
    • Yedidya Feldblum's avatar
      cut unused config FOLLY_SUPPLY_MISSING_INT128_TRAITS · 3eb9e985
      Yedidya Feldblum authored
      Reviewed By: luciang
      
      Differential Revision: D30115064
      
      fbshipit-source-id: 53e29b7e3d1a9ea319e7e7f4a636a66c04d2bf24
      3eb9e985
    • Rodolfo Granata's avatar
      Add gdb printer for folly::ConcurrentHashMap. · 49255a75
      Rodolfo Granata authored
      Summary: Add a folly::ConcurrentHashMap GBD iterator and printer.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D30118862
      
      fbshipit-source-id: 4cda41bc36b4ffce10e133de4c377774fece1574
      49255a75
    • Yedidya Feldblum's avatar
      move queue-observer · 6e320985
      Yedidya Feldblum authored
      Summary: It's used for executor queues.
      
      Reviewed By: amlannayak
      
      Differential Revision: D30033262
      
      fbshipit-source-id: 9c01e560890373a11b869a8e26ccec2c35267c3c
      6e320985
    • Nikita Lutsenko's avatar
      folly | Fix hard-coded assumption in folly/Portability that MSVC builds always have SSE4.2. · f55bad22
      Nikita Lutsenko authored
      Summary:
      Windows is always supporting SSE4_2, right? What could go wrong?
      Well, we want to support UWP targeting ARM, meaning that well, we don't have SSE4.2, which causes all different sort of fun things.
      One of them - boost screaming in agony about both NEON SIMD and SSE instructions available.
      Fix it, by ensuring that we only ever declare that we support SSE, if we are not arm.
      
      Reviewed By: rudybear
      
      Differential Revision: D30095193
      
      fbshipit-source-id: e303f90348116cd3b5ea618dc737a647d7aa2cd6
      f55bad22
  10. 04 Aug, 2021 2 commits
    • Lucian Grijincu's avatar
      folly/Benchmark.cpp: right align user metrics · 37e6bbcc
      Lucian Grijincu authored
      Summary:
      Right align so number units are easier to compare.
      
      ```name=before
      ======================================================================================================
      some bench                             relative  time/iter  iters/s  cpu-cycles  instructions
      ======================================================================================================
      A                                                  33.19us   30.13K  100.61K     217.49K
      B                                        93.71%    35.41us   28.24K  106.19K     224.50K
      C                                                  24.37us   41.03K  71.86K      92.74K
      D                                       163.37%    14.92us   67.02K  45.04K      77.66K
      ======================================================================================================
      ```
      
      ```name=after
      ======================================================================================================
      some bench                             relative  time/iter  iters/s  cpu-cycles  instructions
      ======================================================================================================
      A                                                  33.92us   29.48K     102.56K       217.49K
      B                                        94.27%    35.99us   27.79K     113.75K       224.50K
      C                                                  23.53us   42.51K      72.80K        92.73K
      D                                       154.72%    15.20us   65.77K      47.21K        77.66K
      ======================================================================================================
      ````
      
      Reviewed By: yfeldblum, ot, philippv
      
      Differential Revision: D30081837
      
      fbshipit-source-id: cbbfb7e381910c102eefca13475840c58a8b3361
      37e6bbcc
    • Yiding Jia's avatar
      Back out "Fix concurrency issues in ConcurrentSkipList." · d9abea1b
      Yiding Jia authored
      Summary: This is causing a memory leak
      
      Reviewed By: yfeldblum
      
      Differential Revision: D30082875
      
      fbshipit-source-id: 6b6ba9963cc45d71cb98b88b1db9a304cb7b7bda
      d9abea1b
  11. 03 Aug, 2021 2 commits
    • Peyman Gardideh's avatar
      switch to tp2 CLI11 · c9875b79
      Peyman Gardideh authored
      Summary: migrating to tp2 version of CLI11. Will delete our local copy in next diff to keep this smaller
      
      Reviewed By: shri-khare
      
      Differential Revision: D29808579
      
      fbshipit-source-id: c7b4cf40a64c9e8804f0eb6c749f36fabdbc79e1
      c9875b79
    • Peyman Gardideh's avatar
      Add CLI11 manifest · 951a343b
      Peyman Gardideh authored
      Summary: Adding a oss manifest for CLI11 to fetch from github
      
      Reviewed By: shri-khare
      
      Differential Revision: D29833128
      
      fbshipit-source-id: 39cae08f9a15b87da0fa6e26c7b9e0387a7cec50
      951a343b
  12. 02 Aug, 2021 3 commits
    • Yedidya Feldblum's avatar
      tweaks to futures interrupts · 451819f6
      Yedidya Feldblum authored
      Summary:
      * Always copy or move the interrupt handler precisely once.
      * Mark interrupt-handler heap classes as final to help the compiler devirtualize, even though it should already be able to.
      
      Reviewed By: davidtgoldblatt
      
      Differential Revision: D29974764
      
      fbshipit-source-id: d39008fa4d1a37fb448d42063da907edc08aa328
      451819f6
    • Jan Mazur's avatar
      adding copyright header · 3e84bbd6
      Jan Mazur authored
      Summary: as in the title
      
      Reviewed By: Croohand
      
      Differential Revision: D30041822
      
      fbshipit-source-id: 923158fcba241f5cd2ace8f87fa12083fd22356c
      3e84bbd6
    • Yedidya Feldblum's avatar
      fix race handling bug in futures interrupt-handler · f4c8e833
      Yedidya Feldblum authored
      Summary:
      Setting the interrupt-handler races with setting the interrupt-exception. This is expected to occur on occasion and should be handled in both `setInterruptHandler` and `raise`. The latter is correct but the former has a bug when, if the race happens, a moved-from interrupt-handler is invoked. The fix is to be sure to invoke a non-moved-from handler.
      
      For consistency, always performs precisely one copy or move of the handler and always invokes the handler as an lvalue-ref-to-non-const.
      
      Reviewed By: iahs
      
      Differential Revision: D29974165
      
      fbshipit-source-id: faf083e97c042fda0622801fc94bbc6fbca910fd
      f4c8e833
  13. 31 Jul, 2021 1 commit
    • Yedidya Feldblum's avatar
      fix observed double-deletes of futures interrupt handlers · d0edf4c6
      Yedidya Feldblum authored
      Summary:
      The state machine for the interrupt has a has-handler state which holds the handler pointer and a terminal state which holds nothing. When a handler has been stored and an exception is raised, the state machine exchanges the handler and transitions the state from has-handler to terminal, and then invokes the handler and decrements its refcount, possibly deleting it. A concurrent continuation of a future can load the interrupt and, if it is a handler, increment its refcount.
      
      There is a possible race: the handler is loaded in both threads, its refcount decremented in the first thread and incremeneted in the second thread, and then the first thread observes an historical refcount of zero and deletes the handler. Fix this race by holding onto the handler until the core is destroyed.
      
      Reviewed By: davidtgoldblatt
      
      Differential Revision: D30017199
      
      fbshipit-source-id: b6c474c630719ef8fd1cb88fa982045a523590dd
      d0edf4c6
  14. 30 Jul, 2021 5 commits
    • Zeyi (Rice) Fan's avatar
      avoid generating internal dependencies for public CI · 9781d415
      Zeyi (Rice) Fan authored
      Reviewed By: wez
      
      Differential Revision: D30017863
      
      fbshipit-source-id: fb94a7c36e05d874fc3a6ce568a7b757c1863ffa
      9781d415
    • Jun Wu's avatar
      include rust-shed in edenscm builds · 0d35ac1d
      Jun Wu authored
      Summary: They will be used by upcoming changes.
      
      Reviewed By: DurhamG
      
      Differential Revision: D30005548
      
      fbshipit-source-id: 6154069f7dfd9b3c9b1b1a7ea3552081c7d1641e
      0d35ac1d
    • Nathan Lanza's avatar
      Cast an unused variable to void during NDEBUG builds · 14933d5f
      Nathan Lanza authored
      Summary:
      the only usage of `remaining` here is in an assert and thus clang13
      errors out on NDEBUG builds. Give it a trivial "usage" here.
      
      Reviewed By: smeenai
      
      Differential Revision: D29719883
      
      fbshipit-source-id: 8141c3ee8ed1b852ea04ec03954c8fe1ac83c12b
      14933d5f
    • Fred Qiu's avatar
      Rename alpn option in folly/openssl · a87dba71
      Fred Qiu authored
      Summary:
      Renamed alpn option from requireAlpnIfClientSupports to
      alpnAllowMismatch.
      
      Reviewed By: knekritz
      
      Differential Revision: D29968118
      
      fbshipit-source-id: bb515efec22520e52444530a2de2b3835691c26c
      a87dba71
    • Dan Melnic's avatar
      fbstring: switch FOLLY_NOINLINE inline to FOLLY_NOINLINE · 24821079
      Dan Melnic authored
      Summary: fbstring: switch FOLLY_NOINLINE inline to FOLLY_NOINLINE
      
      Reviewed By: yfeldblum, ot
      
      Differential Revision: D29978049
      
      fbshipit-source-id: ecacb51d58c0c8f10ce6f67ca1d51e9de60bff55
      24821079
  15. 29 Jul, 2021 2 commits
    • Igor Sugak's avatar
      workaround LLVM-12 coro bug · 57f9d2cd
      Igor Sugak authored
      Reviewed By: yfeldblum
      
      Differential Revision: D29979792
      
      fbshipit-source-id: c18155884f1ac737b7b222b9804398b6bb31049e
      57f9d2cd
    • Fred Qiu's avatar
      Mock Cpp2ConnContext · 8adc1e1f
      Fred Qiu authored
      Summary:
      Mock Cpp2ConnContext so the supplied cert to the constructor is available to
      Cpp2::ConnContext->getTransport()->getPeerCertificate() call. This change is needed by other changes.
      
      Reviewed By: edenzik
      
      Differential Revision: D29791757
      
      fbshipit-source-id: 42b8bb6024c880b038925a3f95b855de0488033b
      8adc1e1f