Commits · f02969dfd3b7a9ac0b0cc8d8f84a12f92bb7ca7e · Libraries / folly

31 Jul, 2015 8 commits

Use constexpr initializers for AtomicHashArray Config · f02969df

Orvid King authored Jul 31, 2015

Summary: Closes #264

Modified by @sgolemon from the original PR to declare MSVC2015-final as the official minimum version, making the defines in the original PR unnecessary.

Reviewed By: @yfeldblum

Differential Revision: D2284130

Pulled By: @sgolemon

f02969df

Overload on dynamic object reference type. · 117385fb

Nick Terrell authored Jul 31, 2015

Summary: There are a bunch of methods in `folly::dynamic` that return a
reference to a sub-object, e.g. `getString()`.
These methods are a bit unsafe because it allows you to write code with dangling
references when the `folly::dynamic` object is an rvalue:

  auto& obj = parse_json(some_string).at("key");

However, the bigger win is that when we have an rvalue `folly::dynamic`, such as
returned by `getDefault(...)`, we can move the sub-object out:

  auto obj = parse_json(some_string).at("key");
  auto str = obj.getDefault("another-key", "").getString();

In the first line, the subobject is copied out when it could be safely moved out.
In the second line `getDefault(...)` copies the dynamic sub-object out, and then
`getString()` copies the string out, when the string could be moved.

Also in the case of `getDefault()` being called on a rvalue, we can move the
sub-object out.

Reviewed By: @marcinpe

Differential Revision: D2267588

117385fb

DelayedDestruction cleanup · d615b776

Sophia Wang authored Jul 31, 2015

Summary: remove unnecessary stuff

Reviewed By: @siyengar

Differential Revision: D2284095

d615b776

Add accessor to estimate a FiberManager's run queue size · 207ab876

Brian Watling authored Jul 31, 2015

Summary: Add accessor to estimate a FiberManager's run queue size

Reviewed By: @sarangbh

Differential Revision: D2293367

207ab876

folly: fix another test running under buck · d7c649a4
Andrew Gallagher authored Jul 31, 2015
```
Reviewed By: @yfeldblum

Differential Revision: D2300047
```
d7c649a4

folly: fix tests running under buck (w/ clang and dynamic linking) · 932cba0f

Andrew Gallagher authored Jul 31, 2015

Summary: Various fixes to get tests passing using buck's dev mode.

Reviewed By: @yfeldblum

Differential Revision: D2299981

932cba0f

futures::retrying. · e0de0a27

Yedidya Feldblum authored Jul 30, 2015

Summary: [Folly] futures::retrying.

Reviewed By: @fugalh

Differential Revision: D2201630

e0de0a27

Fix 'missing declarations' and 'unusued parameter' warnings · 17e68d98

Ondrej Lehecka authored Jul 30, 2015

Summary: enum iterators operator!= didn't use the iterator parameter for comparison
because they assumed you only ever compare to end. Change the operator!= to
look at the iterator parameter to check if it was end.

Thrift generated code for reflection initializers for some types that weren't
declared before definition because they were never called outside of the file.
Marked those initializers as 'static'.

Reviewed By: @alandau

Differential Revision: D2284371

17e68d98

30 Jul, 2015 3 commits

add EventBase-local storage abstraction · b74275bb

Mark McDuff authored Jun 29, 2015

Summary: This has come up a couple times, and the implementation is never nice. Just like we have thread-local storage, it will be useful to also have evb-local storage. Provides at pretty simple get/set/delete interface (see unittest).

Reviewed By: @djwatson

Differential Revision: D2203063

b74275bb

Fix Infinity · 5b8183c1

Nima Aghdaii authored Jul 29, 2015

Summary: folly only accepts "Infinity" while deserializing but writes "infinity" when serializing.
This means folly cannot deserialize what it serialized before.
If we agree on this, we could update ##fbcode/common## as well: https://fburl.com/136793901

Reviewed By: @marcinpe

Differential Revision: D2293627

5b8183c1

Removed an unneeded typename in dynamic.h · b8aa5fcd