Summary: This check is causing some issues in github commits. Figuring out exactly which versions of 4.9 have the bug is a pain, so let's just get rid of it. See D6695110 for more context.

Reviewed By: yfeldblum

Differential Revision: D7431713

fbshipit-source-id: 17d1b025edf52592495c5f69c5a15025b33b3895

Summary: Windows doesn't have a nice function to do this, so we have to do it ourself, throwing the right exception with a struct that no public header defines, because Windows.

Reviewed By: akrieger

Differential Revision: D5100900

fbshipit-source-id: 4f6840e50c5c1aef36adade098739201c97b9af7

Summary: Actually remove it. All uses of it (outside of thrift) were removed in the previous diff.

Reviewed By: ot

Differential Revision: D7422614

fbshipit-source-id: 6a59c34b3cbc0ee7c50f8cbf8c5e641352f2db1a

Summary:
There is a missing `#include <ostream>`.  Add it.
Closes https://github.com/facebook/folly/pull/807

Reviewed By: shixiao

Differential Revision: D7425693

Pulled By: yfeldblum

fbshipit-source-id: cb645f7da94ca5fe5f8d4314b99621557109f360

Summary:
Python is considered a Safe Enivronment, where things like aborts and segfaults
can not happen.

If clients where used outside of "async with" we use to print a error message
and then C++ would abort.

This fix makes sure C++ no longer aborts but we still print the message
that the "async with" should be used.

All futures are now shielded so cancel will not produce strange exceptions when
C++ decides to fullfill the canceled future.

Also we now pass a tuple of client and future to all bridgeFutureWith calls.
This has the affect of making sure the client can not GC before the future
is completed.

We now use a unique_ptr for RequestChannel so there is no more race to delete
the shared pointer.

Reviewed By: yfeldblum

Differential Revision: D7389380

fbshipit-source-id: 6a3ca019190907e726c550c9b379a2a2610d0b0a

Summary: `-Wextra-semi` became more strict. This fixes folly build with the latest clang.

Reviewed By: yfeldblum

Differential Revision: D7359992

fbshipit-source-id: ce7caf05aa536f35e9af4ed33a86072afd09f387

Summary: Revert changes accidentally slipped into D7405057.

Reviewed By: yfeldblum, Orvid

Differential Revision: D7419691

fbshipit-source-id: ab9bea3393eb33aa19b3009263a53ac91e30692c

Summary: folly::ThreadLocal already maintains this list for us.  Add an accessor in folly::SingletonThreadLocal, and use it

Reviewed By: yfeldblum

Differential Revision: D7264843

fbshipit-source-id: 45278f7a074e50b96b451437c327de5d6713363a

Summary: [Folly] Fix `retrying` when the policy throws.

Differential Revision: D7392852

fbshipit-source-id: 3cb1d19697f111bf19047dc382056b39ad241035

Summary: Every compiler we currently support supports the `[[deprecated]]` attribute, so use that instead.

Reviewed By: yfeldblum, ot

Differential Revision: D7405895

fbshipit-source-id: 541c537cd7a0be0d901378c0e79f5cd0f55b85e3

Summary: Adding more details to the documentation and a unit test which checks various executors.

Reviewed By: yfeldblum, djwatson

Differential Revision: D7410461

fbshipit-source-id: 2ae6926f43862ec45a06ff76dbacae681fe6feaa

Reviewed By: wqfish

Differential Revision: D7205067

fbshipit-source-id: 2236c132b2150e38da6d5a5c9970347320e19a60

Summary:
Fix "declaration of 'h' shadows a previous local [-Werror=shadow-compatible-local]"

(Note: this ignores all push blocking failures!)

Reviewed By: djwatson

Differential Revision: D7406485

fbshipit-source-id: f23548022a3ccb1f480c7265b11c31d2e2876fd4

Summary:
Due to a quirk in how MSVC does name resolution, if a default value is declared in the forward declaration of a template, and the definition is made available in the same unit, the default values in the forward declaration must use the names given in the definition, not the declaration.
To keep it sane, just use the same template parameter names for both the declaration and definition.

(Note: this ignores all push blocking failures!)

Reviewed By: shixiao

Differential Revision: D7405057

fbshipit-source-id: dda14043fec30fa505bb0bb3e2e31d0abb52ba1f

Summary:
This diff adds a reverse iterator to F14VectorMap/Set; this is mainly useful because
if there have been no calls to erase(), the reverse iterator will visit the entries in
insertion order.

Reviewed By: nbronson

Differential Revision: D7173038

fbshipit-source-id: 0a64c4e753c9c36c6ac8b6141654b6f29f410580

Summary:
The layout of an exception_ptr is determined by the ABI, not the OS. MinGW (and
Cygwin, depending on the build settings) define `_WIN32` and would therefore
have `kIsWindows` be true, but they use the Itanium ABI instead of Microsoft's,
so we shouldn't take the MSVC codepath for them.

Unfortunately, there isn't a reliable preprocessor method to determine the ABI
being used. `_MSC_VER` can be defined even when using the Itanium ABI (e.g.
when using windows-itanium triples with clang), and `_MSC_VER` can be undefined
even when using the Microsoft ABI (e.g. when building with `-fno-ms-extensions`
with clang).

To address this, introduce `kMicrosoftAbiVer`, which defaults to `_MSC_VER`,
but can be overridden manually if necessary. This should do the right thing by
default most of the time, while providing an escape hatch for when `_MSC_VER`
would be incorrect to use directly.

Reviewed By: yfeldblum

Differential Revision: D7377853

fbshipit-source-id: dd868370e9a496b98dd26dec77c4a75c49147c3c

Summary:
Currently, `collectN` attaches a callback to each input future. When the callback fires, it calls `emplace_back` on vector `ctx->v` with the result of the future. As the added unit test shows, this does not work if the futures are completed in parallel.

See https://fb.facebook.com/groups/474291069286180/permalink/1838209692894304/ for more discussion.

Reviewed By: yfeldblum

Differential Revision: D7372982

fbshipit-source-id: 875eff19172bdbfb7d4f687911f4fa22061e4ed8

Summary:
`std::tuple` and `std::unordered_map` have long been standardized and supported by every platform we care about.
Beyond that MSVC is starting to remove the tr1 namespace entirely, so these references don't work under the newest MSVC.

Reviewed By: yfeldblum

Differential Revision: D7389783

fbshipit-source-id: c089490360ebf15ac23925f71e991602fda3d7a0

Summary: The nightlies for MSVC included support for std::launder, but the version that released with VS2017.7 Preview 2 doesn't actually support it. The version included in the preview also adds a macro to detect if it's been enabled, so use that.

Reviewed By: yfeldblum

Differential Revision: D7388311

fbshipit-source-id: 197230c9947cb271d6107d0cd5e905643e5589d1

Summary:
MSVC moves faster than boost updates, so it's not unusual to be building with an MSVC newer than the boost being used was able to be tested against. This causes Boost to emit a message at compile time for every compilation unit it is included in.
Luckly, boost provides a way out of the message, so add a config option to do so and enable it by default.

Reviewed By: yfeldblum

Differential Revision: D7388583

fbshipit-source-id: 8ecddc048df432df5200f4601e4121bdbd275220

Summary:
[Folly] Use C++ `thread_local` for fast-path cache in `SingletonThreadLocal`.

Because modules might be `dlclose`'d, use `static thread_local` rather than `static __thread` in the slow path which integrates the dtor into both `dlclose` and thread exit.

Because there might be multiple dynamically-loaded modules where the `static __thread` caches cannot be merged into a single cache, let all caches be tracked in a list. We have not found a case where this can happen while at the same time the `StaticSingletonManager` singleton does get merged, but this is at least not strictly wrong.

Reviewed By: djwatson

Differential Revision: D7316155

fbshipit-source-id: 0bf06638853ed70464856853349445d9fa6eabc0

Summary: Currently, initializing a `ThreadLocal` with 0 silently passes and then fails at a later stage making it very hard to debug what went wrong

Reviewed By: yfeldblum

Differential Revision: D7326627

fbshipit-source-id: dab62166753168e292f67938c52f82a1b610be2a

Summary:
Latest clang reported `-Wextra-semi` in `BOOST_MPL_HAS_XXX_TRAIT_DEF` uses with the trailing `;`. Codemod them away before the upgrade.
```lang=bash
fbgr -sl 'BOOST_MPL_HAS_XXX_TRAIT_DEF\(.*\);$' | xargs perl -pi -e 's,(BOOST_MPL_HAS_XXX_TRAIT_DEF\(.*\));$,\1,'
```

Reviewed By: yfeldblum

Differential Revision: D7383619

fbshipit-source-id: f7f9415617cf6d4a876ebe8bf782d0115cd01c23

Summary:
Compilation of basic sample from doc using VS2017 currently fails with:
```
C2327 'folly::ProducerConsumerQueue<folly::fbstring>::writeIndex_': is not a type name, static, or enumerator
```
Fixed it and updated the docs.
Closes https://github.com/facebook/folly/pull/806

Reviewed By: akrieger

Differential Revision: D7379931

Pulled By: yfeldblum

fbshipit-source-id: 6b7a72abd3324af56de355a6e65bdc7e1195596d

Summary:
Macro BENCHMARK_DRAW_LINE can be used as the following:
```lang=bash
BENCHMARK_DRAW_LINE()
BENCHMARK_DRAW_LINE();
```
This inconsistency was detected by `-Wextra-semi` in the latest clang. This diff removes the trailing `;` inside `BENCHMARK_DRAW_LINE` and updates all of the references.

```lang=bash
fbgr -sl 'BENCHMARK_DRAW_LINE\(\)' | xargs perl -pi -e 's,(?<!#define )BENCHMARK_DRAW_LINE\(\)(?!;),BENCHMARK_DRAW_LINE\(\);,'
```

Reviewed By: yfeldblum

Differential Revision: D7382525

fbshipit-source-id: 76f1da01bb4dde1b0fa4ebf98748d001d8e04ab0

Summary: As title

Reviewed By: yfeldblum

Differential Revision: D7379148

fbshipit-source-id: 6865940adee5899a055e1dac6b23705db2bc8ed7

Summary:
`iterator F14VectorMap::erase(const_iterator, const_iterator)` was missing a
conversion from `const_iterator` to `iterator`. This diff adds it as well as a
test. For sets, `iterator == const_iterator` so no need for anything special.

Perhaps we could save the roundtrip from iterator space to index space and
back using some const_cast of fancy pointers? The cost is going to be amortized
anyway...

Reviewed By: nbronson

Differential Revision: D7373152

fbshipit-source-id: 91f651b3e4a1314c68fb8809baeb1477f8881790

Summary:
[Folly] Gate `hazptr` `static_assert` on `_CPPLIB_VER` vs `_MSC_VER`.

It's a property of the standard library implementation, not a property of the compiler front-end.

Reviewed By: smeenai, Orvid

Differential Revision: D7378222

fbshipit-source-id: 78d04252df751b683c0099cb0c273302ff388b73

Summary:
It's easy enough to calculate the right offset for both 32 and 64-bit
platforms, so we can just do so instead of hardcoding the 64-bit offset.

Reviewed By: yfeldblum, Orvid

Differential Revision: D7377039

fbshipit-source-id: 5f7efbae58b7694801274e195a97b5e5b62b5a5e

Summary: in response to https://github.com/facebook/openr/issues/23

Reviewed By: snarkmaster

Differential Revision: D7342371

fbshipit-source-id: 15737f79900722ce016494f994932aa26e5acad5

Summary:
[Folly] Enable `-Wshadow` for clang and gcc >= 5.

And disable it globally for gcc < 5 (sorry, but not sorry). The gcc < 5 implementation is far too restrictive.

Reviewed By: meyering

Differential Revision: D7320760

fbshipit-source-id: 49cc971afcacc92b0bb2d9c4b2d7b04405fb95b3

Summary:
Original commit changeset: 4f59f6c3c8aa

This is to address segfaulting in instagram server tests

Reviewed By: fried

Differential Revision: D7368716

fbshipit-source-id: ef28fdc17fb72631550d81616c24498a3b3894a1

Summary:
This diff adds a header file which includes forward declaration of F14
containers.

Reviewed By: nbronson

Differential Revision: D7342805

fbshipit-source-id: 01e867792d8bde3769f4c71dfb6b80574b13f2b6

Summary:
* make F14 containers their own types even on platforms where we fall back to
stl containers.
* extract F14FastMap to be the same conditional typedef.
* define custom swap operators to avoid unnecessary move construct and move
  assignment.

Reviewed By: nbronson

Differential Revision: D7295846

fbshipit-source-id: 92faa2feddc5c85dd17a5dd937004ca1839a09f6

Summary:
Update the LogName code to also treat `/` and `\\` as category separators, just
like `.`.

This makes it easy to use directory and file names directly as log category
names.  The XLOG() code already turns file names in to log category names.
Previously `getXlogCategoryNameForFile()` had to do its own translation of
directory separators into `.`.  Users manually had to perform this translation
on their own when setting the configuration for specific categories.

This change makes it possible for users to specify the filename as input
directly when updating the logging configuration and it automatically updates
the correct category.

This also allows us to avoid allocating a new string in
`getXlogCategoryNameForFile()` since we no longer have to translate directory
separator characters there.

Reviewed By: chadaustin

Differential Revision: D7348520

fbshipit-source-id: 0e996f4351798b4636786a14ebb2d8820a2cc153

Summary:
retryingPolicyCappedJitteredExponentialBackoff had an integer overflow.
This occured usually when we had more than 64 retries, since we compute pow(2, n) and then we convert to a 64 bit integer.
I added a check that it won't overflow, and if it does, then it returns the max_backoff value.

Reviewed By: yfeldblum

Differential Revision: D7284952

fbshipit-source-id: 7424f502b8530f8e39ba0513dd70bfc9fdc5c8e5

Summary:
Revert NotificationQueue changes until the thread local changes land

(Note: this ignores all push blocking failures!)

Reviewed By: yfeldblum

Differential Revision: D7359322

fbshipit-source-id: c59c81c34b341e4a968b2ce14947b558b8db3a85

Summary: This means using "test" rather than "tests" for the name of the test directory.

Reviewed By: wqfish

Differential Revision: D7355701

fbshipit-source-id: 262f746a983eef550dd9271a026e0d243d8a335d

Summary:
Openr is only doing travis ci for ubuntu 16.04 with gcc 5 so having
the example with the older flavors can be misleading for our community.

Reviewed By: saifhhasan

Differential Revision: D7345130

fbshipit-source-id: 684cc8e58a650050b6f63c2ec20aac1857476da7

Summary:
Python is considered a Safe Enivronment, where things like aborts and segfaults
can not happen.

If clients where used outside of "async with" we use to print a error message
and then C++ would abort.

This fix makes sure C++ no longer aborts but we still print the message
that the "async with" should be used.

Reviewed By: ambv

Differential Revision: D6923956

fbshipit-source-id: 4f59f6c3c8aa5c8b2c279c728a8c011a040940af