- 12 Nov, 2021 2 commits
-
-
Shai Szulanski authored
Summary: Breaks rescheduling on error Differential Revision: D32398162 fbshipit-source-id: 582db297e0b700617c2e455e1f6d2fd1fa40e143
-
Christoph Purrer authored
Summary: - For Windows in xplat we use [Clang9/12 + MSVC 2017](https://www.internalfb.com/code/search?q=filepath%3Afbsource%2Ftools%2Fbuckconfigs%2Fcxx%2Fwindows%20repo%3Afbsource%20vs2017_15.9) and it's [<experimental/coroutine>](https://www.internalfb.com/phabricator/paste/view/P467028969) - When upgrading to MSVC 2019 we also get [<coroutine>](https://www.internalfb.com/phabricator/paste/view/P467029007) in addition to [<experimental/coroutine>](https://www.internalfb.com/phabricator/paste/view/P467029069) - The MSVC2019 ```<coroutine>``` does not work with our current Windows [coroutine solution](https://fb.workplace.com/groups/rp.co.await/permalink/748274059391415/) / [D26877884](https://www.internalfb.com/diff/D26877884) - Hence I am *re-using* an existing flag to opt-out of ```<coroutine>``` as MSVC 2019 left for backwards compatibility also ```<experimental/coroutine>``` Reviewed By: yfeldblum Differential Revision: D32282445 fbshipit-source-id: d2eeb3057518e95135cf054ab6156dac5aa15065
-
- 11 Nov, 2021 6 commits
-
-
Shai Szulanski authored
Summary: Provies single-await co_nothrow wrapper Reviewed By: capickett Differential Revision: D31450124 fbshipit-source-id: e8d18c49248d85ef864abad2eecffe69de58a546
-
Shai Szulanski authored
Summary: Extended coroutine handle interface for attaching new features Reviewed By: capickett Differential Revision: D31450126 fbshipit-source-id: 2aa6b8a4fb72e5007d08f38fcde5c7abd8eabd67
-
Andrew Huang authored
Reviewed By: AjanthanAsogamoorthy Differential Revision: D32328268 fbshipit-source-id: e2816aa89d0ffc96e0377603fca6ca4a39830def
-
Philip Pronin authored
Summary: We're hiding internal frames during dump, but forget to adjust the reported count, so the output looks clowny. Reviewed By: luciang Differential Revision: D32340094 fbshipit-source-id: 86a02c54178a03a83fa64c29faf6d82abfa45bf8
-
Thomas Orozco authored
Summary: I use it in the next diff. Reviewed By: xavierd Differential Revision: D32280314 fbshipit-source-id: 32d86780ae3187449fc7ceb1dc474cc7ac2d1ac1
-
Yedidya Feldblum authored
Summary: Let their types be determined by the atomic parameter only so that conversions may happen at the call-site. This is what the `std::atomic_compare_exchange` functions do. Those functions are specified to use `typename std::atomic<T>::value_type` rather than `T` but, curiously, not all implementations of `std::atomic` have member type alias `value_type`. So instead of using member type alias `value_type` to get dependency, we use `type_t`. Reviewed By: ot Differential Revision: D32259208 fbshipit-source-id: 413e3580aff3dd0ece5051b7a62dfd16f49eb5a8
-
- 10 Nov, 2021 5 commits
-
-
Yedidya Feldblum authored
Summary: Use invokers and rename the invokers for clarity. Reviewed By: luciang Differential Revision: D32160395 fbshipit-source-id: 97052fc42c23db3e315bd721dcf7b3f29669bcaa
-
Yedidya Feldblum authored
Summary: Choose `_native` and `_fallback` suffixes nstead of `_x86` and `_deafult` suffixes. `_native` instead of `_x86` since the intention is broader than x86; `_fallback` instead of `_default` since fallback is a clear word. Reviewed By: luciang Differential Revision: D32160396 fbshipit-source-id: 08d064aae670ea7e93a098b16a511ff43ca8a7e1
-
Andrii Grynenko authored
Reviewed By: praihan Differential Revision: D32297368 fbshipit-source-id: a58c7805d396cc30c0d82a49d5998e2f9d8a799a
-
Yedidya Feldblum authored
Summary: The bit param is 0-based. So, for bit 1, the mask is `0b10`. Reviewed By: luciang Differential Revision: D32160394 fbshipit-source-id: cfef250b3035d8c7e29b2f36848482888801781c
-
Konstantin Tsoy authored
Summary: This fixes mvfst OSS tests on Mac. Reviewed By: lnicco Differential Revision: D32227732 fbshipit-source-id: 1375799046803a5183f83441b93deb0ab2e0961f
-
- 09 Nov, 2021 2 commits
-
-
Wendy Wang authored
Summary: As titled Reviewed By: ivmaykov Differential Revision: D31974990 fbshipit-source-id: 03b60c4e9d4a7464c27cd53f1989cda878132933
-
Andrii Grynenko authored
Reviewed By: Gownta Differential Revision: D32197071 fbshipit-source-id: 19ead9d39777efa73750346e59dc69ef57ce4961
-
- 08 Nov, 2021 3 commits
-
-
Andrew Smith authored
Summary: We currently call closeReceiver() on a receiver in receiversBySubscriptionId_ that has already been removed from receivers_ (and freed). The fix is to check to see whether the receiver in receiversBySubscriptionId_ is still present in receivers_ before invoking any functions on it. If the receiver is not present in receivers_, that means it has already been closed, so we do not need to close it. Reviewed By: aary Differential Revision: D32233062 fbshipit-source-id: 0aa763b509897db7de970e12e2f01cffc1b49fc3
-
Alex Hornby authored
Summary: macos build is failing, disable to get clean internal CI Reviewed By: HarveyHunt Differential Revision: D32238516 fbshipit-source-id: dad2d15d65a9ee971c254775fcc8e6e80fa97ab0
-
Andrew Huang authored
Reviewed By: mingtaoy Differential Revision: D32218077 fbshipit-source-id: 5a966ced07387340d02ad2a85c095939c9e7f530
-
- 07 Nov, 2021 1 commit
-
-
Daniel Porteous authored
Summary: Fixing an incorrectly formatted link in https://github.com/facebook/folly/blob/main/folly/docs/Synchronized.md. Reviewed By: yfeldblum Differential Revision: D32227087 fbshipit-source-id: 773ed8f1a0651a177fd306b63b514a917a8934bd
-
- 06 Nov, 2021 3 commits
-
-
Andrew Smith authored
Summary: Currently, when we get a cancelled notification on the output sender for a transform, we schedule the cancellation of any running transform callback on an executor. CancellationSource is thread-safe, so we don't need to do this. This diff ensures that cancelling the output receiver will immediately trigger cancellation of any running transform callback, allowing the transform callback to deterministically know that it has been cancelled. Reviewed By: aary Differential Revision: D32191796 fbshipit-source-id: aabd58be9b58b0f560b8127b336e626c3482a644
-
Andrew Smith authored
Summary: This ensures that closing a FanoutChannel will synchronously cancel its input receiver. We don't need to run this code on the provided executor, because it is not running as part of a callback (and because we already have a lock). Reviewed By: aary Differential Revision: D32191795 fbshipit-source-id: 9ec2a2303a12580e052de7af8651ebf5b773b8b6
-
Yedidya Feldblum authored
Summary: To ease writing and reading IO code. Reviewed By: iahs Differential Revision: D32220718 fbshipit-source-id: db695eb33a60aae0db1b34991bd7d5ce33489f86
-
- 05 Nov, 2021 9 commits
-
-
Yedidya Feldblum authored
Summary: The memory orders seem backwards but are correct. Add a comment explaining the surprising situation. Reviewed By: ot Differential Revision: D31594601 fbshipit-source-id: 61a3f5a5700cfe640e025ad5d5388a5dda1f97eb
-
Akrama Baig Mirza authored
Summary: Add an implementation of `WorkerProvider` to `IOThreadPoolDeadlockDetectorObserver`. - On thread start, the observer creates a `TaskStallDetector` and provides it a `ThreadIdCollector` containing the TID of the thread that started - The thread will be blocked from exiting until any existing `WorkerProvider::KeepAlive`s are destroyed Differential Revision: D31963855 fbshipit-source-id: cd749d76a433684a8280d95a4dbff441e32bfda9
-
Alex Hornby authored
Summary: Move the hg build to fbthrift_socket, it was referencing the removed fbthrift_socket-02 from some cargo files Reviewed By: mzr Differential Revision: D32159904 fbshipit-source-id: 58db0fd53cf859d19a237c0a1d50370d405132b8
-
Alex Hornby authored
Summary: rpm names needed updating as boost-contract wasn't found. The rpm names now include the boost version which should be handy when boost dependency is updated next Unfortunately the centos boost 1.69 rpms aren't found automatically by the centos cmake boost rules, so this also adds builder.py logic to point to it using BOOST_INCLUDEDIR and BOOST_LIBRARYDIR Reviewed By: mzr Differential Revision: D32140834 fbshipit-source-id: 3e2dd822613957ae4d7be5b73623ff581f11d02b
-
Alex Hornby authored
Summary: Add the system dependencies so getdeps can install them if not present Reviewed By: krallin Differential Revision: D32152976 fbshipit-source-id: 29311f37126e1eac8dfbe2f46f6bc3516848d48b
-
Giuseppe Ottaviano authored
Summary: There hasn't been a V1 for a very long time. Reviewed By: philippv, luciang Differential Revision: D32170751 fbshipit-source-id: f495a81657cf53f870ce93572d46d835c7fb8496
-
Giuseppe Ottaviano authored
Summary: Add an option to specify that `skipTo()` cannot be called on the current value, so we can save a comparison. Reviewed By: luciang Differential Revision: D32161927 fbshipit-source-id: 6ebfe7711a5ee3bcdf40cd8a1097da777f78c277
-
Giuseppe Ottaviano authored
Summary: Move size and upper bound accounting to `UpperBitsReader`, so we don't need to read the last value on construction, which can be expensive when opening a large number of small lists. This also makes the maximum `ValueType` representable, and lifts the requirement that the provided upper bound at construction time must be equal to the last element in the list, allowing multiple lists to share the encoding of the upper bound. Based on initial work by swaroopnm. Reviewed By: philippv Differential Revision: D32130075 fbshipit-source-id: e98a053b46b10c435ac0d402ff94a56fcfe095ad
-
Giuseppe Ottaviano authored
Summary: Add tests where the list size is close or at the maximum supported size, by fixing `EliasFanoReader` to support `uint16_t` as value and size type. Types smaller than `int` require special support because any arithmetic operation promotes them to `int`, so operations that rely on unsigned overflow break. Work around this by introducing a helper for addition that preserves the type. Reviewed By: philippv, luciang Differential Revision: D32130076 fbshipit-source-id: 763a8e4cc2b023405c173316d2415ca8c3ec7148
-
- 04 Nov, 2021 4 commits
-
-
Cristian Lumezanu authored
Summary: Move `state_` and `addr_` to the initializer list of the AsyncSocket constructor. This is necessary as there may be installed callbacks for AsyncSocket (e.g., using ConstructorCallback) that need these values early. Reviewed By: yfeldblum Differential Revision: D31761420 fbshipit-source-id: 2790cff1413835927be8610d7117208ef39e1cd1
-
Alex Hornby authored
Summary: It was missing openssl-libs Reviewed By: mzr Differential Revision: D32139851 fbshipit-source-id: a60febe3c9e916d1b1c65dfe88a364f5bcfb33b0
-
Alex Hornby authored
Summary: Distro name wasn't matching and thus no rpms being installed or used Also improved the error message for unknown systems Reviewed By: farnz Differential Revision: D32139850 fbshipit-source-id: 438278094159f732f6b1de506490b89d2c9cd3f7
-
slowy07 authored
Summary: ## description fix typo spelling grammar and replace to correct words Pull Request resolved: https://github.com/facebook/folly/pull/1638 Reviewed By: yfeldblum Differential Revision: D30577141 Pulled By: Orvid fbshipit-source-id: 20c3f49fafcb6ca01a9419f5d71a2414dc7ea635
-
- 03 Nov, 2021 3 commits
-
-
Ilya Albrecht authored
Summary: Implemented 8 times unrolled linear folding to cover for _mm_clmulepi64_si128 latency on Skylake Reviewed By: terrelln Differential Revision: D30376340 fbshipit-source-id: 7828639c135ba51048b60c621f5427c7ac1938b4
-
Maged Michael authored
Summary: Fix exit-time destructor warning for hazptr_tc_evict. Differential Revision: D32099949 fbshipit-source-id: f9f12143f4d06fda1122c8a8d741d6381105253f
-
Jun Li (Core System) authored
Summary: BoundedQueue can be useful in many places. This implementation uses MPMCQueue/ProduerConsumerQueue and folly semaphore to achieve bounded queue behavior. Reviewed By: iahs Differential Revision: D31782931 fbshipit-source-id: 06aa12ee6e181641eb7b5acb0c6513b58e436d91
-
- 02 Nov, 2021 2 commits
-
-
Konstantin Tsoy authored
Summary: Need to fix branch name for OSS mvfst so CI continues on. Ran opensource/fbcode_builder/getdeps/facebook/update-all-github-actions.sh Reviewed By: lnicco Differential Revision: D32041656 fbshipit-source-id: f72aab91a3084814a5d3fa8643ae5f405908c313
-
Jim Meyering authored
Summary: We should all be migrating to platform010, for the improved performance of its generated code and for its improved diagnostics/portability. cast PTHREAD_STACK_MIN to size_t, since with glibc-2.34, it now has type long This avoids the following errors: folly/detail/MemoryIdler.cpp:140:18: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'long' [-Werror,-Wsign-compare] Differential Revision: D32057242 fbshipit-source-id: 1fae2aec5829a837e2aecf068f6c2c061c911e95
-