Reviewed By: udippant

Differential Revision: D15368849

fbshipit-source-id: 5e101fc38417b807a531fa456b38234d6dd08b7a

Summary: [Folly] Namespace the helper macro in `folly/ssl/OpenSSLPtrTypes.h`.

Reviewed By: Orvid

Differential Revision: D15370971

fbshipit-source-id: aa907f60fee5ef58c5484838a3bde0d68e65b249

Reviewed By: lewissbaker

Differential Revision: D15363378

fbshipit-source-id: 0343d6cc42624a6c3e9b01a338afb1646625928a

Summary: This is not a good default. We can build a dedicated SpinningBaton if needed

Reviewed By: andriigrynenko

Differential Revision: D15387138

fbshipit-source-id: 433ce2b1af7c661edd2c0e264dc618cc9c680aa3

Summary: This diff replaces all 2 occurrences of "NDEBUG" with "folly::kIsDebug" in folly/SharedMutex.h. Compared to NDEBUG, folly::kIsDebug has the equivalent functionally  but helps consolidate the conditional-compilation logic to a single place, namely folly/portability.

Reviewed By: shixiao

Differential Revision: D15379370

fbshipit-source-id: 58c563624e58a4fd18b0cfbe4c0b9ba879f8eea9

Summary:
When the udp socket is connected we shouldn't supply the peer's address. This changes it so that
we can use write() methods in AsyncUDPSocket when the socket is connected.

Differential Revision: D15384587

fbshipit-source-id: ad26e2d04a7303c7ff9e25f32422d7c56e4283e5

Reviewed By: andriigrynenko

Differential Revision: D15366589

fbshipit-source-id: e8d1c17e158437a3ca882f51f12071bf666c1a6e

Summary:
if we find ccache in the path, then we instruct cmake to use
it as the compiler launcher.

Reviewed By: pkaush

Differential Revision: D15375441

fbshipit-source-id: 602fe54742a5ec07b0533bd2cf63cb905b051e85

Summary:
Adds a benchmark to show the benefit of running work inline.

Dev:
| fourThensOnThread | 2.15% | 245.01us | 4.08K |
| fourThensOnThreadInline | 2.36% | 223.51us | 4.47K |
| hundredThensOnThread | 0.67% | 783.54us | 1.28K |
| hundredThensOnThreadInline | 0.88% |  595.24us | 1.68K |

Opt:
| fourThensOnThread                                |   0.18% |    70.37us  |  14.21K |
| fourThensOnThreadInline                          |   0.26%  |   50.11us   | 19.96K |
| hundredThensOnThread            | 0.18% | 72.54us | 13.79K |
| hundredThensOnThreadInline | 0.21%  | 64.79us | 15.43K |

Reviewed By: yfeldblum

Differential Revision: D15319231

fbshipit-source-id: 978c26538d89de15e76eb69bf20c1129b210a442

Summary:
We were computing `SCRATCH/install` and hashing based on that value,
but the build stuff was later computing `SCRATCH/installed` and passing that
to the builders.

Fixup the mismatch.

Reviewed By: simpkins

Differential Revision: D15337969

fbshipit-source-id: 70288f2d9286aaacf4c1f6e0dac4680a55edac6d

Summary:
Adds inline-supporting forms of thenValue and thenTry. Carries this information in the Core through a variant of the HasCallback state. Dispatches the continuation inline rather than on the executor if that state is set.

Propagate completing executor through intermediate promise and make inline execution conditional on matching executors.

Only continue inline if the executor of the completing task matches that of the task-to-be-enqueued, to ensure that calls to via always trigger reposting and that there are no surprises where work runs on the wrong executor.

Reviewed By: yfeldblum

Differential Revision: D15292236

fbshipit-source-id: 51ddd5cfd1196ea9e9f408e2b1337ff9d4fa5b9f

Summary: [Folly] Extract the unique-instance enforcer from `SingletonThreadLocal` into a standalone `UniqueInstance`.

Reviewed By: andriigrynenko

Differential Revision: D14927839

fbshipit-source-id: cfe98ef7a88746a557a64263f3165cd01caeec37

Summary: [Folly] Cut `presorted` and `unsorted` tags; the `presorted` tag has  ambiguous meaning and is replaced by either `sorted_unique` or `sorted_equivalent`.

Reviewed By: vitaut

Differential Revision: D15196179

fbshipit-source-id: a2cdaa06c7c5a55147db67a877b29c5944039e6d

Summary:
See the test for a concrete example.
We have a scenario where both a library, and a service using that library, are using fiber. Managing a separate similar-sized thread and event-base pool costs us complexity and performance. So this seems like a legit need.

The overall solution is to hash the Options struct.
But because that has some cost, I made it optional, by introducing a new FrozenOptions struct.

Reviewed By: andriigrynenko

Differential Revision: D15305274

fbshipit-source-id: 5c53d8c4ed321ae88089c64de41af8229f877d36

Summary:
This modifies the Baton data-structure to store a linked list of awaiters rather than storing a single awaiter.

When a coroutine awaits the Baton it now does a lock-free push onto a list of awaiters.

When the Baton is posted it atomically dequeues all awaiters from the list and then resumes each of them in turn.

Reviewed By: andriigrynenko

Differential Revision: D15310137

fbshipit-source-id: 895ebcf2b113fb270ad7abfedbaab68ea51de84c

Summary: [Folly] Switch from `NDEBUG` to `kIsDebug` in `MPMCQueue`, preferring C++ over the preprocessor.

Reviewed By: Orvid

Differential Revision: D15303518

fbshipit-source-id: d014cea3035527bd27854f58b1a74a48740efd20

Summary:
If the value for backoff_max is less than backoff_min, we will see inconsistent behavior where the backoff_min sleep duration is used for the first 57 attempts, then backoff_max will be used.

In our case, we hit an issue where 0 was passed for backoff_max. We would see backoff_min sleep times for the first 57 attempts, then immediately drop to 0 sleep time which led to no retry wait at all.

If backoff_max < backoff_min, there's no way to respect both, but this makes the behavior consistent across all tries.

Reviewed By: yfeldblum

Differential Revision: D15282681

fbshipit-source-id: d9dd7b2498d77e4a01c9454a639b612ed9e26519

Differential Revision:
D15177816

Original commit changeset: 7298fcdc3a73

fbshipit-source-id: fc62ec2ecf7fb06bc60cdd0c33b17b53fe35af19

Summary:
HHWheelTimer is a member of EventBase, and EventBase is passed to it in the ctor.
However during the destruction of the evb, wheel timer gets destroyed after the evb is destroyed and still retains a reference to the evb. This is not so good.

This diff fixes it by canceling the timer before the evb gets destroyed.

Reviewed By: lnicco

Differential Revision: D15177816

fbshipit-source-id: 7298fcdc3a73041484a315c420bcb866175c19cc

Summary:
This diff updates docker os_image to ubuntu18 and gcc7 in travis settings.
The dependencies that we work with internally (e.g. gcc7, boost and so on) are not present in the ubuntu-16.04. Further, the support for gcc5 is going away. So maintaining this compatibility for these platforms is painful, especially for new projects, such as mvfst.

Reviewed By: simpkins

Differential Revision: D15286181

fbshipit-source-id: eb0da9556cdb17d0aa132ac2aa4c35f9c6eccd97

Summary: [Folly] `XLOG_EVERY_N`, `XLOG_EVERY_N_EXACT`. Renaming `XLOG_EVERY_N` to `XLOG_EVERY_N_EXACT` and adding a new `XLOG_EVERY_N` which performs better under contention, at the cost of possibly missing increments and therefore over-logging.

Reviewed By: simpkins

Differential Revision: D15230953

fbshipit-source-id: cf7b86b96340f78156f7cd25f7e784b0f1b8d5fa

Summary:
[Folly] Let CPUThreadPoolExecutor use unbounded queues when no queue bounds are specified.

One constructor remains which specifies queue bounds; that constructor uses bounded queues.

Reviewed By: andriigrynenko

Differential Revision: D15113118

fbshipit-source-id: 9c8ace4f170fdfdeef152e55b371d434ad248866

Summary:
xplat folly sync got blocked due to an error with missing ::remainderl
function.
Not really sure why this function is missing, for now ignore it.

Reviewed By: Orvid

Differential Revision: D15298056

fbshipit-source-id: 34035da5de826b55e28c79b8540aacd827e1ffdf

Summary:
- On GCC 4.9 and below, the type of `vec` could not be deduced in the
  `for_each` call.
- Since folly requires GCC 5.1 or later now, which has no issues in the
  deduction, remove the workaround and associated comment.
Pull Request resolved: https://github.com/facebook/folly/pull/1126

Reviewed By: Orvid

Differential Revision: D15292875

Pulled By: yfeldblum

fbshipit-source-id: 50533536e9e73d2c3e5d466d1b6143d0d4085648

Summary: We need this for dependencies that require submodules

Reviewed By: saifhhasan, GirasoleY

Differential Revision: D15282792

fbshipit-source-id: b0cc8d645e73668252409934fd6741fb211e30ae

Summary:
On Windows, the writing operation would fail with:

```
Traceback (most recent call last):
  File ".\opensource\fbcode_builder\getdeps.py", line 400, in <module>
    sys.exit(main())
  File ".\opensource\fbcode_builder\getdeps.py", line 393, in main
    return args.func(args)
  File ".\opensource\fbcode_builder\getdeps.py", line 236, in run
    change_status = fetcher.update()
  File "C:\open\fbsource\fbcode\opensource\fbcode_builder\getdeps\fetcher.py", line 451, in update
    return mapping.mirror(self.build_options.fbsource_dir, self.repo_dir)
  File "C:\open\fbsource\fbcode\opensource\fbcode_builder\getdeps\fetcher.py", line 400, in mirror
    f.write(name + "\n")
  File "C:\Python36\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 104-105: character maps to <undefined>
```

and this is caused by a file in libgit2: https://github.com/libgit2/libgit2/blob/master/tests/resources/status/%E8%BF%99, which is intended to test handling non-ASCII path.

Python on Windows will write file in cp1252 encoding by default, which does not contain that Chines character. (Caveat: that file on my system doesn't have the correct file name as well, it is being encoded in IBM861 for some reason. However the characters in IBM861 does not exist in CP1252 either)

Reviewed By: wez

Differential Revision: D15281521

fbshipit-source-id: 8a75e32bc1042167c945d67e26b549fda83b6b41

Summary:
The goal is to return an error code > 127 in the case of a
transient, retryable, infrastructure error.  This diff generates
those in the case of failure in downloading a URL or from interacting
with LFS.

Reviewed By: strager

Differential Revision: D15266838

fbshipit-source-id: 4f52a791320123968869032c37912dded464a86e

Summary:
the cmake `add_test` and related functions allow specifying
the WORKING_DIRECTORY to use for tests.  We weren't respecting this
value, so this diff looks up the WORKING_DIRECTORY from the ctest
json info and adjusts the buck test info json blob that we pass
on the testpilot.

Since that interface only allows passing an argv array, we use
the `cmake -E chdir` command to run a command in a specified
directory in a portable manner.

Reviewed By: strager

Differential Revision: D15274012

fbshipit-source-id: 1f02d461d73178745794703d455494e31c2e09ed

Summary:
std::remainder isn't supplied by all platforms. Specifically, uclibc
doesn't have it. Do a similar case as with std::nextafter, i.e. implement a
folly version in case it doesn't exists.

Reviewed By: yfeldblum

Differential Revision: D15291533

fbshipit-source-id: 96a70b52af11135102fda3183626df69cdaf4261

Summary:
When building using uclibc, std::nextafter doesn't exist. This is
similar case as for android, where std::nextafter doesn't exist.
Add additional condition to choose folly supplied versions of this function.

Reviewed By: yfeldblum

Differential Revision: D15291534

fbshipit-source-id: f6c9e213248f4e2a6e88e20578aeade46dc85d6b

Summary: [Folly] Add `sorted_unique` ctor to `sorted_vector_set` and `sorted_vector_map`. The `presorted` ctors are used with presorted but not necessarily unique inputs, so uniquify the inputs in that ctors. The untagged ctors which take a backing container presort but do not uniquify the backing container, so switch to presorting and uniquifying.

Reviewed By: vitaut

Differential Revision: D15215677

fbshipit-source-id: bf920103cfb6c297c186e5389701c08218dbc4b9

Summary: [Folly] Less unneeded generality in `sorted_vector_set` and `sorted_vector_map` ctors in terms of `begin` and `end` - can just use member functions.

Reviewed By: vitaut

Differential Revision: D15215590

fbshipit-source-id: e6c8c92fdd9ae16963768b4f748aa07e9566f947

Summary: [Folly] Use `sorted_equivalent` in `TDigest` since it is less ambiguous than `presorted` and it is a backport from C++20.

Reviewed By: vitaut

Differential Revision: D15195608

fbshipit-source-id: 07bb4c7e3750affd10f182efcdf3d9ee9e4a8cf8

Summary: [Folly] Add missing comment for `TDigest::merge` overload.

Reviewed By: vitaut

Differential Revision: D15215559

fbshipit-source-id: 781105819d8160b73d6d70dc22937482f6851f4f

Summary:
[Folly] `sorted_unique_t`, `sorted_equivalent_t`, backporting from p0429 and C++20.

Note that the existing `presorted_t` is ambiguous between `sorted_unique_t` as is assumed in `sorted_vector_set` and `sorted_vector_map` and `sorted_equivalent` as is assumed in `TDigest`.

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p0429r6.pdf

Reviewed By: Orvid

Differential Revision: D15215532

fbshipit-source-id: d90379d609088c6b306a0fc5c7db9b1ad3cdeee8

Summary:
If multiple instances of this test are running, it is possible for a
filename conflict to occur. This fixes that behavior by using a different temp
name each time.

Reviewed By: yfeldblum

Differential Revision: D15258558

fbshipit-source-id: 40e71c57e68a90bc730fb5ba427d999789f6f88c

Summary: mstch is no longer required for fbthrift, we can remove it from oss build spec

Reviewed By: vitaut

Differential Revision: D15280267

fbshipit-source-id: 5008e54af9c927f23b0d6acbf0d9beb6e004eee1

Summary: mstch is no longer required for fbthrift, we can remove it from manifests

Reviewed By: vitaut

Differential Revision: D15279652

fbshipit-source-id: 1772de7ab51fbfe048808f66290c4ca79de60608

Summary: yfeldblum says convention here is 1 or empty (or 0).

Reviewed By: yfeldblum

Differential Revision: D15271809

fbshipit-source-id: 528e4143eaa8ee86807b06c824b3d84a586ec69c

Summary: We had a rare data race on next this diff is fixing that.

Reviewed By: yfeldblum

Differential Revision: D15120382

fbshipit-source-id: d3f0e521b941fdfcd1d968a42d7e8d240c3f74e6