- 07 Jun, 2020 1 commit
-
-
Yedidya Feldblum authored
Summary: [Folly] Add missing `#include <sys/wait.h>` in `folly/test/RandomTest.cpp`. Fixes https://github.com/facebook/folly/issues/1371. Reviewed By: Orvid Differential Revision: D21910410 fbshipit-source-id: 31a045960b2e67282fa77595dfdf840c338ef661
-
- 06 Jun, 2020 2 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Mark `_r_debug` imports as weak imports. `_r_debug` is available in `<link.h>` but is not a portable API, so detect whether it is available at runtime and use it only if it is available. Fixes: https://github.com/facebook/folly/issues/1373. Reviewed By: Orvid Differential Revision: D21911715 fbshipit-source-id: 660c0bc90d405d9a43826e7bdfc3b04480728b66
-
Yedidya Feldblum authored
Summary: [Folly] Cut dead code: `countLoadedElfFiles()`. Differential Revision: D21910945 fbshipit-source-id: 43ff7d118b4876e2cbd4527713c8552963810537
-
- 05 Jun, 2020 1 commit
-
-
Yedidya Feldblum authored
Summary: [Folly] Let `ElfCache` be unbounded to permit binaries with many dynamically-linked libraries from continuously missing the cache when symbolizing. Some applications symbolize stacktraces relatively frequently. When the build is using dynamic linking, such as might be done when developing the application or running the unit-tests, the overhead from re-loading `ElfFile` instances can appear. Address this by making the cache be unboundedly large. This is unlikely to affect applications built using mostly-static linking, such as might be done for production builds, even when they are large applications built from many libraries, since the capacity parameter is usually much larger than the total number of dynamically loaded libraries. Currently, no substantial work is done when initializing `ElfFile` instances. If substantial work were to be done, especially in an unoptimized build such as might be used when developing the application or running the unit-tests, and instances do not stay in cache, then that substantial work would be repeated whenever symbolizing stacktraces rather than being amortized. Reviewed By: luciang Differential Revision: D18819555 fbshipit-source-id: 0e75326133e901e7bd49ea3cefe9b318e6d4466f
-
- 04 Jun, 2020 1 commit
-
-
Andrii Grynenko authored
Summary: It's possible that we still have a recurring pool resizer task scheduled after virtual event base is destroyed. This changes makes sure that we don't try to reschedule it if VirtualEventBase is already destroyed. Reviewed By: yfeldblum Differential Revision: D21875241 fbshipit-source-id: c4622c5d103c6291386055c153ab4aeebe7795a2
-
- 03 Jun, 2020 9 commits
-
-
Martin Thomas Fleischer authored
Summary: In 0ae204a978c11ddefafd81bd319a078239a44c1c the 'projects_dir' option became a required constructor argument since it is called within the constructor. However, it has not been adjusted in the subclasses that used to set the option after instantiation. This commit fixes the 'shell_builder' and the 'debian_system_builder'. Pull Request resolved: https://github.com/facebook/openr/pull/50 Test Plan: 1. Go to build directory: `cd build` 2. Run the `shell_builder` & `debian_system_builder`: - `python fbcode_builder/shell_builder.py` - `python debian_system_builder/debian_system_builder.py` `shell_builder` output before: ``` Traceback (most recent call last): File "fbcode_builder/shell_builder.py", line 102, in <module> builder = ShellFBCodeBuilder() File "/home/butjar/tu/ma/openr/build/fbcode_builder/fbcode_builder.py", line 93, in __init__ self._github_dir = self.option('projects_dir') File "/home/butjar/tu/ma/openr/build/fbcode_builder/fbcode_builder.py", line 108, in option raise RuntimeError('Option {0} is required'.format(name)) RuntimeError: Option projects_dir is required ``` `shell_builder` output after: ``` set -exo pipefail export CCACHE_DIR='/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr/.ccache' CC="ccache ${CC:-gcc}" CXX="ccache ${CXX:-g++}" ### Diagnostics ### # Builder ShellFBCodeBuilder(google/googletest:cmake_defines={u'BUILD_GTEST': u'ON', u'BUILD_SHARED_LIBS': u'OFF'}, google/googletest:git_hash=u'release-1.8.1', facebook/openr:local_repo_dir='/home/butjar/tu/ma/openr', facebook/zstd:git_hash=ShellQuoted(u'$(git describe --abbrev=0 --tags origin/master)'), openr/build:cmake_defines={u'ADD_ROOT_TESTS': u'OFF'}, thom311/libnl:git_hash=u'libnl3_2_25', projects_dir=u'/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr', fmtlib/fmt:git_hash=u'5.3.0', wangle/wangle/build:cmake_defines={u'BUILD_TESTS': u'OFF'}, prefix=u'/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr/installed', fizz/fizz/build:cmake_defines={u'BUILD_TESTS': u'ON'}, ccache_dir=u'/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr/.ccache', zeromq/libzmq:git_hash=u'v4.2.2', make_parallelism=4, jedisct1/libsodium:git_hash=u'stable') hostname cat /etc/issue || echo no /etc/issue g++ --version || echo g++ not installed cmake --version || echo cmake not installed ### Check out fmtlib/fmt, workdir build ### mkdir -p '/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr' && cd '/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr' git clone https://github.com/'fmtlib/fmt' mkdir -p '/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr'/'fmt'/'build' && cd '/home/butjar/.fbcode_builder-sZshomesZsbutjarsZstusZsmasZsopenr'/'fmt'/'build' git checkout '5.3.0' ### Build and install fmtlib/fmt ### ... ``` Reviewed By: steven1327 Differential Revision: D21865881 Pulled By: saifhhasan fbshipit-source-id: dfd78127d3b2c78721f84a3ecafe0b7198c38f06
-
Martin Thomas Fleischer authored
Summary: Typo in python shebang introduced by 0d19e27, probably by accident. Found while skimming the code. Pull Request resolved: https://github.com/facebook/openr/pull/51 Reviewed By: steven1327 Differential Revision: D21865922 Pulled By: saifhhasan fbshipit-source-id: 5f2c2c2fac82078070920915812139f5fef1c7fe
-
Yedidya Feldblum authored
Summary: [Folly] Move `AlignedSysAllocator` computation of max value over input alignment values from two places to a single place. Differential Revision: D19229096 fbshipit-source-id: 4e95c7b7e0afe99c37116150184eb180683c7d13
-
Lukas Piatkowski authored
Reviewed By: StanislavGlebik Differential Revision: D21549859 fbshipit-source-id: 0e143354a60578732ae1eed8c3c71b9f859e3958
-
Zhengxu Chen authored
Summary: Currently output from build command is decoded with "surrogateescape" error handler, but when writing to log files/stdout we don't specify error handlers to be also "surrogateescape" according to https://docs.python.org/3/library/codecs.html#error-handlers, which could cause exception when there's surrogate characters logged in message. Reviewed By: yfeldblum Differential Revision: D21850411 fbshipit-source-id: 21c51d1ab2132171ae29f2d1fbe42655ebee94c5
-
Andrew Huang authored
Summary: When a session is newly negotiated, pass it to the SSLSession belonging to the corresponding AsyncSSLSocket through SSLSessionManager. That SSLSession then becomes resumable. This allows SSLSessions obtained from an AsyncSSLSocket to later become resumable once the session is negotiated (asynchronously in TLS 1.3). Reviewed By: yfeldblum Differential Revision: D21035731 fbshipit-source-id: acbaa258798e7774e742c5765ef33e24573f1c78
-
Andrew Huang authored
Summary: Refactor AsyncSSLSocket session code into a new class called SSLSessionManager, which is a member of AsyncSSLSocket. Will allow for SSLContext to interact with SSLSession through SSLSessionManager, without depending on AsyncSSLSocket. Reviewed By: yfeldblum, mingtaoy Differential Revision: D21164020 fbshipit-source-id: e6b38336127fb000587bfe6948c2274afe8d85e0
-
Junqi Wang authored
Summary: codecleanupraccoon Reviewed By: mjoras Differential Revision: D21845742 fbshipit-source-id: 5adf159ed4ec7a48c76cffdb02d039888ab1686d
-
Victor Zverovich authored
Summary: Update fmt version to 6.2.1 for better compatibility with the version used in fbcode. Among other things this fixes fbthrift build failure on Travis: ``` /home/fbthrift/thrift/lib/cpp2/async/RocketClientChannel.cpp:70:67: required from here /home/install/include/fmt/core.h:492:3: error: static assertion failed: don't know how to format the type, include fmt/ostream.h if it provides an operator<< that should be used ``` which is caused by trying to format an enum class without a formatter - only supported as of 6.0. Reviewed By: stevegury, avalonalex Differential Revision: D21860076 fbshipit-source-id: 1857ab65822956b005980b8dfff7a967508f507c
-
- 01 Jun, 2020 3 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Cut the `FOR_EACH_ENUMERATE` macro, which may be replaced by a combination of range-for, `ranges::view::enumerate`, and structured bindings. Reviewed By: markisaa Differential Revision: D21813019 fbshipit-source-id: fc9ac09a4e2f72f1433d0a518f03d5cd69a59c55
-
Dan Melnic authored
Summary: Expose async read/write functionality Reviewed By: yfeldblum, kevin-vigor Differential Revision: D21731597 fbshipit-source-id: 95a0af53c7b85e1bf1a2619586091b6633bc7b8a
-
soyoo authored
Summary: Pull Request resolved: https://github.com/facebook/folly/pull/1110 Reviewed By: Orvid Differential Revision: D21110331 Pulled By: yfeldblum fbshipit-source-id: 57522232efb7268bc290e4f22057f531a380fb81
-
- 29 May, 2020 5 commits
-
-
Lee Howes authored
Summary: SemiFuture::within creates two valid SemiFutures and promptly overwrites them, both discarding valid SemiFutures and wasting the core allocation. It later drops the updated versions without directly consuming them, instead stealing the deferred executors. This update initializes the two SemiFutures as empty, and safely terminates the chain with trivial callbacks so the SemiFutures can be treated as consumed. Reviewed By: yfeldblum Differential Revision: D21769500 fbshipit-source-id: eab13a78b17ecfc937b42c8d5e01e1292158d9ed
-
Chad Austin authored
Differential Revision: D21757385 fbshipit-source-id: 28af042285d343944452e1c2cf94794a121c0e06
-
Sergey Anpilov authored
Summary: `value` could trigger "unused parameter" warning in NDEBUG builds. The fix is straightforward, to use the new-ish `[[maybe_unused]]` attribute. The alternatives are to use `FOLLY_MAYBE_UNUSED` or even manual `(void)value;`. But since this is coroutines library, it should be reasonably safe to assume the compiler supports the cleaner and more expressive native C++17 option. Reviewed By: lewissbaker Differential Revision: D21784931 fbshipit-source-id: 895bf95d65df6533d768b65c44a898a73e0a636f
-
Chad Austin authored
Summary: There were two problems with the clock_gettime fallback logic on macOS. One is that it used undefined macros if AvailabilityMacros.h wasn't included. Another is that it compiled the fallback when the minimum iPhone OS version (as when building on macOS) was not set, and vice versa. Fix that. Differential Revision: D21757362 fbshipit-source-id: 99fd17260cb25ed07c39ba79466e835f08a1fc7c
-
Matt Dordal authored
Summary: It may be useful to see if a threadlocal has been created on a thread before accessing it. One way this could be useful: the data is only relevant to a few threads but will be accessed by many. This would allow you to save the memory on the non-relevant threads. Differential Revision: D21731260 fbshipit-source-id: 0b1835b454f9b0c457f722ab38f84f89aca383fb
-
- 28 May, 2020 7 commits
-
-
Andrew Huang authored
Summary: Add detailed comment to SSL_CTX_set_session_cache_mode call in SSLContext, since any changes can result in breaking functionality or increased memory usage. Reviewed By: mingtaoy Differential Revision: D21769914 fbshipit-source-id: 61a172f24cda870d6c13a24d279509e2e2804538
-
Lewis Baker authored
Make collectAll, collectAllRange, collectAllWindowed consistently rethrow exception from first failure Summary: The void-returning variants of collectAllRange() and collectAllWindowed() were previously failing with the error from the first task to fail whereas the other variants of collectAll() were failing with an arbitrary error (typically first by argument order) in the case of multiple errors. This was problematic because after the first task failed it requests cancellation of the other tasks, which then often will complete with an 'OperationCancelled' error. This mean that, unless the original error occurred on the first failed task in argument order, the error that caused the cancellation would be discarded and instead, the collectAll() operation would result in an 'OperationCancelled' error. This change updates those algorithms to now consistently fail with the error from the first task to fail (in time) as this error will typically be the most useful in determining the root cause of the failure. Also it now discards any errors that occur in child tasks if they fail after cancellation was requested on the parent task. In this case the collectAll() will complete with an 'OperationCancelled' error. Also made a few drive-by changes to avoid rethrowing exceptions where possible by using `co_yield co_error(e)`. Reviewed By: yfeldblum Differential Revision: D21681812 fbshipit-source-id: dfe15d0672dcbdeb4e156962cdffe767ddf91a0b
-
Lewis Baker authored
Summary: Adds the ability to request cancellation of the folly::coro::UnboundedQueue's dequeue() operation by injecting a CancellationToken using co_withCancellation(). Most of the work for supporting this was implemented in the change to Semaphore::co_wait() to support cancellation. This diff just adds some tests for cancellation of UnboundedQueue::dequeue() and provides a more efficient code-path for the cancellation-case that does not involve throwing an exception. Reviewed By: yfeldblum Differential Revision: D21555325 fbshipit-source-id: 7fbae8aa426b40bbea4d0d6dec85df4bad813733
-
Lewis Baker authored
Summary: The `Semaphore::co_await()` method now response to requests for cancellation communicated through the awaiting context's CancellationToken. This allows interrupting a wait-operation if the result is no longer required, in which case the co_wait() task completes with the OperationCancelled exception. Reviewed By: yfeldblum Differential Revision: D21655946 fbshipit-source-id: 8c7f862580ddebd2b4d3eb3cc3ab5e01ad5ee289
-
Lewis Baker authored
Summary: Now use an intrusive list structure to store the list of waiters waiting for the semaphore to be signalled. This is primarily motivated by the need to support efficient cancellation, which requires the ability to efficiently remove a specific element from the waiter list without having to scan the list like we would for the existing `std::deque`-based list storage. Another beneift of this change is that it now eliminates memory allocations that were previously required by the std::deque container. The `Semaphore::future_wait()` implementation should now also have one fewer allocations as the allocation of the Baton and the Baton::Waiter are now fused. Reviewed By: yfeldblum Differential Revision: D21692257 fbshipit-source-id: 9beff176b250ae3f37df9e2138f93b15d2607353
-
Kyle Nekritz authored
Summary: These only had a 1 month expiration after D21271202. Reviewed By: xybu, mingtaoy Differential Revision: D21765601 fbshipit-source-id: 18b9f400e96b2ba39df650db9e6627f1cf917250
-
Matt Ma authored
Summary: If inline functions are enabled, actual frames used can be larger than the address count. Reviewed By: luciang Differential Revision: D21371112 fbshipit-source-id: c1e602b62b6af427f11701bf25894a99f554ec47
-
- 27 May, 2020 2 commits
-
-
Pranav Thulasiram Bhat authored
Summary: Baton is the primitive that allows fibers to block. The goal of this diff is to provide an `Async` interface to blocking calls that operate on Batons. Overloading `await` directly was one option, however, there are 3 blocking baton APIs (wait, try_wait_for and try_wait_until). Morover these APIs can accept arguments (something async::await doesn't do so far) So, this diff adds a bunch of wrappers that return Async<> results that must be 'awaited' on. This keeps static-analysis happy, and performs the onFiber check. Reviewed By: yfeldblum Differential Revision: D21667887 fbshipit-source-id: 774c19d223ebb0932c043e4c09635c5e85cc8241
-
Maged Michael authored
Summary: Fix race condition between releaseRefClearDelete and releaseRefDeleteOnly by fixing handling in releaseRefClearDelete of the case where the clear count is 1 and the delete count is > 1. The correct behavior of releaseRefClearDelete when delete count > 1 is to release the clear count first and then release the delete count, instead of releasing the two counts in one step. The following sequence of events demonstrates the problem in the absence of the fix: - clear count == 1 and delete count == 2 - Thread 1 calls releaseRefClearDeleteCount - Thread 2 calls releaseRefDeleteOnly - Thread 1 atomically decrements the counts to 0 and 1 - Thread 2 atomically decrements the delete count to 0 - Thread 2 deletes the RequestData object - Thread 1 call to onClear accesses deleted object Reviewed By: yfeldblum, davidtgoldblatt Differential Revision: D21705266 fbshipit-source-id: 8ec2151c4e98968beaef7e9ccec0a786ca5ae267
-
- 26 May, 2020 4 commits
-
-
Jon Maltiel Swenson authored
Summary: This diff factors out some of the logic needed in the stacked diff D21628842. We want `RocketClientChannel::sendRequestResponse` to work without a fiber if the caller is not already on a fiber, which means we cannot only use `Baton::TimeoutHandler` for the request's timeout callback. Reviewed By: iahs Differential Revision: D21628871 fbshipit-source-id: 2e739f205fcb0a255108fa88f94107378a1bab49
-
Chad Austin authored
Summary: In order to use the Python 3 streaming thrift client on platforms that don't support coroutines, conditionally define anything that depends on coroutines. Reviewed By: yfeldblum Differential Revision: D21692900 fbshipit-source-id: 9f26d598097181ae43d1ff377a22b1c2f789321e
-
Yedidya Feldblum authored
Summary: Add missing includes of `folly/synchronization/Baton.h`. Differential Revision: D21716396 fbshipit-source-id: 8c8fb818f3083b4fe04fd1c62923d7ba698dcedd
-
Dan Melnic authored
Summary: Add AsyncUDPSocket::maxReadsPerEvent_ support Reviewed By: yfeldblum Differential Revision: D21509991 fbshipit-source-id: 5c4f939c1cfdda8711864df3b5f5c58439f8d7bf
-
- 25 May, 2020 1 commit
-
-
Yedidya Feldblum authored
Summary: [Folly] Compare `exception_wrapper::class_name()` to `demangle(typeid(...))` in tests v.s. comparing it to string literals since the actual result of `...::class_name()` depends on the platform and whether `libiberty-dev` is available. Differential Revision: D21711569 fbshipit-source-id: b2289d89923d6775c7e806eff9c3732ad37a0218
-
- 24 May, 2020 1 commit
-
-
Yedidya Feldblum authored
Summary: [Folly] Prefer `EndsWith` matcher in `exception_wrapper` test so that, in case of failure, the non-matching input will be shown. Differential Revision: D21708674 fbshipit-source-id: 022f7d64a030417b80b8796ae3d78534295509fc
-
- 23 May, 2020 2 commits
-
-
Yedidya Feldblum authored
Summary: [Folly] Comments in `folly/synchronization/Lock.h`. Differential Revision: D21689050 fbshipit-source-id: 65ffa2cf9bf3afe8740ae0c4a0d529c706397dae
-
Yedidya Feldblum authored
Summary: [Folly] Extract utf-16 surrogate-pair helpers from `folly/json.cpp` into `folly/Unicode.h`. Reviewed By: luciang Differential Revision: D21634400 fbshipit-source-id: 64d15e79fe19cce5f5c9c38837d4663209b5f888
-
- 22 May, 2020 1 commit
-
-
Lee Howes authored
Summary: Add tracing to SemiFuture destruction that is potentially work-dropping. Reviewed By: yfeldblum Differential Revision: D21671142 fbshipit-source-id: 8e3e733d9a0845b00fe7ccf465e9c817a10fee59
-