🐛 fix leak for strings

6cbdc839 · Niels Lohmann · 149ded85 · 6cbdc839 · 6cbdc839
Unverified Commit 6cbdc839 authored Jul 15, 2021 by Niels Lohmann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

include/nlohmann/detail/conversions/to_json.hpp include/nlohmann/detail/conversions/to_json.hpp +1 -0

single_include/nlohmann/json.hpp single_include/nlohmann/json.hpp +1 -0

No files found.
--- a/include/nlohmann/detail/conversions/to_json.hpp
+++ b/include/nlohmann/detail/conversions/to_json.hpp
@@ -236,6 +236,7 @@ template<typename BasicJsonType, typename CompatibleString,
         enable_if_t<std::is_constructible<typename BasicJsonType::string_t, CompatibleString>::value, int> = 0>
 void to_json(BasicJsonType& j, const CompatibleString& s)
 {
+    j.m_value.destroy(j.m_type);
    external_constructor<value_t::string>::construct(j, s);
 }

--- a/single_include/nlohmann/json.hpp
+++ b/single_include/nlohmann/json.hpp
@@ -4694,6 +4694,7 @@ template<typename BasicJsonType, typename CompatibleString,
         enable_if_t<std::is_constructible<typename BasicJsonType::string_t, CompatibleString>::value, int> = 0>
 void to_json(BasicJsonType& j, const CompatibleString& s)
 {
+    j.m_value.destroy(j.m_type);
    external_constructor<value_t::string>::construct(j, s);
 }