🐛 fix leak for strings

c1298e69 · Niels Lohmann · 6cbdc839 · c1298e69
Unverified Commit c1298e69 authored Jul 15, 2021 by Niels Lohmann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

include/nlohmann/detail/conversions/to_json.hpp include/nlohmann/detail/conversions/to_json.hpp +4 -1

No files found.
--- a/include/nlohmann/detail/conversions/to_json.hpp
+++ b/include/nlohmann/detail/conversions/to_json.hpp
@@ -236,7 +236,10 @@ template<typename BasicJsonType, typename CompatibleString,
         enable_if_t<std::is_constructible<typename BasicJsonType::string_t, CompatibleString>::value, int> = 0>
 void to_json(BasicJsonType& j, const CompatibleString& s)
 {
-    j.m_value.destroy(j.m_type);
+    if (!j.is_null())
+    {
+        j = nullptr;
+    }
    external_constructor<value_t::string>::construct(j, s);
 }