Skip to content

J
json
Unverified Commit ecaac226 authored by Niels Lohmann's avatar Niels Lohmann
Browse files
Options

💡 add comment to describe j.m_value.destroy(j.m_type) calls

parent f6863e06
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 0 deletions
include/nlohmann/detail/conversions/to_json.hpp
View file @ ecaac226
......@@ -22,6 +22,13 @@ namespace detail
// constructors //
//////////////////
/*
* Note all external_constructor<>::construct functions need to call
* j.m_value.destroy(j.m_type) to avoid a memory leak in case j contains an
* allocated value (e.g., a string). See bug issue
* https://github.com/nlohmann/json/issues/2865 for more information.
*/
template<value_t> struct external_constructor;
template<>
......
single_include/nlohmann/json.hpp
View file @ ecaac226
......@@ -4480,6 +4480,13 @@ namespace detail
// constructors //
//////////////////
/*
* Note all external_constructor<>::construct functions need to call
* j.m_value.destroy(j.m_type) to avoid a memory leak in case j contains an
* allocated value (e.g., a string). See bug issue
* https://github.com/nlohmann/json/issues/2865 for more information.
*/
template<value_t> struct external_constructor;
template<>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment