Skip to content

M
mruby
Unverified Commit 01dbbcd5 authored by Yukihiro "Matz" Matsumoto's avatar Yukihiro "Matz" Matsumoto
Browse files
Options

Handle integer overflow in `rational_s_new`.

parent e479a427
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 8 deletions
mrbgems/mruby-rational/src/rational.c
View file @ 01dbbcd5
...@@ -109,26 +109,27 @@ rational_s_new(mrb_state *mrb, mrb_value self) ...@@ -109,26 +109,27 @@ rational_s_new(mrb_state *mrb, mrb_value self)
denominator = mrb_integer(denomv); denominator = mrb_integer(denomv);
} }
else { else {
mrb_float numf = (mrb_float)numerator;
mrb_float denomf = mrb_to_flo(mrb, denomv); mrb_float denomf = mrb_to_flo(mrb, denomv);
DROP_PRECISION(denomf, numerator, denomf); DROP_PRECISION(denomf, numf, denomf);
numerator = (mrb_int)numf;
denominator = (mrb_int)denomf; denominator = (mrb_int)denomf;
} }
} }
else { else {
mrb_float numf = mrb_to_flo(mrb, numv); mrb_float numf = mrb_to_flo(mrb, numv);
mrb_float denomf;
if (mrb_integer_p(denomv)) { if (mrb_integer_p(denomv)) {
denominator = mrb_integer(denomv); denomf = (mrb_float)mrb_integer(denomv);
} }
else { else {
mrb_float denomf = mrb_to_flo(mrb, denomv); denomf = mrb_to_flo(mrb, denomv);
DROP_PRECISION(denomf, numf, denomf);
denominator = (mrb_int)denomf;
} }
DROP_PRECISION(denomf, numf, denomf);
DROP_PRECISION(numf, numf, denominator); DROP_PRECISION(numf, numf, denomf);
denominator = (mrb_int)denomf;
numerator = (mrb_int)numf; numerator = (mrb_int)numf;
} }
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment