Commit a53f2827 authored by KOBAYASHI Shuji's avatar KOBAYASHI Shuji

Fix `MRB_FIXNUM_SHIFT` with `MRB_WORD_BOXING`, `MRB_INT32` and `MRB_64BIT`

### Example

  ```ruby
  # example.rb
  max32 = 2**30 - 1 + 2**30
  min32 = -max32-1
  [max32, max32+1, min32, min32-1].each{|n| p [n, n.class]}
  ```

#### Before this patch:

  ```
  $ bin/mruby example.rb
  [2147483647, Float]
  [2147483648, Float]
  [-2147483648, Float]
  [-2147483649, Float]
  ```

#### After this patch:

  ```
  $ bin/mruby example.rb
  [2147483647, Fixnum]
  [2147483648, Float]
  [-2147483648, Fixnum]
  [-2147483649, Float]
  ```
parent ef95a9fa
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#endif #endif
#define MRB_FIXNUM_SHIFT 0 #define MRB_FIXNUM_SHIFT 0
#define MRB_SYMBOL_SHIFT 0
/* value representation by nan-boxing: /* value representation by nan-boxing:
* float : FFFFFFFFFFFFFFFF FFFFFFFFFFFFFFFF FFFFFFFFFFFFFFFF FFFFFFFFFFFFFFFF * float : FFFFFFFFFFFFFFFF FFFFFFFFFFFFFFFF FFFFFFFFFFFFFFFF FFFFFFFFFFFFFFFF
......
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#define MRUBY_BOXING_NO_H #define MRUBY_BOXING_NO_H
#define MRB_FIXNUM_SHIFT 0 #define MRB_FIXNUM_SHIFT 0
#define MRB_SYMBOL_SHIFT 0
union mrb_value_union { union mrb_value_union {
#ifndef MRB_WITHOUT_FLOAT #ifndef MRB_WITHOUT_FLOAT
......
...@@ -34,41 +34,46 @@ enum mrb_special_consts { ...@@ -34,41 +34,46 @@ enum mrb_special_consts {
MRB_Qundef = 20, MRB_Qundef = 20,
}; };
#define MRB_FIXNUM_SHIFT 1 #if defined(MRB_64BIT) && defined(MRB_INT32)
#define MRB_SYMBOL_SHIFT 2 #define MRB_FIXNUM_SHIFT 0
#define MRB_FIXNUM_FLAG (1 << (MRB_FIXNUM_SHIFT - 1)) #else
#define MRB_SYMBOL_FLAG (1 << (MRB_SYMBOL_SHIFT - 1)) #define MRB_FIXNUM_SHIFT BOXWORD_FIXNUM_SHIFT
#define MRB_FIXNUM_MASK ((1 << MRB_FIXNUM_SHIFT) - 1) #endif
#define MRB_SYMBOL_MASK ((1 << MRB_SYMBOL_SHIFT) - 1) #define MRB_SYMBOL_SHIFT BOXWORD_SYMBOL_SHIFT
#define MRB_IMMEDIATE_MASK 0x07
#define BOXWORD_FIXNUM_BIT_POS 1
#define BOXWORD_SYMBOL_BIT_POS 2
#define BOXWORD_FIXNUM_SHIFT BOXWORD_FIXNUM_BIT_POS
#ifdef MRB_64BIT #ifdef MRB_64BIT
#define MRB_SYMBOL_BIT (sizeof(mrb_sym) * CHAR_BIT) #define BOXWORD_SYMBOL_SHIFT 0
#define MRB_SYMBOL_MAX UINT32_MAX
#else #else
#define MRB_SYMBOL_BIT (sizeof(mrb_sym) * CHAR_BIT - MRB_SYMBOL_SHIFT) #define BOXWORD_SYMBOL_SHIFT BOXWORD_SYMBOL_BIT_POS
#define MRB_SYMBOL_MAX (UINT32_MAX >> MRB_SYMBOL_SHIFT)
#endif #endif
#define BOXWORD_FIXNUM_FLAG (1 << (BOXWORD_FIXNUM_BIT_POS - 1))
#define BOXWORD_SYMBOL_FLAG (1 << (BOXWORD_SYMBOL_BIT_POS - 1))
#define BOXWORD_FIXNUM_MASK ((1 << BOXWORD_FIXNUM_BIT_POS) - 1)
#define BOXWORD_SYMBOL_MASK ((1 << BOXWORD_SYMBOL_BIT_POS) - 1)
#define BOXWORD_IMMEDIATE_MASK 0x07
#define BOXWORD_SHIFT_VALUE(o,n,t) \ #define BOXWORD_SHIFT_VALUE(o,n,t) \
((((t)(o).w)) >> MRB_##n##_SHIFT) (t)(((long)(o).w) >> BOXWORD_##n##_SHIFT)
#define BOXWORD_SET_SHIFT_VALUE(o,n,v) \ #define BOXWORD_SET_SHIFT_VALUE(o,n,v) \
((o).w = (((unsigned long)(v)) << MRB_##n##_SHIFT) | MRB_##n##_FLAG) ((o).w = (((unsigned long)(v)) << BOXWORD_##n##_SHIFT) | BOXWORD_##n##_FLAG)
#define BOXWORD_SHIFT_VALUE_P(o,n) \ #define BOXWORD_SHIFT_VALUE_P(o,n) \
(((o).w & MRB_##n##_MASK) == MRB_##n##_FLAG) (((o).w & BOXWORD_##n##_MASK) == BOXWORD_##n##_FLAG)
#define BOXWORD_OBJ_TYPE_P(o,n) \ #define BOXWORD_OBJ_TYPE_P(o,n) \
(!mrb_immediate_p(o) && (o).value.bp->tt == MRB_TT_##n) (!mrb_immediate_p(o) && (o).value.bp->tt == MRB_TT_##n)
/* /*
* mrb_value representation: * mrb_value representation:
* *
* nil : ...0000 0000 (all bits are zero) * nil : ...0000 0000 (all bits are 0)
* false : ...0000 0100 * false : ...0000 0100 (mrb_fixnum(v) != 0)
* true : ...0000 1100 * true : ...0000 1100
* undef : ...0001 0100 * undef : ...0001 0100
* fixnum: ...IIII III1 * fixnum: ...IIII III1
* symbol: ...SSSS SS10 (high-order 32-bit are symbol value in 64-bit mode) * symbol: ...SSSS SS10 (use only upper 32-bit as symbol value on 64-bit CPU)
* object: ...PPPP P000 * object: ...PPPP P000 (any bits are 1)
*/ */
typedef union mrb_value { typedef union mrb_value {
union { union {
...@@ -114,10 +119,10 @@ MRB_API mrb_value mrb_word_boxing_float_pool(struct mrb_state*, mrb_float); ...@@ -114,10 +119,10 @@ MRB_API mrb_value mrb_word_boxing_float_pool(struct mrb_state*, mrb_float);
#endif #endif
#define mrb_bool(o) (((o).w & ~(unsigned long)MRB_Qfalse) != 0) #define mrb_bool(o) (((o).w & ~(unsigned long)MRB_Qfalse) != 0)
#define mrb_immediate_p(o) ((o).w & MRB_IMMEDIATE_MASK || (o).w == MRB_Qnil) #define mrb_immediate_p(o) ((o).w & BOXWORD_IMMEDIATE_MASK || (o).w == MRB_Qnil)
#define mrb_fixnum_p(o) BOXWORD_SHIFT_VALUE_P(o, FIXNUM) #define mrb_fixnum_p(o) BOXWORD_SHIFT_VALUE_P(o, FIXNUM)
#ifdef MRB_64BIT #ifdef MRB_64BIT
#define mrb_symbol_p(o) ((o).value.sym_flag == MRB_SYMBOL_FLAG) #define mrb_symbol_p(o) ((o).value.sym_flag == BOXWORD_SYMBOL_FLAG)
#else #else
#define mrb_symbol_p(o) BOXWORD_SHIFT_VALUE_P(o, SYMBOL) #define mrb_symbol_p(o) BOXWORD_SHIFT_VALUE_P(o, SYMBOL)
#endif #endif
...@@ -159,7 +164,7 @@ MRB_API mrb_value mrb_word_boxing_float_pool(struct mrb_state*, mrb_float); ...@@ -159,7 +164,7 @@ MRB_API mrb_value mrb_word_boxing_float_pool(struct mrb_state*, mrb_float);
#define SET_BOOL_VALUE(r,b) ((b) ? SET_TRUE_VALUE(r) : SET_FALSE_VALUE(r)) #define SET_BOOL_VALUE(r,b) ((b) ? SET_TRUE_VALUE(r) : SET_FALSE_VALUE(r))
#define SET_INT_VALUE(r,n) BOXWORD_SET_SHIFT_VALUE(r, FIXNUM, n) #define SET_INT_VALUE(r,n) BOXWORD_SET_SHIFT_VALUE(r, FIXNUM, n)
#ifdef MRB_64BIT #ifdef MRB_64BIT
#define SET_SYM_VALUE(r,v) ((r).value.sym = v, (r).value.sym_flag = MRB_SYMBOL_FLAG) #define SET_SYM_VALUE(r,v) ((r).value.sym = v, (r).value.sym_flag = BOXWORD_SYMBOL_FLAG)
#else #else
#define SET_SYM_VALUE(r,n) BOXWORD_SET_SHIFT_VALUE(r, SYMBOL, n) #define SET_SYM_VALUE(r,n) BOXWORD_SET_SHIFT_VALUE(r, SYMBOL, n)
#endif #endif
......
...@@ -169,10 +169,8 @@ typedef void mrb_value; ...@@ -169,10 +169,8 @@ typedef void mrb_value;
#include "boxing_no.h" #include "boxing_no.h"
#endif #endif
#if !defined(MRB_SYMBOL_BIT) #define MRB_SYMBOL_BIT (sizeof(mrb_sym) * CHAR_BIT - MRB_SYMBOL_SHIFT)
#define MRB_SYMBOL_BIT (sizeof(mrb_sym) * CHAR_BIT) #define MRB_SYMBOL_MAX (UINT32_MAX >> MRB_SYMBOL_SHIFT)
#define MRB_SYMBOL_MAX UINT32_MAX
#endif
#if INTPTR_MAX < MRB_INT_MAX #if INTPTR_MAX < MRB_INT_MAX
typedef intptr_t mrb_ssize; typedef intptr_t mrb_ssize;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment