Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mruby
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
mruby
Commits
ef95dcd3
Commit
ef95dcd3
authored
Nov 18, 2015
by
murase_syuka
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bugfix nagative-number lshift() bit overflow
parent
557ab347
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
3 deletions
+19
-3
src/numeric.c
src/numeric.c
+16
-3
test/t/integer.rb
test/t/integer.rb
+3
-0
No files found.
src/numeric.c
View file @
ef95dcd3
...
...
@@ -821,15 +821,28 @@ static mrb_value
lshift
(
mrb_state
*
mrb
,
mrb_int
val
,
mrb_int
width
)
{
mrb_assert
(
width
>
0
);
if
((
width
>
NUMERIC_SHIFT_WIDTH_MAX
)
||
(
val
>
(
MRB_INT_MAX
>>
width
)))
{
if
(
val
>
0
)
{
if
((
width
>
NUMERIC_SHIFT_WIDTH_MAX
)
||
(
val
>
(
MRB_INT_MAX
>>
width
)))
{
goto
bit_overflow
;
}
}
else
{
if
((
width
>
NUMERIC_SHIFT_WIDTH_MAX
)
||
(
val
<
(
MRB_INT_MIN
>>
width
)))
{
goto
bit_overflow
;
}
}
return
mrb_fixnum_value
(
val
<<
width
);
bit_overflow:
{
mrb_float
f
=
(
mrb_float
)
val
;
while
(
width
--
)
{
f
*=
2
;
}
return
mrb_float_value
(
mrb
,
f
);
}
return
mrb_fixnum_value
(
val
<<
width
);
}
static
mrb_value
...
...
test/t/integer.rb
View file @
ef95dcd3
...
...
@@ -150,6 +150,9 @@ assert('Integer#<<', '15.2.8.3.12') do
# Left Shift by 31 is bitShift overflow to SignedInt
assert_equal
2147483648
,
1
<<
31
# -3 Left Shift by 30 is bitShift overflow to SignedInt
assert_equal
-
3221225472
,
-
3
<<
30
end
assert
(
'Integer#>>'
,
'15.2.8.3.13'
)
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment